From: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
To: Nicholas Pratte <npratte@iol.unh.edu>
Cc: probb@iol.unh.edu, bruce.richardson@intel.com,
Honnappa.Nagarahalli@arm.com, thomas@monjalon.net,
jspewock@iol.unh.edu, yoan.picchi@foss.arm.com,
mb@smartsharesystems.com, wathsala.vithanage@arm.com,
paul.szczepanek@arm.com, dev@dpdk.org
Subject: Re: [PATCH v6 0/2] Methodology change for hugepage configuration
Date: Mon, 13 May 2024 11:53:22 +0200 [thread overview]
Message-ID: <CAOb5WZb0yzv1yVzXayGDhvFKE2nTexLHUQxp9fja1-iFEURoCQ@mail.gmail.com> (raw)
In-Reply-To: <20240507174430.29403-1-npratte@iol.unh.edu>
What's the difference between this version and v4?
On Tue, May 7, 2024 at 7:44 PM Nicholas Pratte <npratte@iol.unh.edu> wrote:
>
> In order to prevent accidental misconfiguration of hugepages at runtime,
> the following changes are made to only allow for configuration of 2MB
> hugepages within the DTS config.yaml. In the previous implementation, a
> default hugepage size was selected via the size listed in /proc/meminfo.
> The problem with this implementation is that, assuming the end-user has
> made prior modifications to the system, /proc/meminfo may default to
> hugepage sizes that are not recommended to be configured at runtime
> (i.e. 1GB hugepages). This can lead to two problems: overallocation of
> hugepages (which may crash the remote host) configuration of hugepages
> sizes that are not recommended during runtime. In this new implementation,
> we stipulate that any runtime hugepage configuration size that is not 2MB
> is considered an outlier. If the end-user would like to configure either
> 1GB hugepages or any unique hugepage size outside of 2MB, then they should
> make these configurations either at startup (in the case of 1GB hugepages)
> or runtime outside of DTS configuration (if a user would like hugepages
> that are not 2MB). In either case, the expectation is that, if wish to
> use hugepage sizes that are not 2MB, you will make these changes outside
> and prior to the initialization of DTS.
>
> The end-user has two options: remove the option for hugepage
> configuration in the conf.yaml, or keep the option and specify the
> amount of 2MB hugepages desired. In the case of the former, then we assume
> that hugepages are already configured prior to DTS initialization. In
> the latter case, the user must define the amount of 2MB hugepages to be
> configured at runtime. If the amount of 2MB hugepages requested exceeds
> the amount of 2MB hugepages already configured on the system, then the
> system will remount hugepages to cover the difference. If the amount of
> hugepages requested is either greater than or equal to the amount
> already configured on the system, then nothing is done.
>
> Nicholas Pratte (2):
> dts: Change hugepage runtime config to 2MB Exclusively
> dts: Change hugepage 'amount' to a different term
>
> doc/guides/tools/dts.rst | 6 ++++-
> dts/conf.yaml | 8 +++---
> dts/framework/config/__init__.py | 8 +++---
> dts/framework/config/conf_yaml_schema.json | 12 ++++-----
> dts/framework/config/types.py | 4 +--
> dts/framework/testbed_model/linux_session.py | 28 +++++++++++---------
> dts/framework/testbed_model/node.py | 4 ++-
> dts/framework/testbed_model/os_session.py | 7 ++++-
> 8 files changed, 45 insertions(+), 32 deletions(-)
>
> --
> 2.44.0
>
next prev parent reply other threads:[~2024-05-13 9:53 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 18:45 [PATCH v5 1/2] dts: Change hugepage runtime config to 2MB Exclusively Nicholas Pratte
2024-04-30 18:45 ` [PATCH v5 2/2] dts: Change hugepage 'amount' to a different term Nicholas Pratte
2024-05-02 11:55 ` Juraj Linkeš
2024-05-07 11:15 ` Luca Vizzarro
2024-05-07 12:05 ` Bruce Richardson
2024-05-07 12:43 ` Luca Vizzarro
2024-05-07 13:00 ` Bruce Richardson
2024-05-13 10:06 ` Juraj Linkeš
2024-05-15 15:12 ` Nicholas Pratte
2024-04-30 18:45 ` [PATCH v5 0/2] Methodology change for hugepage configuration Nicholas Pratte
2024-05-07 11:16 ` Luca Vizzarro
2024-05-07 16:37 ` [PATCH v6 " Nicholas Pratte
2024-05-07 16:37 ` [PATCH v6 1/2] dts: Change hugepage runtime config to 2MB Exclusively Nicholas Pratte
2024-05-07 16:37 ` [PATCH v6 2/2] dts: Change hugepage 'amount' to a different term Nicholas Pratte
2024-05-07 17:44 ` [PATCH v6 0/2] Methodology change for hugepage configuration Nicholas Pratte
2024-05-07 17:44 ` [PATCH v6 1/2] dts: Change hugepage runtime config to 2MB Exclusively Nicholas Pratte
2024-05-07 17:44 ` [PATCH v6 2/2] dts: Change hugepage 'amount' to a different term Nicholas Pratte
2024-05-07 17:46 ` [PATCH v6 0/2] Methodology change for hugepage configuration Nicholas Pratte
2024-05-13 9:53 ` Juraj Linkeš [this message]
2024-05-15 14:50 ` Nicholas Pratte
2024-05-29 10:30 ` Juraj Linkeš
2024-05-30 17:58 ` [PATCH v7 " Nicholas Pratte
2024-05-30 17:58 ` [PATCH v7 1/2] dts: Change hugepage runtime config to 2MB Exclusively Nicholas Pratte
2024-05-30 17:58 ` [PATCH v7 2/2] dts: Change hugepage 'amount' to a different term Nicholas Pratte
2024-05-30 18:37 ` [PATCH v8 0/2] Methodology change for hugepage configuration Nicholas Pratte
2024-05-30 19:37 ` Nicholas Pratte
2024-05-30 19:37 ` [PATCH v8 1/2] dts: Change hugepage runtime config to 2MB Exclusively Nicholas Pratte
2024-05-31 6:52 ` Juraj Linkeš
2024-05-31 11:37 ` Luca Vizzarro
2024-05-30 19:38 ` [PATCH v8 2/2] dts: Change hugepage 'amount' to a different term Nicholas Pratte
2024-05-31 6:53 ` Juraj Linkeš
2024-05-31 11:37 ` Luca Vizzarro
2024-05-02 11:55 ` [PATCH v5 1/2] dts: Change hugepage runtime config to 2MB Exclusively Juraj Linkeš
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOb5WZb0yzv1yVzXayGDhvFKE2nTexLHUQxp9fja1-iFEURoCQ@mail.gmail.com \
--to=juraj.linkes@pantheon.tech \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jspewock@iol.unh.edu \
--cc=mb@smartsharesystems.com \
--cc=npratte@iol.unh.edu \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=thomas@monjalon.net \
--cc=wathsala.vithanage@arm.com \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).