From: Suanming Mou <suanmingm@nvidia.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>, Ori Kam <orika@nvidia.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH v2] ethdev: add TCP/IP modify field IDs
Date: Wed, 11 Oct 2023 00:11:06 +0000 [thread overview]
Message-ID: <CO6PR12MB5396ECE2468AB98166A4266BC1CCA@CO6PR12MB5396.namprd12.prod.outlook.com> (raw)
In-Reply-To: <a23442dc-1206-4713-9e96-833ff107dfa3@amd.com>
Hi,
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@amd.com>
> Sent: Tuesday, October 10, 2023 6:24 PM
> To: Suanming Mou <suanmingm@nvidia.com>; Ori Kam <orika@nvidia.com>;
> Aman Singh <aman.deep.singh@intel.com>; Yuying Zhang
> <yuying.zhang@intel.com>; NBU-Contact-Thomas Monjalon (EXTERNAL)
> <thomas@monjalon.net>; Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru>
> Cc: dev@dpdk.org
> Subject: Re: [PATCH v2] ethdev: add TCP/IP modify field IDs
>
> On 9/8/2023 4:49 AM, Suanming Mou wrote:
> > Currently, get TCP/IP header or data length information from traffic
> > is missing in the modify field IDs. This commit adds the missing TCP
> > data_offset, IPv4 IHL/total_len, IPv6 payload_len to modify filed IDs.
> > This allows users be able to manager more TCP/IP fields.
> >
> > Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
> > ---
> >
> > v2: fix typo tcp_date_off -> tcp_data_off
> >
> > ---
> > app/test-pmd/cmdline_flow.c | 1 +
> > lib/ethdev/rte_flow.h | 4 ++++
> > 2 files changed, 5 insertions(+)
> >
>
> Hi Suanming,
>
> Patch looks good. But, testpmd modify flow action support seems not
> documented at all, can you please first add it [1], later update that document with
> this patch?
>
> Also can you please check if `rte_flow.rst` also needs to be updated or not?
Sure, will check and update.
Thanks
>
>
> [1]: `doc/guides/testpmd_app_ug/testpmd_funcs.rst`, `Flow rules management`
> section
next prev parent reply other threads:[~2023-10-11 0:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 8:37 [PATCH] " Suanming Mou
2023-09-08 3:49 ` [PATCH v2] " Suanming Mou
2023-10-10 10:24 ` Ferruh Yigit
2023-10-11 0:11 ` Suanming Mou [this message]
2023-10-11 8:58 ` Suanming Mou
2023-10-11 11:30 ` [PATCH v3 1/2] doc: add modify_field action description Suanming Mou
2023-10-11 11:30 ` [PATCH v3 2/2] ethdev: add TCP/IP modify field IDs Suanming Mou
2023-10-12 14:17 ` [PATCH v3 1/2] doc: add modify_field action description Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR12MB5396ECE2468AB98166A4266BC1CCA@CO6PR12MB5396.namprd12.prod.outlook.com \
--to=suanmingm@nvidia.com \
--cc=aman.deep.singh@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=orika@nvidia.com \
--cc=thomas@monjalon.net \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).