From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: Joyce Kong <Joyce.Kong@arm.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
Ruifeng Wang <Ruifeng.Wang@arm.com>,
"konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
"rsanford@akamai.com" <rsanford@akamai.com>,
"erik.g.carrillo@intel.com" <erik.g.carrillo@intel.com>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"yipeng1.wang@intel.com" <yipeng1.wang@intel.com>,
"sameh.gobriel@intel.com" <sameh.gobriel@intel.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"vladimir.medvedkin@intel.com" <vladimir.medvedkin@intel.com>,
"anatoly.burakov@intel.com" <anatoly.burakov@intel.com>,
"andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"declan.doherty@intel.com" <declan.doherty@intel.com>,
"ciara.power@intel.com" <ciara.power@intel.com>,
"xiaoyun.li@intel.com" <xiaoyun.li@intel.com>,
"nicolas.chautru@intel.com" <nicolas.chautru@intel.com>,
"maryam.tahhan@intel.com" <maryam.tahhan@intel.com>,
"reshma.pattan@intel.com" <reshma.pattan@intel.com>,
"cristian.dumitrescu@intel.com" <cristian.dumitrescu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v1 06/12] test/func_reentrancy: use compiler atomic for data sync
Date: Tue, 9 Nov 2021 21:54:09 +0000 [thread overview]
Message-ID: <DBAPR08MB58141DD6D678BA8E0DE03EC198929@DBAPR08MB5814.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20210802101847.3462-7-joyce.kong@arm.com>
<snip>
>
> Convert rte_atomic usages to compiler atomic built-ins for data sync in
> func_reentrancy test cases.
>
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Looks good.
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> ---
> app/test/test_func_reentrancy.c | 27 +++++++++++++--------------
> 1 file changed, 13 insertions(+), 14 deletions(-)
>
> diff --git a/app/test/test_func_reentrancy.c b/app/test/test_func_reentrancy.c
> index 231c99a9eb..c00ecb8110 100644
> --- a/app/test/test_func_reentrancy.c
> +++ b/app/test/test_func_reentrancy.c
> @@ -20,7 +20,6 @@
> #include <rte_eal.h>
> #include <rte_per_lcore.h>
> #include <rte_lcore.h>
> -#include <rte_atomic.h>
> #include <rte_branch_prediction.h>
> #include <rte_ring.h>
> #include <rte_mempool.h>
> @@ -54,12 +53,12 @@ typedef void (*case_clean_t)(unsigned lcore_id);
>
> #define MAX_LCORES (RTE_MAX_MEMZONE / (MAX_ITER_MULTI * 4U))
>
> -static rte_atomic32_t obj_count = RTE_ATOMIC32_INIT(0); -static
> rte_atomic32_t synchro = RTE_ATOMIC32_INIT(0);
> +static uint32_t obj_count;
> +static uint32_t synchro;
>
> #define WAIT_SYNCHRO_FOR_WORKERS() do { \
> if (lcore_self != rte_get_main_lcore()) \
> - while (rte_atomic32_read(&synchro) == 0); \
> + rte_wait_until_equal_32(&synchro, 1, __ATOMIC_RELAXED); \
> } while(0)
>
> /*
> @@ -72,7 +71,7 @@ test_eal_init_once(__rte_unused void *arg)
>
> WAIT_SYNCHRO_FOR_WORKERS();
>
> - rte_atomic32_set(&obj_count, 1); /* silent the check in the caller */
> + __atomic_store_n(&obj_count, 1, __ATOMIC_RELAXED); /* silent the
> check
> +in the caller */
> if (rte_eal_init(0, NULL) != -1)
> return -1;
>
> @@ -112,7 +111,7 @@ ring_create_lookup(__rte_unused void *arg)
> for (i = 0; i < MAX_ITER_ONCE; i++) {
> rp = rte_ring_create("fr_test_once", 4096, SOCKET_ID_ANY,
> 0);
> if (rp != NULL)
> - rte_atomic32_inc(&obj_count);
> + __atomic_fetch_add(&obj_count, 1,
> __ATOMIC_RELAXED);
> }
>
> /* create/lookup new ring several times */ @@ -176,7 +175,7 @@
> mempool_create_lookup(__rte_unused void *arg)
> my_obj_init, NULL,
> SOCKET_ID_ANY, 0);
> if (mp != NULL)
> - rte_atomic32_inc(&obj_count);
> + __atomic_fetch_add(&obj_count, 1,
> __ATOMIC_RELAXED);
> }
>
> /* create/lookup new ring several times */ @@ -239,7 +238,7 @@
> hash_create_free(__rte_unused void *arg)
> for (i = 0; i < MAX_ITER_ONCE; i++) {
> handle = rte_hash_create(&hash_params);
> if (handle != NULL)
> - rte_atomic32_inc(&obj_count);
> + __atomic_fetch_add(&obj_count, 1,
> __ATOMIC_RELAXED);
> }
>
> /* create mutiple times simultaneously */ @@ -303,7 +302,7 @@
> fbk_create_free(__rte_unused void *arg)
> for (i = 0; i < MAX_ITER_ONCE; i++) {
> handle = rte_fbk_hash_create(&fbk_params);
> if (handle != NULL)
> - rte_atomic32_inc(&obj_count);
> + __atomic_fetch_add(&obj_count, 1,
> __ATOMIC_RELAXED);
> }
>
> /* create mutiple fbk tables simultaneously */ @@ -365,7 +364,7 @@
> lpm_create_free(__rte_unused void *arg)
> for (i = 0; i < MAX_ITER_ONCE; i++) {
> lpm = rte_lpm_create("fr_test_once", SOCKET_ID_ANY,
> &config);
> if (lpm != NULL)
> - rte_atomic32_inc(&obj_count);
> + __atomic_fetch_add(&obj_count, 1,
> __ATOMIC_RELAXED);
> }
>
> /* create mutiple fbk tables simultaneously */ @@ -427,8 +426,8 @@
> launch_test(struct test_case *pt_case)
> if (pt_case->func == NULL)
> return -1;
>
> - rte_atomic32_set(&obj_count, 0);
> - rte_atomic32_set(&synchro, 0);
> + __atomic_store_n(&obj_count, 0, __ATOMIC_RELAXED);
> + __atomic_store_n(&synchro, 0, __ATOMIC_RELAXED);
>
> RTE_LCORE_FOREACH_WORKER(lcore_id) {
> if (cores == 1)
> @@ -437,7 +436,7 @@ launch_test(struct test_case *pt_case)
> rte_eal_remote_launch(pt_case->func, pt_case->arg,
> lcore_id);
> }
>
> - rte_atomic32_set(&synchro, 1);
> + __atomic_store_n(&synchro, 1, __ATOMIC_RELAXED);
>
> if (pt_case->func(pt_case->arg) < 0)
> ret = -1;
> @@ -454,7 +453,7 @@ launch_test(struct test_case *pt_case)
> pt_case->clean(lcore_id);
> }
>
> - count = rte_atomic32_read(&obj_count);
> + count = __atomic_load_n(&obj_count, __ATOMIC_RELAXED);
> if (count != 1) {
> printf("%s: common object allocated %d times (should be
> 1)\n",
> pt_case->name, count);
> --
> 2.17.1
next prev parent reply other threads:[~2021-11-09 21:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 10:18 [dpdk-dev] [PATCH v1 00/12] use compiler atomic builtins for app Joyce Kong
2021-08-02 10:18 ` [dpdk-dev] [PATCH v1 01/12] test/pmd_perf: use compiler atomic builtins for polling sync Joyce Kong
2021-11-08 22:50 ` Honnappa Nagarahalli
2021-11-10 6:10 ` Joyce Kong
2021-08-02 10:18 ` [dpdk-dev] [PATCH v1 02/12] test/ring_perf: use compiler atomic builtins for lcores sync Joyce Kong
2021-11-09 5:43 ` Honnappa Nagarahalli
2021-08-02 10:18 ` [dpdk-dev] [PATCH v1 03/12] test/timer: use compiler atomic builtins for sync Joyce Kong
2021-11-09 20:59 ` Honnappa Nagarahalli
2021-08-02 10:18 ` [dpdk-dev] [PATCH v1 04/12] test/stack_perf: use compiler atomics for lcore sync Joyce Kong
2021-11-09 21:12 ` Honnappa Nagarahalli
2021-08-02 10:18 ` [dpdk-dev] [PATCH v1 05/12] test/bpf: use compiler atomics for calculation Joyce Kong
2021-08-02 10:18 ` [dpdk-dev] [PATCH v1 06/12] test/func_reentrancy: use compiler atomic for data sync Joyce Kong
2021-11-09 21:54 ` Honnappa Nagarahalli [this message]
2021-08-02 10:18 ` [dpdk-dev] [PATCH v1 07/12] app/eventdev: use compiler atomic builtins for packets sync Joyce Kong
2021-11-10 23:19 ` Honnappa Nagarahalli
2021-11-11 7:27 ` Joyce Kong
2021-08-02 10:18 ` [dpdk-dev] [PATCH v1 08/12] app/crypto: use compiler atomic builtins for display sync Joyce Kong
2021-11-09 22:11 ` Honnappa Nagarahalli
2021-08-02 10:18 ` [dpdk-dev] [PATCH v1 09/12] app/compress: " Joyce Kong
2021-11-09 22:59 ` Honnappa Nagarahalli
2021-11-11 8:13 ` Joyce Kong
2021-08-02 10:18 ` [dpdk-dev] [PATCH v1 10/12] app/testpmd: use compiler atomic builtins for port sync Joyce Kong
2021-11-09 23:14 ` Honnappa Nagarahalli
2021-11-11 8:51 ` Joyce Kong
2021-08-02 10:18 ` [dpdk-dev] [PATCH v1 11/12] app/bbdev: use compiler atomics for thread sync Joyce Kong
2021-11-10 21:25 ` Honnappa Nagarahalli
2021-08-02 10:18 ` [dpdk-dev] [PATCH v1 12/12] app: remove unnecessary include of atomic Joyce Kong
2021-10-21 6:35 ` [dpdk-dev] [PATCH v1 00/12] use compiler atomic builtins for app Joyce Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBAPR08MB58141DD6D678BA8E0DE03EC198929@DBAPR08MB5814.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=Joyce.Kong@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=anatoly.burakov@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=david.marchand@redhat.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=jerinj@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=maryam.tahhan@intel.com \
--cc=nd@arm.com \
--cc=nicolas.chautru@intel.com \
--cc=olivier.matz@6wind.com \
--cc=reshma.pattan@intel.com \
--cc=rsanford@akamai.com \
--cc=sameh.gobriel@intel.com \
--cc=thomas@monjalon.net \
--cc=vladimir.medvedkin@intel.com \
--cc=xiaoyun.li@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).