From: "Shaikh, Shahed" <Shahed.Shaikh@cavium.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
"Mody, Rasesh" <Rasesh.Mody@cavium.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Dept-Eng DPDK Dev <Dept-EngDPDKDev@cavium.com>
Subject: Re: [dpdk-dev] [PATCH 4/5] app/testpmd: add configuration for udp port tunnel type
Date: Thu, 7 Dec 2017 18:18:29 +0000 [thread overview]
Message-ID: <DM2PR07MB976499E72E49B0A7C5CCD179D330@DM2PR07MB976.namprd07.prod.outlook.com> (raw)
In-Reply-To: <937c1c7a-b8ff-a9ea-2cfe-34b63127b8a3@intel.com>
> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Thursday, December 7, 2017 6:09 AM
> To: Mody, Rasesh <Rasesh.Mody@cavium.com>; dev@dpdk.org
> Cc: Shaikh, Shahed <Shahed.Shaikh@cavium.com>; Dept-Eng DPDK Dev <Dept-
> EngDPDKDev@cavium.com>
> Subject: Re: [dpdk-dev] [PATCH 4/5] app/testpmd: add configuration for udp
> port tunnel type
>
> On 11/24/2017 12:35 PM, Rasesh Mody wrote:
> > From: Shahed Shaikh <shahed.shaikh@cavium.com>
> >
> > Replace rx_vxlan_port command with rx_tunnel_udp_port to support both
> > VXLAN and GENEVE udp ports.
>
> Also updates tunnel_filter command to accept "geneve" argument, can you
> please separate to another patch.
>
> And to prevent these patches hold PMD patches, you can send a new version of
> the patchset splitting qede PMD patches into their own patchset.
Sure. We'll send separate patchset for qede PMD.
>
> >
> > Signed-off-by: Shahed Shaikh <shahed.shaikh@cavium.com>
> > ---
> > app/test-pmd/cmdline.c | 28 +++++++++++++++++++---------
> > 1 file changed, 19 insertions(+), 9 deletions(-)
> >
> > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> > f71d963..4b5a8cd 100644
> > --- a/app/test-pmd/cmdline.c
> > +++ b/app/test-pmd/cmdline.c
> > @@ -402,11 +402,11 @@ static void cmd_help_long_parsed(void
> *parsed_result,
> > "imac-tenid|imac|omac-imac-tenid|oip|iip) (tenant_id)
> (queue_id)\n"
> > " remove a tunnel filter of a port.\n\n"
> >
> > - "rx_vxlan_port add (udp_port) (port_id)\n"
> > - " Add an UDP port for VXLAN packet filter on a
> port\n\n"
> > + "rx_tunnel_udp_port add vxlan|geneve (udp_port)
> (port_id)\n"
>
> Not sure about "rx_tunnel_udp_port" command.
>
> What do you think something like:
> "port config (port_id) udp_tunnel_port add|rm vxlan|geneve (udp_port)"
>
> to expand ""port config (port_id) ..." command instead of introducing a new
> one?
Makes sense. I'll update port_config command.
Thanks,
Shahed
next prev parent reply other threads:[~2017-12-07 18:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-24 20:35 [dpdk-dev] [PATCH 0/5] net/qede: add enhancements and fixes Rasesh Mody
2017-11-24 20:35 ` [dpdk-dev] [PATCH 1/5] net/qede: fix to enable LRO over tunnels Rasesh Mody
2017-11-24 20:35 ` [dpdk-dev] [PATCH 2/5] examples/kni: add optional parameter to enable LRO Rasesh Mody
2017-12-04 23:25 ` Ferruh Yigit
2017-12-05 6:05 ` Shahaf Shuler
2017-12-05 19:43 ` Patil, Harish
2017-12-05 19:42 ` Patil, Harish
2017-11-24 20:35 ` [dpdk-dev] [PATCH 3/5] net/qede: fix to reject config with no Rx queue Rasesh Mody
2017-11-24 20:35 ` [dpdk-dev] [PATCH 4/5] app/testpmd: add configuration for udp port tunnel type Rasesh Mody
2017-12-07 0:38 ` Ferruh Yigit
2017-12-07 18:18 ` Shaikh, Shahed [this message]
2017-11-24 20:35 ` [dpdk-dev] [PATCH 5/5] net/qede: add support for GENEVE tunneling offload Rasesh Mody
2017-12-14 6:36 ` [dpdk-dev] [PATCH v2 0/3] net/qede: add enhancements and fixes Rasesh Mody
2017-12-15 21:05 ` Ferruh Yigit
2017-12-14 6:36 ` [dpdk-dev] [PATCH v2 1/3] net/qede: fix to enable LRO over tunnels Rasesh Mody
2017-12-14 6:36 ` [dpdk-dev] [PATCH v2 2/3] net/qede: fix to reject config with no Rx queue Rasesh Mody
2017-12-14 6:36 ` [dpdk-dev] [PATCH v2 3/3] net/qede: add support for GENEVE tunneling offload Rasesh Mody
2017-12-15 21:01 ` Ferruh Yigit
2017-12-15 21:12 ` Mody, Rasesh
2017-12-16 0:19 ` Ferruh Yigit
2017-12-16 0:42 ` Mody, Rasesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM2PR07MB976499E72E49B0A7C5CCD179D330@DM2PR07MB976.namprd07.prod.outlook.com \
--to=shahed.shaikh@cavium.com \
--cc=Dept-EngDPDKDev@cavium.com \
--cc=Rasesh.Mody@cavium.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).