From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: IOTG DPDK Ref App <iotg.dpdk.ref.app@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH] IGC: Remove I225_I_PHY_ID checking
Date: Tue, 30 Aug 2022 11:17:20 +0000 [thread overview]
Message-ID: <DM4PR11MB5994749716F4B895701032D3D7799@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220829081436.29945-1-iotg.dpdk.ref.app@intel.com>
> -----Original Message-----
> From: iotg.dpdk.ref.app@intel.com <iotg.dpdk.ref.app@intel.com>
> Sent: Monday, August 29, 2022 4:15 PM
> To: dev@dpdk.org
> Subject: [PATCH] IGC: Remove I225_I_PHY_ID checking
>
> From: NSWE SWS DPDK Dev <iotg.dpdk.ref.app@intel.com>
>
> i225 devices have only one PHY vendor. There is unnecessary to check
> _I_PHY_ID during the link establishment and auto-negotiation process, the
> checking also caused devices like i225-IT failed. This patch is to remove the
> mentioned unnecessary checking.
>
> Cc: stable@dpdk.org
> Signed-off-by: NSWE SWS DPDK Dev <iotg.dpdk.ref.app@intel.com>
Is this the expected author name?
> ---
> drivers/net/igc/base/igc_api.c | 1 +
> drivers/net/igc/base/igc_hw.h | 1 +
> drivers/net/igc/base/igc_i225.c | 15 ++-------------
> drivers/net/igc/base/igc_phy.c | 6 ++----
> drivers/net/igc/igc_ethdev.c | 1 +
> 5 files changed, 7 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/net/igc/base/igc_api.c b/drivers/net/igc/base/igc_api.c
> index 9b791dc082..c9fc9ed4b0 100644
> --- a/drivers/net/igc/base/igc_api.c
> +++ b/drivers/net/igc/base/igc_api.c
> @@ -886,6 +886,7 @@ s32 igc_set_mac_type(struct igc_hw *hw)
> case IGC_DEV_ID_I225_V:
> case IGC_DEV_ID_I225_K:
> case IGC_DEV_ID_I225_I:
> + case IGC_DEV_ID_I225_IT:
> case IGC_DEV_ID_I220_V:
> case IGC_DEV_ID_I225_BLANK_NVM:
> case IGC_DEV_ID_I226_K:
> diff --git a/drivers/net/igc/base/igc_hw.h b/drivers/net/igc/base/igc_hw.h
> index 707a1883b4..e919a11c02 100644
> --- a/drivers/net/igc/base/igc_hw.h
> +++ b/drivers/net/igc/base/igc_hw.h
> @@ -164,6 +164,7 @@ struct igc_hw;
> #define IGC_DEV_ID_I225_V 0x15F3
> #define IGC_DEV_ID_I225_K 0x3100
> #define IGC_DEV_ID_I225_I 0x15F8
> +#define IGC_DEV_ID_I225_IT 0x0D9F
The patch's commit log claims to remove something,
but in code it also add some new device ID, could you clarify why we need this or it should be in a separate patch?
next prev parent reply other threads:[~2022-08-30 11:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 8:14 iotg.dpdk.ref.app
2022-08-30 11:17 ` Zhang, Qi Z [this message]
2022-08-31 22:42 ` Mah, Yock Gen
2022-09-01 8:22 ` David Marchand
2022-09-02 7:01 ` David Marchand
2022-08-31 22:51 ` [PATCH v2] " iotg.dpdk.ref.app
2022-09-02 0:18 ` [PATCH v3] " yock.gen.mah
2022-09-04 1:55 ` Zhang, Qi Z
2022-10-11 11:04 ` [PATCH v2] " Kevin Traynor
2022-10-12 7:45 ` Mah, Yock Gen
2022-10-12 8:39 ` Kevin Traynor
2022-10-18 12:54 ` Kevin Traynor
2022-10-18 22:45 ` Mah, Yock Gen
2022-10-19 8:34 ` Kevin Traynor
2022-12-20 15:47 ` Kevin Traynor
2022-12-21 3:01 ` Mah, Yock Gen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB5994749716F4B895701032D3D7799@DM4PR11MB5994.namprd11.prod.outlook.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=iotg.dpdk.ref.app@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).