From: Srikanth Yalavarthi <syalavarthi@marvell.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
"dmitry.kozliuk@gmail.com" <dmitry.kozliuk@gmail.com>
Cc: Aaron Conole <aconole@redhat.com>,
Igor Russkikh <irusskikh@marvell.com>,
David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Shivah Shankar Shankar Narayan Rao <sshankarnara@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Srikanth Yalavarthi <syalavarthi@marvell.com>
Subject: RE: [EXT] Re: [PATCH 1/1] build: update link args and includes for libarchive
Date: Mon, 23 Oct 2023 12:46:59 +0000 [thread overview]
Message-ID: <DS0PR18MB55025E75A4A3CDD771CC7448AED8A@DS0PR18MB5502.namprd18.prod.outlook.com> (raw)
In-Reply-To: <ZTZevoxwGMUVskaJ@bricha3-MOBL.ger.corp.intel.com>
> -----Original Message-----
> From: Bruce Richardson <bruce.richardson@intel.com>
> Sent: 23 October 2023 17:24
> To: Srikanth Yalavarthi <syalavarthi@marvell.com>
> Cc: Aaron Conole <aconole@redhat.com>; Igor Russkikh
> <irusskikh@marvell.com>; David Marchand <david.marchand@redhat.com>;
> dev@dpdk.org; Shivah Shankar Shankar Narayan Rao
> <sshankarnara@marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; stable@dpdk.org
> Subject: Re: [EXT] Re: [PATCH 1/1] build: update link args and includes for
> libarchive
>
> On Mon, Oct 23, 2023 at 11:40:14AM +0000, Srikanth Yalavarthi wrote:
> > > -----Original Message-----
> > > From: Bruce Richardson <bruce.richardson@intel.com>
> > > Sent: 23 October 2023 14:56
> > > To: Srikanth Yalavarthi <syalavarthi@marvell.com>
> > > Cc: Aaron Conole <aconole@redhat.com>; Igor Russkikh
> > > <irusskikh@marvell.com>; David Marchand
> <david.marchand@redhat.com>;
> > > dev@dpdk.org; Shivah Shankar Shankar Narayan Rao
> > > <sshankarnara@marvell.com>; Jerin Jacob Kollanukkaran
> > > <jerinj@marvell.com>; stable@dpdk.org
> > > Subject: [EXT] Re: [PATCH 1/1] build: update link args and includes
> > > for libarchive
> > >
> > > External Email
> > >
> > > --------------------------------------------------------------------
> > > -- On Fri, Oct 20, 2023 at 10:01:35AM -0700, Srikanth Yalavarthi
> > > wrote:
> > > > In order to avoid linking with all libraries listed as
> > > > Libs.private in libarchive.pc, libarchive is not added to ext_deps during
> meson setup.
> > > >
> > > > Since libarchive is not added to ext_deps, cross-compilation or
> > > > native compilation with libarchive installed in non-standard
> > > > location fails with errors related to "cannot find -larchive"
> > > > or "archive.h: No such file or directory". In order to fix the
> > > > build failures, user is required to define the 'c_args' and 'c_link_args'
> > > > with '-I<includedir>' and '-L<libdir>'.
> > > >
> > > > This patch updates meson build files to add libarchive's
> > > > includedir and libdir to compiler flags and would not require
> > > > setting c_args and c_link_args externally.
> > > >
> > > > Fixes: 40edb9c0d36b ("eal: handle compressed firmware")
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> > > > ---
> > >
> > > Checking back through the mail archives I'm still a little unclear
> > > as to what breaks when we try using libarchive as any other package
> > > with a pkg-config file? I would have thought the best solution was
> > > just to add libarchive as an external dependency, found using
> > > pkg-config, to EAL. When we add it as a dependency, rather than
> > > using c/ldflags, we should get all this path fixup for free?
> > > Can you clarify what breaks when we add libarchive as a libeal
> > > dependency only?
> >
> > Below is my observation.
> >
> > In current implementation, we are looking for libarchive's availability
> through pkg-config.
> > When found, we are setting RTE_HAS_LIBARCHIVE=1 and adding '-larchive'
> to ldflags.
> >
> > Since, we are not adding libarchive to ext_deps (to avoid linking with
> > deps.private), the
>
> This is the bit I'm a bit stuck on. What is the issues with adding libarchive to
> ext_deps? For other libs, when doing static builds we have to link with
> deps.private and it's the correct behaviour AFAIK. Not doing so would surely
> lead to problematic builds, no?
I agree on adding to ext_deps as it's the correct behaviour.
However, there was a discussion in mail archives regarding this.
https://inbox.dpdk.org/dev/20210605004024.660267a1@sovereign/
Adding Dmitry Kozlyuk for comments.
>
> /Bruce
next prev parent reply other threads:[~2023-10-23 12:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 17:01 Srikanth Yalavarthi
2023-10-23 9:26 ` Bruce Richardson
2023-10-23 11:40 ` [EXT] " Srikanth Yalavarthi
2023-10-23 11:53 ` Bruce Richardson
2023-10-23 12:46 ` Srikanth Yalavarthi [this message]
2023-10-23 13:00 ` Bruce Richardson
2023-10-23 13:06 ` Bruce Richardson
2023-10-23 14:01 ` Srikanth Yalavarthi
2023-10-26 12:53 ` Srikanth Yalavarthi
2023-10-29 8:10 ` [PATCH v2 1/1] build: add libarchive to external deps Srikanth Yalavarthi
2023-10-29 8:20 ` [PATCH v3 " Srikanth Yalavarthi
2023-11-03 16:38 ` [PATCH v4 " Srikanth Yalavarthi
2023-11-03 16:50 ` Bruce Richardson
2023-11-06 4:27 ` [EXT] " Srikanth Yalavarthi
2023-11-06 4:12 ` [PATCH v5 " Srikanth Yalavarthi
2023-11-06 8:53 ` Bruce Richardson
2023-11-06 15:24 ` Thomas Monjalon
2023-11-06 15:32 ` Thomas Monjalon
2023-11-06 16:03 ` David Marchand
2023-11-06 16:23 ` Bruce Richardson
2023-11-06 18:17 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DS0PR18MB55025E75A4A3CDD771CC7448AED8A@DS0PR18MB5502.namprd18.prod.outlook.com \
--to=syalavarthi@marvell.com \
--cc=aconole@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=irusskikh@marvell.com \
--cc=jerinj@marvell.com \
--cc=sshankarnara@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).