From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Didier Pallard <didier.pallard@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 0/2] Fix CRC32c computation
Date: Fri, 19 Feb 2016 15:08:51 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C8A80F1@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1455879631-18420-1-git-send-email-didier.pallard@6wind.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Didier Pallard
> Sent: Friday, February 19, 2016 11:00 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v3 0/2] Fix CRC32c computation
>
> CRC32c computation is not valid when buffer length is not a multiple of 4
> bytes.
> Values returned by rte_hash_crc functions does not match the one
> computed by a trivial crc32c implementation.
>
> First patch fixes crc hash function autotests, to outline the problem.
> Second patch fixes CRC32c computation.
>
> Didier Pallard (2):
> test: fix CRC hash function autotest
> hash: fix CRC32c computation
>
> app/test/test_hash_functions.c | 17 +++--
> doc/guides/rel_notes/release_16_04.rst | 5 ++
> lib/librte_hash/rte_crc_arm64.h | 64 +++++++++++++++++
> lib/librte_hash/rte_hash_crc.h | 125 ++++++++++++++++++++++++++-----
> --
> 4 files changed, 178 insertions(+), 33 deletions(-)
>
> --
> 2.1.4
Series-acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Not sure if you need to include a "Fixes" line in the commit messages.
In the first commit, probably you should, the commit that you are fixing is
6298d2c55ae8 ("app/test: add new functional tests for hash functions").
In the second commit, it is a bit more difficult, as we don't know that the commit is,
that code was integrated a while ago, before 1.2.3, which is the first public release in dpdk.org.
Also, there is a typo "lengthes", in both commit messages.
You can leave the ack in both patches. Thanks!!
next prev parent reply other threads:[~2016-02-19 15:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 9:34 [dpdk-dev] [PATCH] hash: fix " Didier Pallard
2015-12-23 9:12 ` Qiu, Michael
2015-12-23 11:37 ` Vincent JARDIN
[not found] ` <E115CCD9D858EF4F90C690B0DCB4D8973C8A16BD@IRSMSX108.ger.corp.intel.com>
2016-02-08 14:43 ` De Lara Guarch, Pablo
2016-02-09 9:34 ` [dpdk-dev] [PATCH v2] " Didier Pallard
2016-02-10 12:16 ` De Lara Guarch, Pablo
2016-02-19 11:00 ` [dpdk-dev] [PATCH v3 0/2] Fix " Didier Pallard
2016-02-19 11:00 ` [dpdk-dev] [PATCH v3 1/2] test: fix CRC hash function autotest Didier Pallard
2016-02-19 11:00 ` [dpdk-dev] [PATCH v3 2/2] hash: fix CRC32c computation Didier Pallard
2016-02-19 15:08 ` De Lara Guarch, Pablo [this message]
2016-03-01 13:31 ` [dpdk-dev] [PATCH v3 0/2] Fix " Thomas Monjalon
2016-02-10 14:35 ` [dpdk-dev] [PATCH] hash: fix " Pattan, Reshma
2016-02-11 8:21 ` Didier Pallard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8973C8A80F1@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=didier.pallard@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).