From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] eal: redefine logtype values
Date: Wed, 12 Apr 2017 15:22:24 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D89747808EF5@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <11937147.4rRz3cW7Er@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, April 12, 2017 4:16 PM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org; olivier.matz@6wind.com
> Subject: Re: [dpdk-dev] [PATCH] eal: redefine logtype values
>
> 2017-04-12 15:14, Pablo de Lara:
> > After the changes in commit c1b5fa94a46f
> > ("eal: support dynamic log types"), logtype is not treated as a
> > bitmask, but a decimal value. Therefore, values have to be
> > converted.
> >
> > Fixes: c1b5fa94a46f ("eal: support dynamic log types")
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> [...]
> > /* SDK log type, keep sync'd with rte_log_init() */
> [...]
> > +#define RTE_LOGTYPE_EAL 0 /**< Log related to eal. */
> > +#define RTE_LOGTYPE_MALLOC 1 /**< Log related to malloc. */
> > +#define RTE_LOGTYPE_RING 2 /**< Log related to ring. */
> > +#define RTE_LOGTYPE_MEMPOOL 3 /**< Log related to mempool. */
> > +#define RTE_LOGTYPE_TIMER 4 /**< Log related to timers. */
> > +#define RTE_LOGTYPE_PMD 5 /**< Log related to poll mode driver.
> */
> > +#define RTE_LOGTYPE_HASH 6 /**< Log related to hash table. */
> > +#define RTE_LOGTYPE_LPM 7 /**< Log related to LPM. */
> > +#define RTE_LOGTYPE_KNI 8 /**< Log related to KNI. */
> > +#define RTE_LOGTYPE_ACL 9 /**< Log related to ACL. */
> > +#define RTE_LOGTYPE_POWER 10 /**< Log related to power. */
> > +#define RTE_LOGTYPE_METER 11 /**< Log related to QoS meter. */
> > +#define RTE_LOGTYPE_SCHED 12 /**< Log related to QoS port
> scheduler. */
> > +#define RTE_LOGTYPE_PORT 13 /**< Log related to port. */
> > +#define RTE_LOGTYPE_TABLE 14 /**< Log related to table. */
> > +#define RTE_LOGTYPE_PIPELINE 15 /**< Log related to pipeline. */
> > +#define RTE_LOGTYPE_MBUF 16 /**< Log related to mbuf. */
> > +#define RTE_LOGTYPE_CRYPTODEV 17 /**< Log related to cryptodev. */
> > +#define RTE_LOGTYPE_EFD 18 /**< Log related to EFD. */
> > +#define RTE_LOGTYPE_EVENTDEV 19 /**< Log related to eventdev. */
>
> I think you should use these values in rte_log_init,
> instead of the hardcoded ones.
> So the messages about keeping them sync'd could be removed :)
Good idea, will send a v2 shortly.
next prev parent reply other threads:[~2017-04-12 15:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 14:14 Pablo de Lara
2017-04-12 15:15 ` Thomas Monjalon
2017-04-12 15:22 ` De Lara Guarch, Pablo [this message]
2017-04-12 15:35 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2017-04-12 19:23 ` Olivier MATZ
2017-04-13 8:32 ` De Lara Guarch, Pablo
2017-04-13 9:09 ` De Lara Guarch, Pablo
2017-04-12 21:41 ` Stephen Hemminger
2017-04-13 13:43 ` De Lara Guarch, Pablo
2017-04-13 13:42 ` [dpdk-dev] [PATCH v3] " Pablo de Lara
2017-04-18 9:57 ` Olivier MATZ
2017-04-19 11:12 ` De Lara Guarch, Pablo
2017-04-19 11:22 ` [dpdk-dev] [PATCH] " Pablo de Lara
2017-04-19 11:23 ` De Lara Guarch, Pablo
2017-04-19 11:24 ` [dpdk-dev] [PATCH v4] " Pablo de Lara
2017-04-19 12:15 ` Olivier MATZ
2017-04-19 13:46 ` De Lara Guarch, Pablo
2017-04-19 14:06 ` [dpdk-dev] [PATCH v5] " Pablo de Lara
2017-04-19 14:16 ` Olivier MATZ
2017-04-19 22:49 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D89747808EF5@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).