From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: print statistics periodically
Date: Thu, 6 Jul 2017 10:43:18 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CBD731B@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <20170706100657.GA4232@jerin>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob
> Sent: Thursday, July 6, 2017 11:07 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; thomas@monjalon.net;
> dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: print statistics
> periodically
>
> -----Original Message-----
> > Date: Thu, 6 Jul 2017 02:52:05 +0100
> > From: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > To: jingjing.wu@intel.com, thomas@monjalon.net
> > CC: dev@dpdk.org, Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > Subject: [dpdk-dev] [PATCH v4] app/testpmd: print statistics
> > periodically
> > X-Mailer: git-send-email 2.9.4
> >
> > Add parameter to print port statistics periodically (disabled by
> > default), if interactive mode is not enabled.
> >
> > This is useful to allow the user to see port statistics without having
> > to get into the internal command line.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > Acked-by: Jingjing Wu <jingjing.wu@intel.com>
> > ---
> >
> > Changes in v4:
> >
> > - Removed CamelCase
> > - Used generic rte_get_timer_cycles() function, instead
> > of TSC API.
> >
> > Changes in v3:
> >
> > - Added missing "|" character in help
> >
> > Changes in v2:
> >
> > - Added extra argument in help
> >
> > app/test-pmd/parameters.c | 19 +++++++++++++++--
> > app/test-pmd/testpmd.c | 40
> ++++++++++++++++++++++++++++++++++-
> > app/test-pmd/testpmd.h | 1 +
> > doc/guides/testpmd_app_ug/run_app.rst | 5 +++++
> > 4 files changed, 62 insertions(+), 3 deletions(-)
> >
> > diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
> > index fbe6284..41ed74c 100644
> > --- a/app/test-pmd/parameters.c
> > +++ b/app/test-pmd/parameters.c
> > @@ -88,7 +88,7 @@ usage(char* progname)
> > "[--interactive|-i] "
> > "[--cmdline-file=FILENAME] "
> > #endif
> > - "[--help|-h] | [--auto-start|-a] | ["
> > + "[--help|-h] | [--auto-start|-a] | [-T PERIOD] | ["
> > "--coremask=COREMASK --portmask=PORTMASK --numa "
> > "--mbuf-size= | --total-num-mbufs= | "
> > "--nb-cores= | --nb-ports= | "
> > @@ -109,6 +109,8 @@ usage(char* progname)
> > printf(" --auto-start: start forwarding on init "
> > "[always when non-interactive].\n");
> > printf(" --help: display this message and quit.\n");
> > + printf(" -T PERIOD: statistics will be shown every PERIOD seconds "
>
> Considering all the option are in small letter, Does it makes sense to make it
> as small letter? (ie -t instead of -T).
>
> Other than it looks good and useful feature.
>
> Tested-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Thanks for the testing. I took the parameter name from L2fwd, but you are right,
it should be lowercase. Actually, to make it more explicit, I propose
to change it to "--stats-period".
Will send a v5 soon.
Thanks,
Pablo
next prev parent reply other threads:[~2017-07-06 10:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-28 21:38 [dpdk-dev] [PATCH] " Pablo de Lara
2017-06-07 9:11 ` Wu, Jingjing
2017-06-07 13:13 ` De Lara Guarch, Pablo
2017-06-09 1:46 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2017-06-15 1:48 ` [dpdk-dev] [PATCH v3] " Pablo de Lara
2017-06-19 1:05 ` Wu, Jingjing
2017-06-19 21:22 ` Thomas Monjalon
2017-06-20 8:34 ` De Lara Guarch, Pablo
2017-07-05 23:51 ` Thomas Monjalon
2017-07-06 9:56 ` De Lara Guarch, Pablo
2017-07-06 1:52 ` [dpdk-dev] [PATCH v4] " Pablo de Lara
2017-07-06 3:05 ` [dpdk-dev] [PATCH v5] " Pablo de Lara
2017-07-06 14:20 ` Thomas Monjalon
2017-07-06 10:06 ` [dpdk-dev] [PATCH v4] " Jerin Jacob
2017-07-06 10:43 ` De Lara Guarch, Pablo [this message]
2017-07-06 10:16 ` Thomas Monjalon
2017-07-06 10:19 ` De Lara Guarch, Pablo
2017-06-19 0:54 ` [dpdk-dev] [PATCH v2] " Wu, Jingjing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CBD731B@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jingjing.wu@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).