DPDK patches and discussions
 help / color / mirror / Atom feed
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Doherty, Declan" <declan.doherty@intel.com>
Subject: Re: [dpdk-dev] [PATCH 3/4] test-crypto-perf: add new PMD benchmarking mode
Date: Mon, 4 Sep 2017 14:26:28 +0000	[thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CC153F1@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <74e5903a777894da0c170bfdb7e6b1e425503342.1503566892.git.anatoly.burakov@intel.com>



> -----Original Message-----
> From: Burakov, Anatoly
> Sent: Thursday, August 24, 2017 11:48 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Doherty,
> Declan <declan.doherty@intel.com>; Burakov, Anatoly
> <anatoly.burakov@intel.com>
> Subject: [PATCH 3/4] test-crypto-perf: add new PMD benchmarking mode
> 
> This patch adds a new benchmarking mode, which is intended for
> microbenchmarking individual parts of the cryptodev framework,
> specifically crypto ops alloc-build-free, cryptodev PMD enqueue and
> cryptodev PMD dequeue.
> 
> It works by first benchmarking crypto operation alloc-build-free loop (no
> enqueues/dequeues happening), and then benchmarking enqueue and
> dequeue separately, by first completely filling up the TX queue, and then
> completely draining the RX queue.
> 
> Results are shown as cycle counts per alloc/build/free, PMD enqueue and
> PMD dequeue.
> 
> One new test mode is added: "pmd-cyclecount"
>   (called with --ptest=pmd-cyclecount)
> 
> New command-line argument is also added:
>   --pmd-cyclecount-delay-ms: this is a pmd-cyclecount-specific parameter
>       that controls the delay between enqueue and dequeue. This is
>       useful for benchmarking hardware acceleration, as hardware may
>       not be able to keep up with enqueued packets. This parameter
>       can be increased if there are large amounts of dequeue
>       retries.
> 
> Signed-off-by: Burakov, Anatoly <anatoly.burakov@intel.com>

...

> diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto-
> perf/cperf_options_parsing.c
> index f4097d9..42a920f 100644
> --- a/app/test-crypto-perf/cperf_options_parsing.c
> +++ b/app/test-crypto-perf/cperf_options_parsing.c

...

>  static int
> @@ -782,6 +804,7 @@ cperf_opts_parse_long(int opt_idx, struct
> cperf_options *opts)
>  		{ CPERF_AEAD_AAD_SZ,	parse_aead_aad_sz },
>  		{ CPERF_DIGEST_SZ,	parse_digest_sz },
>  		{ CPERF_CSV,		parse_csv_friendly},
> +		{ CPERF_PMD_CYCLECOUNT_DELAY_MS,
> parse_pmd_cyclecount_delay_ms},

Sorry, I missed this one in the previous email.
To have a consistent alignment, could you make the name of this macro shorter?

Thanks,
Pablo

  parent reply	other threads:[~2017-09-04 14:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24 10:48 [dpdk-dev] [PATCH 0/4] New crypto acceleration benchmark mode Anatoly Burakov
2017-08-24 10:48 ` [dpdk-dev] [PATCH 1/4] test-crypto-perf: add nb-desc parameter Anatoly Burakov
2017-09-04 13:09   ` De Lara Guarch, Pablo
2017-08-24 10:48 ` [dpdk-dev] [PATCH 2/4] doc: document new nb-desc parameter for test-crypto-perf app Anatoly Burakov
2017-09-04 13:12   ` De Lara Guarch, Pablo
2017-08-24 10:48 ` [dpdk-dev] [PATCH 3/4] test-crypto-perf: add new PMD benchmarking mode Anatoly Burakov
2017-09-04 14:24   ` De Lara Guarch, Pablo
2017-09-04 14:26   ` De Lara Guarch, Pablo [this message]
2017-08-24 10:48 ` [dpdk-dev] [PATCH 4/4] doc: document new pmd-cyclecount benchmarking mode in test-crypto-perf Anatoly Burakov
2017-09-04 14:28   ` De Lara Guarch, Pablo
2017-09-12  9:36 ` [dpdk-dev] [PATCH v2 0/2] New crypto acceleration benchmark mode Anatoly Burakov
2017-09-12  9:36   ` [dpdk-dev] [PATCH v2 1/2] app/crypto-perf: add nb-desc parameter Anatoly Burakov
2017-09-18  9:39     ` De Lara Guarch, Pablo
2017-09-12  9:36   ` [dpdk-dev] [PATCH v2 2/2] app/crypto-perf: add new PMD benchmarking mode Anatoly Burakov
2017-09-18 14:05     ` De Lara Guarch, Pablo
2017-09-20 14:04   ` [dpdk-dev] [PATCH v2 0/2] New crypto acceleration benchmark mode De Lara Guarch, Pablo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CC153F1@IRSMSX108.ger.corp.intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).