DPDK patches and discussions
 help / color / mirror / Atom feed
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Doherty, Declan" <declan.doherty@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/2] New crypto acceleration benchmark mode
Date: Wed, 20 Sep 2017 14:04:50 +0000	[thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CC20B9C@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <cover.1505142622.git.anatoly.burakov@intel.com>



> -----Original Message-----
> From: Burakov, Anatoly
> Sent: Tuesday, September 12, 2017 10:36 AM
> To: dev@dpdk.org
> Cc: Doherty, Declan <declan.doherty@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH v2 0/2] New crypto acceleration benchmark mode
> 
> This patchset adds a new "PMD cyclecount" test mode for test-crypto-perf
> application. This mode is intended to measure hardware acceleration cost
> (in terms of cycle count) more accurately than throughput test.
> 
> The general idea is the following:
> - Measure build-alloc-free cycle separately
> - Alloc and build ops
> - Measure completely filling up the TX ring
> - Wait until ops are processed
> - Measure completely draining the RX ring
> - Free all allocated ops
> 
> In order to make measurements more accurate, the enqueue/dequeue is
> still done in bursts of specified size, but all of the bursts are now part of a
> "superburst" of size equal to number of descriptors configured for the
> device. So, if the number of descriptors configured was 2048 (the default),
> then 2048 ops will be enqueued and dequeued, in bursts of size specified by
> test command line.
> 
> The following command-line switch will run the test:
>   --ptest=pmd-cyclecount
> 
> In addition to a new mode, two mode command line switches are added:
> - --desc-nb - configure number of cryptodev descriptors. This value was
>          previously hardcoded to 2048, but is now configurable and set
>          to 2048 by default (so existing behavior is unchanged).
> - --pmd-cyclecount-delay-ms - pmd-cyclecount-specific parameter that
>          configures the delay (in milliseconds) between TX and RX
>          superbursts, to allow hardware to process ops. Set to 0 by
>          default, and it is expected that each user will tune it for
>          every device. This has no effect on other benchmark modes.
> 
> PMD cyclecount mode can be used to benchmark software cryptodev
> drivers as well, but the results will be far less accurate for smaller burst
> sizes.
> 
> v2: squashed documentation patches into relevant commits
>     fixed documentation
>     fixed commit messages
>     formatting and naming fixes
> 
> Anatoly Burakov (2):
>   app/crypto-perf: add nb-desc parameter
>   app/crypto-perf: add new PMD benchmarking mode
> 
>  app/test-crypto-perf/Makefile                    |   1 +
>  app/test-crypto-perf/cperf_options.h             |  10 +-
>  app/test-crypto-perf/cperf_options_parsing.c     |  54 ++
>  app/test-crypto-perf/cperf_test_pmd_cyclecount.c | 675
> +++++++++++++++++++++++  app/test-crypto-
> perf/cperf_test_pmd_cyclecount.h |  61 ++
>  app/test-crypto-perf/main.c                      |  11 +-
>  doc/guides/rel_notes/release_17_11.rst           |   6 +
>  doc/guides/tools/cryptoperf.rst                  |  14 +-
>  8 files changed, 828 insertions(+), 4 deletions(-)  create mode 100644
> app/test-crypto-perf/cperf_test_pmd_cyclecount.c
>  create mode 100644 app/test-crypto-perf/cperf_test_pmd_cyclecount.h
> 
> --
> 2.7.4

Applied to dpdk-next-crypto.

I think it will be a good idea to extend the documentation and explain more in detail
the different modes that the application offers, before the release is out.

Thanks,

Pablo

      parent reply	other threads:[~2017-09-20 14:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24 10:48 [dpdk-dev] [PATCH 0/4] " Anatoly Burakov
2017-08-24 10:48 ` [dpdk-dev] [PATCH 1/4] test-crypto-perf: add nb-desc parameter Anatoly Burakov
2017-09-04 13:09   ` De Lara Guarch, Pablo
2017-08-24 10:48 ` [dpdk-dev] [PATCH 2/4] doc: document new nb-desc parameter for test-crypto-perf app Anatoly Burakov
2017-09-04 13:12   ` De Lara Guarch, Pablo
2017-08-24 10:48 ` [dpdk-dev] [PATCH 3/4] test-crypto-perf: add new PMD benchmarking mode Anatoly Burakov
2017-09-04 14:24   ` De Lara Guarch, Pablo
2017-09-04 14:26   ` De Lara Guarch, Pablo
2017-08-24 10:48 ` [dpdk-dev] [PATCH 4/4] doc: document new pmd-cyclecount benchmarking mode in test-crypto-perf Anatoly Burakov
2017-09-04 14:28   ` De Lara Guarch, Pablo
2017-09-12  9:36 ` [dpdk-dev] [PATCH v2 0/2] New crypto acceleration benchmark mode Anatoly Burakov
2017-09-12  9:36   ` [dpdk-dev] [PATCH v2 1/2] app/crypto-perf: add nb-desc parameter Anatoly Burakov
2017-09-18  9:39     ` De Lara Guarch, Pablo
2017-09-12  9:36   ` [dpdk-dev] [PATCH v2 2/2] app/crypto-perf: add new PMD benchmarking mode Anatoly Burakov
2017-09-18 14:05     ` De Lara Guarch, Pablo
2017-09-20 14:04   ` De Lara Guarch, Pablo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CC20B9C@IRSMSX108.ger.corp.intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).