From: "Wang, Haiyue" <haiyue.wang@intel.com>
To: "Ye, Xiaolong" <xiaolong.ye@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Kinsella, Ray" <ray.kinsella@intel.com>,
"Iremonger, Bernard" <bernard.iremonger@intel.com>,
"Sun, Chenmin" <chenmin.sun@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1 1/4] ethdev: add the API for getting burst mode information
Date: Thu, 26 Sep 2019 13:48:55 +0000 [thread overview]
Message-ID: <E3B9F2FDCB65864C82CD632F23D8AB8773D6E267@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20190926134118.GA91335@intel.com>
> -----Original Message-----
> From: Ye, Xiaolong
> Sent: Thursday, September 26, 2019 21:41
> To: Wang, Haiyue <haiyue.wang@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Kinsella, Ray <ray.kinsella@intel.com>;
> Iremonger, Bernard <bernard.iremonger@intel.com>; Sun, Chenmin <chenmin.sun@intel.com>
> Subject: Re: [PATCH v1 1/4] ethdev: add the API for getting burst mode information
>
> On 09/26, Haiyue Wang wrote:
> >Some PMDs have more than one RX/TX burst paths, add the ethdev API
> >that allows an application to retrieve the mode information about
> >Rx/Tx packet burst such as Scalar or Vector, and Vector technology
> >like AVX2.
> >
> >Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> >Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
> >---
> > doc/guides/rel_notes/release_19_11.rst | 9 +++
> > lib/librte_ethdev/rte_ethdev.c | 75 ++++++++++++++++++++++
> > lib/librte_ethdev/rte_ethdev.h | 82 ++++++++++++++++++++++++
> > lib/librte_ethdev/rte_ethdev_core.h | 5 ++
> > lib/librte_ethdev/rte_ethdev_version.map | 5 ++
> > 5 files changed, 176 insertions(+)
> >
>
> [snip]
>
> >+typedef void (*eth_burst_mode_get_t)(struct rte_eth_dev *dev,
> >+ uint16_t queue_id, struct rte_eth_burst_mode *mode);
> >+
>
> There is ongoing effort to change the return type of dev_ops callback from
> void to int, like [1]
>
> Better to keep align with it.
>
> [1] http://patchwork.dpdk.org/project/dpdk/list/?series=6391
>
OK, will update on v2.
> Thanks,
> Xiaolong
>
> > typedef int (*mtu_set_t)(struct rte_eth_dev *dev, uint16_t mtu);
> > /**< @internal Set MTU. */
> >
> >@@ -542,6 +545,8 @@ struct eth_dev_ops {
> > eth_dev_infos_get_t dev_infos_get; /**< Get device info. */
> > eth_rxq_info_get_t rxq_info_get; /**< retrieve RX queue information. */
> > eth_txq_info_get_t txq_info_get; /**< retrieve TX queue information. */
> >+ eth_burst_mode_get_t rx_burst_mode_get; /**< Get RX burst mode */
> >+ eth_burst_mode_get_t tx_burst_mode_get; /**< Get TX burst mode */
> > eth_fw_version_get_t fw_version_get; /**< Get firmware version. */
> > eth_dev_supported_ptypes_get_t dev_supported_ptypes_get;
> > /**< Get packet types supported and identified by device. */
> >diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map
> >index 6df42a47b..e59d51648 100644
> >--- a/lib/librte_ethdev/rte_ethdev_version.map
> >+++ b/lib/librte_ethdev/rte_ethdev_version.map
> >@@ -283,4 +283,9 @@ EXPERIMENTAL {
> >
> > # added in 19.08
> > rte_eth_read_clock;
> >+
> >+ # added in 19.11
> >+ rte_eth_rx_burst_mode_get;
> >+ rte_eth_tx_burst_mode_get;
> >+ rte_eth_burst_mode_option_name;
> > };
> >--
> >2.17.1
> >
next prev parent reply other threads:[~2019-09-26 13:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 11:48 [dpdk-dev] [PATCH v1 0/4] get Rx/Tx packet " Haiyue Wang
2019-09-26 11:48 ` [dpdk-dev] [PATCH v1 1/4] ethdev: add the API for getting " Haiyue Wang
2019-09-26 13:41 ` Ye Xiaolong
2019-09-26 13:48 ` Wang, Haiyue [this message]
2019-09-26 11:48 ` [dpdk-dev] [PATCH v1 2/4] net/i40e: support to get the Rx/Tx burst mode Haiyue Wang
2019-09-26 13:49 ` Ye Xiaolong
2019-09-26 14:18 ` Wang, Haiyue
2019-09-26 11:48 ` [dpdk-dev] [PATCH v1 3/4] net/ice: " Haiyue Wang
2019-09-26 11:48 ` [dpdk-dev] [PATCH v1 4/4] app/testpmd: show the Rx/Tx burst mode description Haiyue Wang
2019-09-26 13:57 ` Ye Xiaolong
2019-09-26 15:57 ` [dpdk-dev] [PATCH v1 0/4] get Rx/Tx packet burst mode information Stephen Hemminger
2019-09-26 16:36 ` Wang, Haiyue
2019-09-26 17:15 ` Stephen Hemminger
2019-09-26 17:36 ` Ferruh Yigit
2019-09-27 1:17 ` Wang, Haiyue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E3B9F2FDCB65864C82CD632F23D8AB8773D6E267@shsmsx102.ccr.corp.intel.com \
--to=haiyue.wang@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=chenmin.sun@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=ray.kinsella@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).