From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: added new `rte_lcore_is_service_lcore` API.
Date: Mon, 28 Aug 2017 10:59:51 +0000 [thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA640C6C15D@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <1503501027-11046-1-git-send-email-pbhagavatula@caviumnetworks.com>
> From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com]
> Sent: Wednesday, August 23, 2017 4:10 PM
> To: dev@dpdk.org
> Cc: Van Haaren, Harry <harry.van.haaren@intel.com>; Pavan Nikhilesh
> <pbhagavatula@caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH] eal: added new `rte_lcore_is_service_lcore` API.
>
> This API can be used to test if an lcore(EAL thread) is a service lcore.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
> lib/librte_eal/common/include/rte_lcore.h | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/lib/librte_eal/common/include/rte_lcore.h
> b/lib/librte_eal/common/include/rte_lcore.h
> index 50e0d0f..7854ea1 100644
> --- a/lib/librte_eal/common/include/rte_lcore.h
> +++ b/lib/librte_eal/common/include/rte_lcore.h
> @@ -180,6 +180,24 @@ rte_lcore_is_enabled(unsigned lcore_id)
> }
>
> /**
> + * Test if an lcore is service lcore.
> + *
> + * @param lcore_id
> + * The identifier of the lcore, which MUST be between 0 and
> + * RTE_MAX_LCORE-1.
> + * @return
> + * True if the given lcore is service; false otherwise.
> + */
> +static inline int
> +rte_lcore_is_service_lcore(unsigned lcore_id)
> +{
> + struct rte_config *cfg = rte_eal_get_configuration();
> + if (lcore_id >= RTE_MAX_LCORE)
> + return 0;
> + return cfg->lcore_role[lcore_id] == ROLE_SERVICE;
> +}
No header file and Static inline - so this is only to be used internally in the service cores library?
If so, the function should actually be used, instead of only added but not used in the library itself.
Or am I mis-understanding the intent?
-Harry
next prev parent reply other threads:[~2017-08-28 10:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 15:10 Pavan Nikhilesh
2017-08-28 10:59 ` Van Haaren, Harry [this message]
2017-08-28 11:33 ` Pavan Nikhilesh Bhagavatula
2017-08-28 13:49 ` Van Haaren, Harry
2017-08-28 15:09 ` Pavan Nikhilesh Bhagavatula
2017-08-28 15:24 ` Van Haaren, Harry
2017-08-28 15:43 ` Pavan Nikhilesh Bhagavatula
2017-08-29 13:17 ` Van Haaren, Harry
2017-08-29 13:44 ` Pavan Nikhilesh Bhagavatula
2017-09-15 13:52 ` Thomas Monjalon
2017-09-15 13:57 ` Van Haaren, Harry
2017-09-15 14:41 ` Pavan Nikhilesh Bhagavatula
2017-09-15 14:44 ` Van Haaren, Harry
2017-09-15 14:59 ` Pavan Nikhilesh Bhagavatula
2017-09-15 15:51 ` Thomas Monjalon
2017-09-15 17:37 ` Pavan Nikhilesh Bhagavatula
2017-09-20 14:53 ` Van Haaren, Harry
2017-09-20 15:53 ` Thomas Monjalon
2017-09-20 17:31 ` Pavan Nikhilesh Bhagavatula
2017-09-21 8:58 ` [dpdk-dev] [PATCH v2] eal: add function to check lcore role Pavan Nikhilesh
2017-09-21 9:41 ` Van Haaren, Harry
2017-09-21 10:03 ` Pavan Nikhilesh Bhagavatula
2017-09-21 10:59 ` [dpdk-dev] [PATCH v3] " Pavan Nikhilesh
2017-10-11 20:14 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E923DB57A917B54B9182A2E928D00FA640C6C15D@IRSMSX102.ger.corp.intel.com \
--to=harry.van.haaren@intel.com \
--cc=dev@dpdk.org \
--cc=pbhagavatula@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).