From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: "Varghese, Vipin" <vipin.varghese@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] event/sw: code refractor for sw_refill_pp_buf
Date: Tue, 3 Apr 2018 12:50:24 +0000 [thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA65E01BF37@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <1519932900-10571-2-git-send-email-vipin.varghese@intel.com>
> -----Original Message-----
> From: Varghese, Vipin
> Sent: Thursday, March 1, 2018 7:35 PM
> To: dev@dpdk.org; Van Haaren, Harry <harry.van.haaren@intel.com>
> Cc: Varghese, Vipin <vipin.varghese@intel.com>
> Subject: [PATCH 2/2] event/sw: code refractor for sw_refill_pp_buf
>
> Code changes how shadow buffer are filled up in each calls.
> Refilling the shadow buffer helped in improving 0.2 Mpps.
>
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> ---
> drivers/event/sw/sw_evdev_scheduler.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/event/sw/sw_evdev_scheduler.c
> b/drivers/event/sw/sw_evdev_scheduler.c
> index 70d1970..a95a22a 100644
> --- a/drivers/event/sw/sw_evdev_scheduler.c
> +++ b/drivers/event/sw/sw_evdev_scheduler.c
> @@ -451,6 +451,10 @@ __pull_port_lb(struct sw_evdev *sw, uint32_t port_id, int
> allow_reorder)
> port->pp_buf_count--;
> } /* while (avail_qes) */
>
> + /* replensih buffers before next iteration */
> + if (port->pp_buf_count == 0)
> + sw_refill_pp_buf(sw, port);
> +
> return pkts_iter;
> }
I see the goal here - to ensure that the port buffer has items when we next
enter this function, possibly reducing a stall waiting for the ring access.
In theory this is a good idea - in practice, I see a small performance degradation.
Hence, I suggest we drop this patch from the patchset, and merge 1/2 alone.
next prev parent reply other threads:[~2018-04-03 12:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 19:34 [dpdk-dev] [PATCH 1/2] event/sw: code refractor to reduce the fetch stall Vipin Varghese
2018-03-01 19:35 ` [dpdk-dev] [PATCH 2/2] event/sw: code refractor for sw_refill_pp_buf Vipin Varghese
2018-04-03 12:50 ` Van Haaren, Harry [this message]
2018-04-04 11:51 ` Varghese, Vipin
2018-04-04 12:26 ` Van Haaren, Harry
2018-04-02 8:06 ` [dpdk-dev] [PATCH 1/2] event/sw: code refractor to reduce the fetch stall Jerin Jacob
2018-04-03 12:47 ` Van Haaren, Harry
2018-04-05 11:24 ` [dpdk-dev] [PATCH v2] " Vipin Varghese
2018-04-05 5:56 ` [dpdk-dev] [PATCH v3] " Vipin Varghese
2018-04-05 8:53 ` Jerin Jacob
2018-04-13 16:19 ` Van Haaren, Harry
2018-04-14 5:28 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E923DB57A917B54B9182A2E928D00FA65E01BF37@IRSMSX101.ger.corp.intel.com \
--to=harry.van.haaren@intel.com \
--cc=dev@dpdk.org \
--cc=vipin.varghese@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).