From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Liu, Yuanhan" <yuanhan.liu@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/virtio-user: fix missing driver name
Date: Thu, 19 Jan 2017 01:16:58 +0000 [thread overview]
Message-ID: <ED26CBA2FAD1BF48A8719AEF02201E3651118DC0@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <df0317c1-d094-68e6-8351-1675502b3266@intel.com>
Hi Ferruh,
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, January 18, 2017 11:55 PM
> To: Tan, Jianfeng; dev@dpdk.org
> Cc: Liu, Yuanhan; stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH] net/virtio-user: fix missing driver name
>
> On 1/18/2017 1:49 PM, Tan, Jianfeng wrote:
> > Hi Ferruh,
> >
> >> -----Original Message-----
> >> From: Yigit, Ferruh
> >> Sent: Wednesday, January 18, 2017 7:53 PM
> >> To: Tan, Jianfeng; dev@dpdk.org
> >> Cc: Liu, Yuanhan; stable@dpdk.org
> >> Subject: Re: [dpdk-stable] [PATCH] net/virtio-user: fix missing driver
> name
> >>
> >> On 1/18/2017 11:44 AM, Jianfeng Tan wrote:
> >>> API rte_eth_dev_info_get() fills driver name according to drv_name
> >>> of rte_eth_dev_data. But we have not fill such info in virtio_user.
> >>>
> >>> We do not use the same one with virtio device as some applications
> >>> might depend on driver name to differetiate kinds of devices, such
> >>> as VPP.
> >>>
> >>> Fixes: e9efa4d93821 ("net/virtio-user: add new virtual PCI driver")
> >>> CC: stable@dpdk.org
> >>>
> >>> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> >>> ---
> >>> drivers/net/virtio/virtio_user_ethdev.c | 1 +
> >>> 1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/drivers/net/virtio/virtio_user_ethdev.c
> >> b/drivers/net/virtio/virtio_user_ethdev.c
> >>> index c877968..110f6a9 100644
> >>> --- a/drivers/net/virtio/virtio_user_ethdev.c
> >>> +++ b/drivers/net/virtio/virtio_user_ethdev.c
> >>> @@ -312,6 +312,7 @@ virtio_user_eth_dev_alloc(const char *name)
> >>> hw->use_simple_rxtx = 0;
> >>> hw->virtio_user_dev = dev;
> >>> data->dev_private = hw;
> >>> + data->drv_name = "virtio_user PMD";
> >>
> >> How driver naming done changed in next-net.
> >> Please check any other virtual driver in next-net for sample.
> >
> > Thank you for the info. And it seems that it's already fixed by that patch.
>
> That patch modified during merge, can you please confirm the latest
> version in the repo?
Just checked latest master repo, this problem has been fixed by commit 73db5badb04 ("net: align ethdev and eal driver names"). Thanks to David Marchand.
Yuanhan, do you think this patch can be applied to the stable repo?
Thanks,
Jianfeng
next prev parent reply other threads:[~2017-01-19 1:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 11:44 Jianfeng Tan
2017-01-18 11:52 ` Ferruh Yigit
2017-01-18 13:49 ` Tan, Jianfeng
2017-01-18 15:54 ` Ferruh Yigit
2017-01-19 1:16 ` Tan, Jianfeng [this message]
2017-01-19 8:16 ` Yuanhan Liu
2017-01-19 8:23 ` Tan, Jianfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED26CBA2FAD1BF48A8719AEF02201E3651118DC0@SHSMSX103.ccr.corp.intel.com \
--to=jianfeng.tan@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
--cc=yuanhan.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).