From: "Zhang, Helin" <helin.zhang@intel.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/6] ethdev: add an field for querying hash key size
Date: Fri, 5 Jun 2015 06:21:52 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A871225@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20150604130510.GB24585@hmsreliant.think-freely.org>
Hi Neil
Yes, thank you very much for the comments!
I realized the ABI issue after I sent out the patch. I think even I put the new one the end of this structure, it may also have issue.
I'd like to have this change announced and then get it merged. That means I'd like to make this change and follow the policy and process.
Regards,
Helin
> -----Original Message-----
> From: Neil Horman [mailto:nhorman@tuxdriver.com]
> Sent: Thursday, June 4, 2015 9:05 PM
> To: Zhang, Helin
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 1/6] ethdev: add an field for querying hash key
> size
>
> On Thu, Jun 04, 2015 at 09:00:33AM +0800, Helin Zhang wrote:
> > To support querying hash key size per port, an new field of
> > 'hash_key_size' was added in 'struct rte_eth_dev_info' for storing
> > hash key size in bytes.
> >
> > Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> > ---
> > lib/librte_ether/rte_ethdev.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/lib/librte_ether/rte_ethdev.h
> > b/lib/librte_ether/rte_ethdev.h index 16dbe00..004b05a 100644
> > --- a/lib/librte_ether/rte_ethdev.h
> > +++ b/lib/librte_ether/rte_ethdev.h
> > @@ -916,6 +916,7 @@ struct rte_eth_dev_info {
> > uint16_t max_vmdq_pools; /**< Maximum number of VMDq pools. */
> > uint32_t rx_offload_capa; /**< Device RX offload capabilities. */
> > uint32_t tx_offload_capa; /**< Device TX offload capabilities. */
> > + uint8_t hash_key_size; /**< Hash key size in bytes */
> > uint16_t reta_size;
> > /**< Device redirection table size, the total number of entries. */
> > /** Bit mask of RSS offloads, the bit offset also means flow type */
> > --
> > 1.9.3
> >
> >
>
> You'll need to at least move this to the end of the structure to avoid ABI breakage,
> but even then, since the examples statically allocate this struct on the stack, you
> need to worry about previously compiled applications not having enough space
> allocated. Is there a hole in the struct that this can fit into to avoid changing the
> other member offsets?
> Neil
next prev parent reply other threads:[~2015-06-05 6:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 1:00 [dpdk-dev] [PATCH 0/6] query hash key size in byte Helin Zhang
2015-06-04 1:00 ` [dpdk-dev] [PATCH 1/6] ethdev: add an field for querying hash key size Helin Zhang
2015-06-04 13:05 ` Neil Horman
2015-06-05 6:21 ` Zhang, Helin [this message]
2015-06-05 10:30 ` Neil Horman
2015-06-04 1:00 ` [dpdk-dev] [PATCH 2/6] e1000: fill the " Helin Zhang
2015-06-04 1:00 ` [dpdk-dev] [PATCH 3/6] fm10k: " Helin Zhang
2015-06-04 1:00 ` [dpdk-dev] [PATCH 4/6] i40e: " Helin Zhang
2015-06-04 1:00 ` [dpdk-dev] [PATCH 5/6] ixgbe: " Helin Zhang
2015-06-04 1:00 ` [dpdk-dev] [PATCH 6/6] app/testpmd: show " Helin Zhang
2015-06-04 7:33 ` [dpdk-dev] [PATCH v2 0/6] query hash key size in byte Helin Zhang
2015-06-04 7:33 ` [dpdk-dev] [PATCH v2 1/6] ethdev: add an field for querying hash key size Helin Zhang
2015-06-04 10:38 ` Ananyev, Konstantin
2015-06-12 6:06 ` Zhang, Helin
2015-06-04 7:33 ` [dpdk-dev] [PATCH v2 2/6] e1000: fill the " Helin Zhang
2015-06-04 7:33 ` [dpdk-dev] [PATCH v2 3/6] fm10k: " Helin Zhang
2015-06-04 7:33 ` [dpdk-dev] [PATCH v2 4/6] i40e: " Helin Zhang
2015-06-04 7:33 ` [dpdk-dev] [PATCH v2 5/6] ixgbe: " Helin Zhang
2015-06-04 7:33 ` [dpdk-dev] [PATCH v2 6/6] app/testpmd: show " Helin Zhang
2015-06-12 7:33 ` [dpdk-dev] [PATCH v3 0/6] query hash key size in byte Helin Zhang
2015-06-12 7:33 ` [dpdk-dev] [PATCH v3 1/6] ethdev: add an field for querying hash key size Helin Zhang
2015-06-15 15:01 ` Thomas Monjalon
2015-06-12 7:33 ` [dpdk-dev] [PATCH v3 2/6] e1000: fill the " Helin Zhang
2015-06-12 7:33 ` [dpdk-dev] [PATCH v3 3/6] fm10k: " Helin Zhang
2015-06-12 7:33 ` [dpdk-dev] [PATCH v3 4/6] i40e: " Helin Zhang
2015-06-12 7:34 ` [dpdk-dev] [PATCH v3 5/6] ixgbe: " Helin Zhang
2015-06-12 7:34 ` [dpdk-dev] [PATCH v3 6/6] app/testpmd: show " Helin Zhang
2015-06-12 9:31 ` [dpdk-dev] [PATCH v3 0/6] query hash key size in byte Ananyev, Konstantin
2015-07-08 23:17 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E70A871225@SHSMSX104.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).