From: "Zhang, Helin" <helin.zhang@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v6 1/3] i40e: RSS/FD granularity configuration
Date: Fri, 30 Oct 2015 01:58:42 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A92148E@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20151029093831.GA6160@bricha3-MOBL3>
> -----Original Message-----
> From: Richardson, Bruce
> Sent: Thursday, October 29, 2015 5:39 PM
> To: Zhang, Helin
> Cc: dev@dpdk.org; Pei, Yulong
> Subject: Re: [dpdk-dev] [PATCH v6 1/3] i40e: RSS/FD granularity configuration
>
> On Thu, Oct 29, 2015 at 02:02:50PM +0800, Helin Zhang wrote:
> > The default input set of fields of a received packet are loaded from
> > firmware, which cannot be modified even users want to use different
> > fields for RSS or flow director. Here adds more flexibilities of
> > selecting packet fields for hash calculation or flow director for
> > users.
> >
> > Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> > Signed-off-by: Andrey Chilikin <andrey.chilikin@intel.com>
> > ---
> > drivers/net/i40e/i40e_ethdev.c | 742
> ++++++++++++++++++++++++++++++++++++++++
> > drivers/net/i40e/i40e_ethdev.h | 7 +
> > drivers/net/i40e/i40e_fdir.c | 31 ++
> > lib/librte_ether/rte_eth_ctrl.h | 114 +++++-
> > 4 files changed, 890 insertions(+), 4 deletions(-)
> >
> <snip>
> > @@ -672,6 +776,8 @@ struct rte_eth_hash_filter_info {
> > uint8_t enable;
> > /** Global configurations of hash filter */
> > struct rte_eth_hash_global_conf global_conf;
> > + /** Global configurations of hash filter input set */
> > + struct rte_eth_input_set_conf input_set_conf;
> > } info;
> > };
> >
> Hi Helin,
>
> Just to check: Does this change affect the size of the structure and cause ABI
> issues?
Bruce, you are right, there should be ABI issue with the structure size. Thank you very much!
I will change the size of ' struct rte_eth_input_set_conf ' to smaller one, and then no ABI issue this time.
But I will announce ABI change to support configuring more than one input sets, and then make the change next time.
/Helin
>
> /Bruce
next prev parent reply other threads:[~2015-10-30 1:58 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 6:32 [dpdk-dev] [PATCH 0/2] i40e: RSS " Helin Zhang
2015-09-22 6:32 ` [dpdk-dev] [PATCH 1/2] i40e: add " Helin Zhang
2015-09-22 6:32 ` [dpdk-dev] [PATCH 2/2] app/testpmd: add test commands for RSS granularity Helin Zhang
2015-09-22 7:26 ` [dpdk-dev] [PATCH v2 0/2] i40e: RSS granularity configuration Helin Zhang
2015-09-22 7:26 ` [dpdk-dev] [PATCH v2 1/2] i40e: add " Helin Zhang
2015-09-22 7:26 ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: add test commands for RSS granularity Helin Zhang
2015-09-24 7:08 ` [dpdk-dev] [PATCH v3 0/2] i40e: RSS granularity configuration Helin Zhang
2015-09-24 7:08 ` [dpdk-dev] [PATCH v3 1/2] i40e: add " Helin Zhang
2015-09-24 7:08 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: add test commands for RSS granularity Helin Zhang
2015-10-20 3:42 ` [dpdk-dev] [PATCH v4 0/2] i40e: RSS/FD granularity configuration Helin Zhang
2015-10-20 3:42 ` [dpdk-dev] [PATCH v4 1/2] " Helin Zhang
2015-10-20 3:42 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: add test commands for RSS/FD granularity Helin Zhang
2015-10-29 4:09 ` [dpdk-dev] [PATCH v5 0/2] i40e: RSS/FD granularity configuration Helin Zhang
2015-10-29 4:09 ` [dpdk-dev] [PATCH v5 1/2] " Helin Zhang
2015-10-29 4:09 ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: add test commands for RSS/FD granularity Helin Zhang
2015-10-29 6:02 ` [dpdk-dev] [PATCH v6 0/3] i40e: RSS/FD granularity configuration Helin Zhang
2015-10-29 6:02 ` [dpdk-dev] [PATCH v6 1/3] " Helin Zhang
2015-10-29 9:38 ` Bruce Richardson
2015-10-30 1:58 ` Zhang, Helin [this message]
2015-10-29 6:02 ` [dpdk-dev] [PATCH v6 2/3] app/testpmd: add test commands for RSS/FD granularity Helin Zhang
2015-10-29 6:02 ` [dpdk-dev] [PATCH v6 3/3] doc: update release notes and testpmd guide Helin Zhang
2015-10-30 3:11 ` [dpdk-dev] [PATCH v7 0/2] i40e: RSS/FD granularity configuration Helin Zhang
2015-10-30 3:11 ` [dpdk-dev] [PATCH v7 1/2] " Helin Zhang
2015-10-30 13:46 ` Thomas Monjalon
2015-11-02 2:11 ` Zhang, Helin
2015-11-02 7:27 ` Thomas Monjalon
2015-11-02 7:59 ` Zhang, Helin
2015-11-02 8:23 ` Thomas Monjalon
2015-10-30 3:11 ` [dpdk-dev] [PATCH v7 2/2] app/testpmd: add test commands for RSS/FD granularity Helin Zhang
2015-10-30 7:59 ` [dpdk-dev] [PATCH v7 0/2] i40e: RSS/FD granularity configuration Wu, Jingjing
2015-11-02 14:32 ` [dpdk-dev] [PATCH v8 " Helin Zhang
2015-11-02 14:32 ` [dpdk-dev] [PATCH v8 1/2] " Helin Zhang
2015-11-02 14:32 ` [dpdk-dev] [PATCH v8 2/2] app/testpmd: add test commands for RSS/FD granularity Helin Zhang
2015-11-03 16:07 ` [dpdk-dev] [PATCH v9 0/2] i40e: RSS/FD granularity configuration Helin Zhang
2015-11-03 16:07 ` [dpdk-dev] [PATCH v9 1/2] " Helin Zhang
2015-11-03 16:07 ` [dpdk-dev] [PATCH v9 2/2] app/testpmd: add test commands for RSS/FD granularity Helin Zhang
2015-11-03 23:25 ` [dpdk-dev] [PATCH v9 0/2] i40e: RSS/FD granularity configuration Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E70A92148E@SHSMSX104.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).