From: "Zhang, Helin" <helin.zhang@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v7 1/2] i40e: RSS/FD granularity configuration
Date: Mon, 2 Nov 2015 07:59:26 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A923FFD@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <3367355.V0LI0AXumx@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, November 2, 2015 3:28 PM
> To: Zhang, Helin
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v7 1/2] i40e: RSS/FD granularity configuration
>
> 2015-11-02 02:11, Zhang, Helin:
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > 2015-10-30 11:11, Helin Zhang:
> > > > v7 changes:
> > > > Modified RTE_ETH_INSET_SIZE_MAX from 128 to 1, to avoid ABI changes.
> > >
> > > Why it would avoid ABI changes?
> > > Have you passed the ABI checker?
> >
> > Hi Thomas
> >
> > The only structure modified is ' struct rte_eth_hash_filter_info ',
> > where a new element (struct rte_eth_input_set_conf input_set_conf) was
> > added. But I kept its structure the same size as another one (struct
> > rte_eth_hash_global_conf global_conf) already in that union, they are
> > both in 12 bytes. That means nothing changed for ' struct
> rte_eth_hash_filter_info'.
>
> First, it should be justified in the commit message.
> Second, I think it's wrong:
> The union has struct rte_eth_hash_global_conf = enum + uint32_t + uint32_t You
> are adding struct rte_eth_input_set_conf = uint16_t + uint16_t + enum + enum
> I'm not sure we can assume the sizes are the same.
Oh, yes, the size might not be the same on all platforms.
>
> The ethdev ABI is already broken in this release. So maybe we can agree that it's
> not a big deal but it should be notified in the release notes and, in this case, you
> could keep your original patch with 128 enums.
That's bad, but good for me. Can I just enable v6 as 'new', and disable 'v7'?
Or I need a new version?
Thank you very much!
Helin
next prev parent reply other threads:[~2015-11-02 7:59 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 6:32 [dpdk-dev] [PATCH 0/2] i40e: RSS " Helin Zhang
2015-09-22 6:32 ` [dpdk-dev] [PATCH 1/2] i40e: add " Helin Zhang
2015-09-22 6:32 ` [dpdk-dev] [PATCH 2/2] app/testpmd: add test commands for RSS granularity Helin Zhang
2015-09-22 7:26 ` [dpdk-dev] [PATCH v2 0/2] i40e: RSS granularity configuration Helin Zhang
2015-09-22 7:26 ` [dpdk-dev] [PATCH v2 1/2] i40e: add " Helin Zhang
2015-09-22 7:26 ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: add test commands for RSS granularity Helin Zhang
2015-09-24 7:08 ` [dpdk-dev] [PATCH v3 0/2] i40e: RSS granularity configuration Helin Zhang
2015-09-24 7:08 ` [dpdk-dev] [PATCH v3 1/2] i40e: add " Helin Zhang
2015-09-24 7:08 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: add test commands for RSS granularity Helin Zhang
2015-10-20 3:42 ` [dpdk-dev] [PATCH v4 0/2] i40e: RSS/FD granularity configuration Helin Zhang
2015-10-20 3:42 ` [dpdk-dev] [PATCH v4 1/2] " Helin Zhang
2015-10-20 3:42 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: add test commands for RSS/FD granularity Helin Zhang
2015-10-29 4:09 ` [dpdk-dev] [PATCH v5 0/2] i40e: RSS/FD granularity configuration Helin Zhang
2015-10-29 4:09 ` [dpdk-dev] [PATCH v5 1/2] " Helin Zhang
2015-10-29 4:09 ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: add test commands for RSS/FD granularity Helin Zhang
2015-10-29 6:02 ` [dpdk-dev] [PATCH v6 0/3] i40e: RSS/FD granularity configuration Helin Zhang
2015-10-29 6:02 ` [dpdk-dev] [PATCH v6 1/3] " Helin Zhang
2015-10-29 9:38 ` Bruce Richardson
2015-10-30 1:58 ` Zhang, Helin
2015-10-29 6:02 ` [dpdk-dev] [PATCH v6 2/3] app/testpmd: add test commands for RSS/FD granularity Helin Zhang
2015-10-29 6:02 ` [dpdk-dev] [PATCH v6 3/3] doc: update release notes and testpmd guide Helin Zhang
2015-10-30 3:11 ` [dpdk-dev] [PATCH v7 0/2] i40e: RSS/FD granularity configuration Helin Zhang
2015-10-30 3:11 ` [dpdk-dev] [PATCH v7 1/2] " Helin Zhang
2015-10-30 13:46 ` Thomas Monjalon
2015-11-02 2:11 ` Zhang, Helin
2015-11-02 7:27 ` Thomas Monjalon
2015-11-02 7:59 ` Zhang, Helin [this message]
2015-11-02 8:23 ` Thomas Monjalon
2015-10-30 3:11 ` [dpdk-dev] [PATCH v7 2/2] app/testpmd: add test commands for RSS/FD granularity Helin Zhang
2015-10-30 7:59 ` [dpdk-dev] [PATCH v7 0/2] i40e: RSS/FD granularity configuration Wu, Jingjing
2015-11-02 14:32 ` [dpdk-dev] [PATCH v8 " Helin Zhang
2015-11-02 14:32 ` [dpdk-dev] [PATCH v8 1/2] " Helin Zhang
2015-11-02 14:32 ` [dpdk-dev] [PATCH v8 2/2] app/testpmd: add test commands for RSS/FD granularity Helin Zhang
2015-11-03 16:07 ` [dpdk-dev] [PATCH v9 0/2] i40e: RSS/FD granularity configuration Helin Zhang
2015-11-03 16:07 ` [dpdk-dev] [PATCH v9 1/2] " Helin Zhang
2015-11-03 16:07 ` [dpdk-dev] [PATCH v9 2/2] app/testpmd: add test commands for RSS/FD granularity Helin Zhang
2015-11-03 23:25 ` [dpdk-dev] [PATCH v9 0/2] i40e: RSS/FD granularity configuration Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E70A923FFD@SHSMSX104.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).