From: Yongseok Koh <yskoh@mellanox.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: Herakliusz Lipiec <herakliusz.lipiec@intel.com>,
"shafafs@mellanox.com" <shafafs@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 8/8] ipc: fix net/mlx5 memleak
Date: Tue, 23 Apr 2019 20:13:45 +0000 [thread overview]
Message-ID: <F7810CC0-CDE9-42C3-8D76-F07CF8195B90@mellanox.com> (raw)
In-Reply-To: <e2ef8184-4cf6-b930-aaf5-a5351b51c6a4@intel.com>
> On Apr 23, 2019, at 1:09 AM, Burakov, Anatoly <anatoly.burakov@intel.com> wrote:
>
> On 22-Apr-19 6:51 PM, Yongseok Koh wrote:
>>> On Apr 17, 2019, at 7:44 AM, Herakliusz Lipiec <herakliusz.lipiec@intel.com> wrote:
>>>
>>> When sending multiple requests, rte_mp_request_sync
>>> can succeed sending a few of those requests, but then
>>> fail on a later one and in the end return with rc=-1.
>>> The upper layers - e.g. device hotplug - currently
>>> handles this case as if no messages were sent and no
>>> memory for response buffers was allocated, which is
>>> not true. Fixed by always freeing reply message buffers.
>>>
>>> Fixes: 9a8ab29b84d3 ("net/mlx5: replace IPC socket with EAL API")
>>> Fixes: c18cf501a7af ("net/mlx5: enable secondary process to register DMA memory")
>>> Cc: yskoh@mellanox.com
>>> Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
>>> ---
>>> drivers/net/mlx5/mlx5_mp.c | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/mlx5/mlx5_mp.c b/drivers/net/mlx5/mlx5_mp.c
>>> index cea74adb6..c9915b1d5 100644
>>> --- a/drivers/net/mlx5/mlx5_mp.c
>>> +++ b/drivers/net/mlx5/mlx5_mp.c
>>> @@ -258,6 +258,7 @@ mlx5_mp_req_mr_create(struct rte_eth_dev *dev, uintptr_t addr)
>>> if (ret) {
>>> DRV_LOG(ERR, "port %u request to primary process failed",
>>> dev->data->port_id);
>>> + free(mp_rep.msgs);
>>> return -rte_errno;
>>> }
>>> assert(mp_rep.nb_received == 1);
>>> @@ -295,7 +296,8 @@ mlx5_mp_req_verbs_cmd_fd(struct rte_eth_dev *dev)
>>> if (ret) {
>>> DRV_LOG(ERR, "port %u request to primary process failed",
>>> dev->data->port_id);
>>> - return -rte_errno;
>>> + ret = -rte_errno;
>>> + goto exit;
>> These two requests will be made by a secondary process targeting to the primary.
>> Then, there's only one request in this case and we don't need to take care of that.
>> Right?
>> Same comment for mlx4.
>
> Hi Yongseok,
>
> mp_rep.msgs is potentially allocated regardless of whether you're in primary or secondary, and whether the call to mp_request_sync succeeded or failed. Hence, need to free in all cases.
Then, it looks fine to me.
>
> See this patch: https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatches.dpdk.org%2Fpatch%2F52868%2F&data=02%7C01%7Cyskoh%40mellanox.com%7C007b61ef9d964dc79e7108d6c7c2f9d8%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636916037564345993&sdata=O%2BoG%2F8P8cXwKS%2FDfZyMiG3CiIDpeXe3dPMJgVilzFWY%3D&reserved=0
> and this bug: https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.dpdk.org%2Fshow_bug.cgi%3Fid%3D228&data=02%7C01%7Cyskoh%40mellanox.com%7C007b61ef9d964dc79e7108d6c7c2f9d8%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636916037564345993&sdata=jLA5wLqT%2BfW3p79rg2SVEZ16GS37dgqdF4NwmiRU%2B7A%3D&reserved=0
>
>> Thanks,
>> Yongseok
>>> }
>>> assert(mp_rep.nb_received == 1);
>>> mp_res = &mp_rep.msgs[0];
>>> --
>>> 2.17.2
>>>
>
>
> --
> Thanks,
> Anatoly
next prev parent reply other threads:[~2019-04-23 20:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 14:44 Herakliusz Lipiec
2019-04-17 14:44 ` Herakliusz Lipiec
2019-04-22 17:51 ` Yongseok Koh
2019-04-22 17:51 ` Yongseok Koh
2019-04-23 8:09 ` Burakov, Anatoly
2019-04-23 8:09 ` Burakov, Anatoly
2019-04-23 20:13 ` Yongseok Koh [this message]
2019-04-23 20:13 ` Yongseok Koh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F7810CC0-CDE9-42C3-8D76-F07CF8195B90@mellanox.com \
--to=yskoh@mellanox.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=herakliusz.lipiec@intel.com \
--cc=shafafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).