From: Gregory Etelson <getelson@nvidia.com>
To: Ori Kam <orika@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Maayan Kashani <mkashani@nvidia.com>,
Raslan Darawsheh <rasland@nvidia.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Ferruh Yigit <ferruh.yigit@amd.com>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: RE: [PATCH v4] ethdev: add indirect list flow action
Date: Thu, 25 May 2023 08:14:16 +0000 [thread overview]
Message-ID: <IA1PR12MB633262B93090C7C4D5E05E14A5469@IA1PR12MB6332.namprd12.prod.outlook.com> (raw)
In-Reply-To: <MW2PR12MB4666460B20996D7A8620CD27D6419@MW2PR12MB4666.namprd12.prod.outlook.com>
Hello Ori,
[snip]
> > +/**
> > + * @warning
> > + * @b EXPERIMENTAL: this API may change without prior notice.
> > + *
> > + * Query and/or update indirect flow actions list.
> > + * If both query and update not NULL, the function atomically
> > + * queries and updates indirect action. Query and update are carried in
> > order
> > + * specified in the mode parameter.
> > + * If ether query or update is NULL, the function executes
> > + * complementing operation.
> > + *
> > + * @param port_id
> > + * Port identifier of Ethernet device.
> > + * @param handle
> > + * Handle for the indirect actions list object to be updated.
> > + * @param update
> > + * If not NULL, update profile specification used to modify the action
>
> It should be explained that the upate/query points always to array with the size
> of number of actions, the the query/update query/upate all the actions at the
> same time
>
I added update and query parameters description in v5
> This comment is for all such parameters in async and synced functions.
>
> > + * pointed by handle.
> > + * @see struct rte_flow_action_indirect_list
> > + * @param query
> > + * If not NULL pointer to storage for the associated query data type.
> > + * @see struct rte_flow_action_indirect_list
> > + * @param mode
> > + * Operational mode.
> > + * @param error
> > + * Perform verbose error reporting if not NULL.
> > + * PMDs initialize this structure in case of error only.
> > + *
> > + * @return
> > + * - (0) if success.
> > + * - (-ENODEV) if *port_id* invalid.
> > + * - (-ENOTSUP) if underlying device does not support this functionality.
> > + * - (-EINVAL) if *handle* or *mode* invalid or
> > + * both *query* and *update* are NULL.
> > + */
> > +__rte_experimental
> > +int
> > +rte_flow_action_list_handle_query_update(uint16_t port_id,
> > + const struct
> > + rte_flow_action_list_handle
> > *handle,
> > + const void **update, void **query,
> > + enum
> > rte_flow_query_update_mode mode,
> > + struct rte_flow_error *error);
> > +
> > +/**
> > + * @warning
> > + * @b EXPERIMENTAL: this API may change without prior notice.
> > + *
> > + * Enqueue async indirect flow actions list query and/or update
> > + *
> > + * @param port_id
> > + * Port identifier of Ethernet device.
> > + * @param queue_id
> > + * Flow queue which is used to update the rule.
> > + * @param attr
> > + * Indirect action update operation attributes.
> > + * @param handle
> > + * Handle for the indirect actions list object to be updated.
> > + * @param update
> > + * If not NULL, update profile specification used to modify the action
> > + * pointed by handle.
> > + * @see struct rte_flow_action_indirect_list
> > + * @param query
> > + * If not NULL, pointer to storage for the associated query data type.
> > + * Query result returned on async completion event.
> > + * @see struct rte_flow_action_indirect_list
> > + * @param mode
> > + * Operational mode.
> > + * @param user_data
> > + * The user data that will be returned on async completion event.
> > + * @param error
> > + * Perform verbose error reporting if not NULL.
> > + * PMDs initialize this structure in case of error only.
> > + *
> > + * @return
> > + * - (0) if success.
> > + * - (-ENODEV) if *port_id* invalid.
> > + * - (-ENOTSUP) if underlying device does not support this functionality.
> > + * - (-EINVAL) if *handle* or *mode* invalid or
> > + * both *update* and *query* are NULL.
> > + */
> > +__rte_experimental
> > +int
> > +rte_flow_async_action_list_handle_query_update(uint16_t port_id,
> > uint32_t queue_id,
> > + const struct rte_flow_op_attr *attr,
> > + const struct
> > + rte_flow_action_list_handle
> > *handle,
> > + const void **update, void **query,
> > + enum
> > rte_flow_query_update_mode mode,
> > + void *user_data,
> > + struct rte_flow_error *error);
> > +
> > +
> > #ifdef __cplusplus
> > }
> > #endif
> > diff --git a/lib/ethdev/rte_flow_driver.h b/lib/ethdev/rte_flow_driver.h
> > index a129a4605d..af63ef9b5c 100644
> > --- a/lib/ethdev/rte_flow_driver.h
> > +++ b/lib/ethdev/rte_flow_driver.h
> > @@ -121,6 +121,17 @@ struct rte_flow_ops {
> > const void *update, void *query,
> > enum rte_flow_query_update_mode qu_mode,
> > struct rte_flow_error *error);
> > + /** @see rte_flow_action_list_handle_create() */
> > + struct rte_flow_action_list_handle *(*action_list_handle_create)
> > + (struct rte_eth_dev *dev,
> > + const struct rte_flow_indir_action_conf *conf,
> > + const struct rte_flow_action actions[],
> > + struct rte_flow_error *error);
> > + /** @see rte_flow_action_list_handle_destroy() */
> > + int (*action_list_handle_destroy)
> > + (struct rte_eth_dev *dev,
> > + struct rte_flow_action_list_handle *handle,
> > + struct rte_flow_error *error);
> > /** See rte_flow_tunnel_decap_set() */
> > int (*tunnel_decap_set)
> > (struct rte_eth_dev *dev,
> > @@ -302,6 +313,36 @@ struct rte_flow_ops {
> > const void *update, void *query,
> > enum rte_flow_query_update_mode qu_mode,
> > void *user_data, struct rte_flow_error *error);
> > + /** @see rte_flow_async_action_list_handle_create() */
> > + struct rte_flow_action_list_handle *
> > + (*async_action_list_handle_create)
> > + (struct rte_eth_dev *dev, uint32_t queue_id,
> > + const struct rte_flow_op_attr *attr,
> > + const struct rte_flow_indir_action_conf *conf,
> > + const struct rte_flow_action *actions,
> > + void *user_data, struct rte_flow_error *error);
> > + /** @see rte_flow_async_action_list_handle_destroy() */
> > + int (*async_action_list_handle_destroy)
> > + (struct rte_eth_dev *dev, uint32_t queue_id,
> > + const struct rte_flow_op_attr *op_attr,
> > + struct rte_flow_action_list_handle *action_handle,
> > + void *user_data, struct rte_flow_error *error);
> > + /** @see rte_flow_action_list_handle_query_update() */
> > + int (*action_list_handle_query_update)
> > + (struct rte_eth_dev *dev,
> > + const struct rte_flow_action_list_handle *handle,
> > + const void **update, void **query,
> > + enum rte_flow_query_update_mode mode,
> > + struct rte_flow_error *error);
> > + /** @see rte_flow_async_action_list_handle_query_update() */
> > + int (*async_action_list_handle_query_update)
> > + (struct rte_eth_dev *dev, uint32_t queue_id,
> > + const struct rte_flow_op_attr *attr,
> > + const struct rte_flow_action_list_handle *handle,
> > + const void **update, void **query,
> > + enum rte_flow_query_update_mode mode,
> > + void *user_data, struct rte_flow_error *error);
> > +
> > };
> >
> > /**
> > diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map
> > index 357d1a88c0..02372b3a7e 100644
> > --- a/lib/ethdev/version.map
> > +++ b/lib/ethdev/version.map
> > @@ -299,6 +299,14 @@ EXPERIMENTAL {
> > rte_flow_action_handle_query_update;
> > rte_flow_async_action_handle_query_update;
> > rte_flow_async_create_by_index;
> > +
> > + # added in 23.07
> > + rte_flow_action_list_handle_create;
> > + rte_flow_action_list_handle_destroy;
> > + rte_flow_action_list_handle_query_update;
> > + rte_flow_async_action_list_handle_create;
> > + rte_flow_async_action_list_handle_destroy;
> > + rte_flow_async_action_list_handle_query_update;
> > };
> >
> > INTERNAL {
> > --
> > 2.34.1
next prev parent reply other threads:[~2023-05-25 8:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 17:21 [PATCH] " Gregory Etelson
2023-05-02 15:09 ` [RFC PATCH v2] " Gregory Etelson
2023-05-02 16:00 ` Ivan Malov
2023-05-03 7:05 ` Gregory Etelson
2023-05-07 9:50 ` [RFC PATCH v3] " Gregory Etelson
2023-05-17 16:57 ` Ori Kam
2023-05-18 18:18 ` Gregory Etelson
2023-05-19 11:59 ` [PATCH v4] " Gregory Etelson
2023-05-24 17:46 ` Ori Kam
2023-05-25 8:14 ` Gregory Etelson [this message]
2023-05-25 8:12 ` [PATCH v5 1/2] " Gregory Etelson
2023-05-25 8:12 ` [PATCH v5 2/2] ethdev: add indirect list METER_MARK update structures Gregory Etelson
2023-05-28 14:07 ` Ori Kam
2023-05-29 4:03 ` Gregory Etelson
2023-05-28 15:43 ` [PATCH v6] ethdev: add indirect list flow action Gregory Etelson
2023-05-29 6:14 ` Ori Kam
2023-05-31 11:24 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=IA1PR12MB633262B93090C7C4D5E05E14A5469@IA1PR12MB6332.namprd12.prod.outlook.com \
--to=getelson@nvidia.com \
--cc=aman.deep.singh@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=mkashani@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=thomas@monjalon.net \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).