From: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>
To: Akhil Goyal <gakhil@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Anoob Joseph <anoobj@marvell.com>,
"Zhang, Roy Fan" <roy.fan.zhang@intel.com>
Subject: RE: [EXT] [PATCH 13/40] test/crypto: remove asym crypto next xform
Date: Fri, 20 May 2022 07:38:59 +0000 [thread overview]
Message-ID: <PH0PR11MB5013AAB4B7B56E5744233E1D9FD39@PH0PR11MB5013.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CO6PR18MB4484E830CF4D5C1877C54C63D8D39@CO6PR18MB4484.namprd18.prod.outlook.com>
> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Friday, May 20, 2022 9:24 AM
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> Cc: Anoob Joseph <anoobj@marvell.com>; Zhang, Roy Fan
> <roy.fan.zhang@intel.com>
> Subject: RE: [EXT] [PATCH 13/40] test/crypto: remove asym crypto next xform
>
> > - removed asymnetric crypto xform next field.
> > This commit reflects changes to the asymmetric crypto API.
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > ---
> > app/test/test_cryptodev_asym.c | 100 -----------------------------
> > app/test/test_cryptodev_dh_test_vectors.h | 1 -
> > app/test/test_cryptodev_dsa_test_vectors.h | 1 -
> > app/test/test_cryptodev_mod_test_vectors.h | 2 -
> > app/test/test_cryptodev_rsa_test_vectors.h | 2 -
> > app/test/test_event_crypto_adapter.c | 4 --
> > 6 files changed, 110 deletions(-)
> >
> > diff --git a/app/test/test_cryptodev_asym.c
> > b/app/test/test_cryptodev_asym.c index 0098b6bf65..9e5d5e4f27 100644
> > --- a/app/test/test_cryptodev_asym.c
> > +++ b/app/test/test_cryptodev_asym.c
> > @@ -318,7 +318,6 @@ test_cryptodev_asym_op(struct
> > crypto_testsuite_params_asym *ts_params,
> >
> > int ret, status = TEST_SUCCESS;
> >
> > - xform_tc.next = NULL;
> > xform_tc.xform_type = data_tc->modex.xform_type;
> >
> > cap_idx.type = xform_tc.xform_type;
> > @@ -1063,7 +1062,6 @@ test_dh_gen_shared_sec(struct
> > rte_crypto_asym_xform *xfrm)
> >
> > /* Setup a xform and op to generate private key only */
> > xform.dh.type = RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE;
> > - xform.next = NULL;
> > asym_op->dh.priv_key.data = dh_test_params.priv_key.data;
> > asym_op->dh.priv_key.length = dh_test_params.priv_key.length;
> > asym_op->dh.pub_key.data = (uint8_t *)peer; @@ -1145,7 +1143,6 @@
> > test_dh_gen_priv_key(struct rte_crypto_asym_xform
> > *xfrm)
> >
> > /* Setup a xform and op to generate private key only */
> > xform.dh.type = RTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE;
> > - xform.next = NULL;
> > asym_op->dh.priv_key.data = output;
> > asym_op->dh.priv_key.length = sizeof(output);
> >
> > @@ -1228,7 +1225,6 @@ test_dh_gen_pub_key(struct
> rte_crypto_asym_xform
> > *xfrm)
> > *
> > */
> > xform.dh.type = RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE;
> > - xform.next = NULL;
> >
> > asym_op->dh.pub_key.data = output;
> > asym_op->dh.pub_key.length = sizeof(output); @@ -1288,94 +1284,6
> @@
> > test_dh_gen_pub_key(struct rte_crypto_asym_xform *xfrm) }
> >
> > static int
> > -test_dh_gen_kp(struct rte_crypto_asym_xform *xfrm)
>
>
> Why is this function removed?
This function is later added with new way of handling it, but in v2 I will squash this changes into one so it will not be removed.
>
> > -{
> > - struct crypto_testsuite_params_asym *ts_params = &testsuite_params;
> > - struct rte_mempool *op_mpool = ts_params->op_mpool;
> > - struct rte_mempool *sess_mpool = ts_params->session_mpool;
> > - uint8_t dev_id = ts_params->valid_devs[0];
> > - struct rte_crypto_asym_op *asym_op = NULL;
> > - struct rte_crypto_op *op = NULL, *result_op = NULL;
> > - void *sess = NULL;
> > - int ret, status = TEST_SUCCESS;
> > - uint8_t out_pub_key[TEST_DH_MOD_LEN];
> > - uint8_t out_prv_key[TEST_DH_MOD_LEN];
> > - struct rte_crypto_asym_xform pub_key_xform;
> > - struct rte_crypto_asym_xform xform = *xfrm;
> > -
> > - /* set up crypto op data structure */
> > - op = rte_crypto_op_alloc(op_mpool,
> > RTE_CRYPTO_OP_TYPE_ASYMMETRIC);
> > - if (!op) {
> > - RTE_LOG(ERR, USER1,
> > - "line %u FAILED: %s",
> > - __LINE__, "Failed to allocate asymmetric crypto "
> > - "operation struct");
> > - status = TEST_FAILED;
> > - goto error_exit;
> > - }
> > - asym_op = op->asym;
> > - /* Setup a xform chain to generate
> > - * private key first followed by
> > - * public key
> > - */
> > - xform.dh.type = RTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE;
> > - pub_key_xform.xform_type = RTE_CRYPTO_ASYM_XFORM_DH;
> > - pub_key_xform.dh.type =
> > RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE;
> > - xform.next = &pub_key_xform;
> > -
> > - asym_op->dh.pub_key.data = out_pub_key;
> > - asym_op->dh.pub_key.length = sizeof(out_pub_key);
> > - asym_op->dh.priv_key.data = out_prv_key;
> > - asym_op->dh.priv_key.length = sizeof(out_prv_key);
> > -
> > - ret = rte_cryptodev_asym_session_create(dev_id, &xform, sess_mpool,
> > &sess);
> > - if (ret < 0) {
> > - RTE_LOG(ERR, USER1,
> > - "line %u FAILED: %s", __LINE__,
> > - "Session creation failed");
> > - status = (ret == -ENOTSUP) ? TEST_SKIPPED : TEST_FAILED;
> > - goto error_exit;
> > - }
> > -
> > - /* attach asymmetric crypto session to crypto operations */
> > - rte_crypto_op_attach_asym_session(op, sess);
> > -
> > - RTE_LOG(DEBUG, USER1, "Process ASYM operation");
> > -
> > - /* Process crypto operation */
> > - if (rte_cryptodev_enqueue_burst(dev_id, 0, &op, 1) != 1) {
> > - RTE_LOG(ERR, USER1,
> > - "line %u FAILED: %s",
> > - __LINE__, "Error sending packet for operation");
> > - status = TEST_FAILED;
> > - goto error_exit;
> > - }
> > -
> > - while (rte_cryptodev_dequeue_burst(dev_id, 0, &result_op, 1) == 0)
> > - rte_pause();
> > -
> > - if (result_op == NULL) {
> > - RTE_LOG(ERR, USER1,
> > - "line %u FAILED: %s",
> > - __LINE__, "Failed to process asym crypto op");
> > - status = TEST_FAILED;
> > - goto error_exit;
> > - }
> > - debug_hexdump(stdout, "priv key:",
> > - out_prv_key, asym_op->dh.priv_key.length);
> > - debug_hexdump(stdout, "pub key:",
> > - out_pub_key, asym_op->dh.pub_key.length);
> > -
> > -error_exit:
> > - if (sess != NULL)
> > - rte_cryptodev_asym_session_free(dev_id, sess);
> > - if (op != NULL)
> > - rte_crypto_op_free(op);
> > -
> > - return status;
> > -}
> > -
> > -static int
> > test_mod_inv(void)
> > {
> > struct crypto_testsuite_params_asym *ts_params = &testsuite_params;
> > @@ -1611,12 +1519,6 @@ test_dh_keygenration(void)
> > dh_test_params.priv_key.length);
> >
> > RTE_LOG(INFO, USER1,
> > - "Test Public and Private key pair generation\n");
> > -
> > - status = test_dh_gen_kp(&dh_xform);
> > - TEST_ASSERT_EQUAL(status, 0, "Test failed");
> > -
> > - RTE_LOG(INFO, USER1,
> > "Test Public Key Generation using pre-defined priv key\n");
> >
> > status = test_dh_gen_pub_key(&dh_xform); @@ -1828,7 +1730,6 @@
> > test_ecdsa_sign_verify(enum curve curve_id)
> > asym_op = op->asym;
> >
> > /* Setup asym xform */
> > - xform.next = NULL;
> > xform.xform_type = RTE_CRYPTO_ASYM_XFORM_ECDSA;
> > xform.ec.curve_id = input_params.curve;
> >
> > @@ -2030,7 +1931,6 @@ test_ecpm(enum curve curve_id)
> > asym_op = op->asym;
> >
> > /* Setup asym xform */
> > - xform.next = NULL;
> > xform.xform_type = RTE_CRYPTO_ASYM_XFORM_ECPM;
> > xform.ec.curve_id = input_params.curve;
> >
> > diff --git a/app/test/test_cryptodev_dh_test_vectors.h
> > b/app/test/test_cryptodev_dh_test_vectors.h
> > index fe7510dcd3..078719072d 100644
> > --- a/app/test/test_cryptodev_dh_test_vectors.h
> > +++ b/app/test/test_cryptodev_dh_test_vectors.h
> > @@ -63,7 +63,6 @@ struct dh_test_param dh_test_params = { };
> >
> > struct rte_crypto_asym_xform dh_xform = {
> > - .next = NULL,
> > .xform_type = RTE_CRYPTO_ASYM_XFORM_DH,
> > .dh = {
> > .p = {
> > diff --git a/app/test/test_cryptodev_dsa_test_vectors.h
> > b/app/test/test_cryptodev_dsa_test_vectors.h
> > index bbcb0d7297..cc60f50b5c 100644
> > --- a/app/test/test_cryptodev_dsa_test_vectors.h
> > +++ b/app/test/test_cryptodev_dsa_test_vectors.h
> > @@ -91,7 +91,6 @@ struct dsa_test_param dsa_test_params = { };
> >
> > struct rte_crypto_asym_xform dsa_xform = {
> > - .next = NULL,
> > .xform_type = RTE_CRYPTO_ASYM_XFORM_DSA,
> > .dsa = {
> > .p = {
> > diff --git a/app/test/test_cryptodev_mod_test_vectors.h
> > b/app/test/test_cryptodev_mod_test_vectors.h
> > index 807ca7a47e..bcd4d5248b 100644
> > --- a/app/test/test_cryptodev_mod_test_vectors.h
> > +++ b/app/test/test_cryptodev_mod_test_vectors.h
> > @@ -1045,7 +1045,6 @@ uint8_t mod_inv[] = {
> >
> > /* MODEX vector. 8< */
> > struct rte_crypto_asym_xform modex_xform = {
> > - .next = NULL,
> > .xform_type = RTE_CRYPTO_ASYM_XFORM_MODEX,
> > .modex = {
> > .modulus = {
> > @@ -1061,7 +1060,6 @@ struct rte_crypto_asym_xform modex_xform = {
> > /* >8 End of MODEX vector. */
> >
> > struct rte_crypto_asym_xform modinv_xform = {
> > - .next = NULL,
> > .xform_type = RTE_CRYPTO_ASYM_XFORM_MODINV,
> > .modinv = {
> > .modulus = {
> > diff --git a/app/test/test_cryptodev_rsa_test_vectors.h
> > b/app/test/test_cryptodev_rsa_test_vectors.h
> > index 04539a1ecf..e769dec1f4 100644
> > --- a/app/test/test_cryptodev_rsa_test_vectors.h
> > +++ b/app/test/test_cryptodev_rsa_test_vectors.h
> > @@ -346,7 +346,6 @@ uint8_t rsa_qInv[] = {
> >
> > /** rsa xform using exponent key */
> > struct rte_crypto_asym_xform rsa_xform = {
> > - .next = NULL,
> > .xform_type = RTE_CRYPTO_ASYM_XFORM_RSA,
> > .rsa = {
> > .n = {
> > @@ -367,7 +366,6 @@ struct rte_crypto_asym_xform rsa_xform = {
> >
> > /** rsa xform using quintuple key */
> > struct rte_crypto_asym_xform rsa_xform_crt = {
> > - .next = NULL,
> > .xform_type = RTE_CRYPTO_ASYM_XFORM_RSA,
> > .rsa = {
> > .n = {
> > diff --git a/app/test/test_event_crypto_adapter.c
> > b/app/test/test_event_crypto_adapter.c
> > index 2ecc7e2cea..feb1d86c00 100644
> > --- a/app/test/test_event_crypto_adapter.c
> > +++ b/app/test/test_event_crypto_adapter.c
> > @@ -295,7 +295,6 @@ test_op_forward_mode(uint8_t session_less) #endif
> > /* Setup Cipher Parameters */
> > cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
> > - cipher_xform.next = NULL;
> > cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
> > cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
> >
> > @@ -474,7 +473,6 @@ test_asym_op_forward_mode(uint8_t session_less)
> > return TEST_SKIPPED;
> > }
> > /* Setup Cipher Parameters */
> > - xform_tc.next = NULL;
> > xform_tc.xform_type = RTE_CRYPTO_ASYM_XFORM_MODEX;
> > cap_idx.type = xform_tc.xform_type;
> > capability = rte_cryptodev_asym_capability_get(TEST_CDEV_ID,
> > &cap_idx);
> > @@ -672,7 +670,6 @@ test_op_new_mode(uint8_t session_less) #endif
> > /* Setup Cipher Parameters */
> > cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
> > - cipher_xform.next = NULL;
> > cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
> > cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
> >
> > @@ -807,7 +804,6 @@ test_asym_op_new_mode(uint8_t session_less)
> > return TEST_SKIPPED;
> > }
> > /* Setup Cipher Parameters */
> > - xform_tc.next = NULL;
> > xform_tc.xform_type = RTE_CRYPTO_ASYM_XFORM_MODEX;
> > cap_idx.type = xform_tc.xform_type;
> > capability = rte_cryptodev_asym_capability_get(TEST_CDEV_ID,
> > &cap_idx);
> > --
> > 2.13.6
next prev parent reply other threads:[~2022-05-20 7:39 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 5:54 [PATCH 00/40] cryptodev: rsa, dh, ecdh changes Arek Kusztal
2022-05-20 5:54 ` [PATCH 01/40] cryptodev: redefine ec group enum Arek Kusztal
2022-05-20 5:54 ` [PATCH 02/40] cryptodev: remove list end enumerators Arek Kusztal
2022-05-20 7:19 ` [EXT] " Akhil Goyal
2022-05-20 5:54 ` [PATCH 03/40] test/crypto: " Arek Kusztal
2022-05-20 5:54 ` [PATCH 04/40] cryptodev: reduce number of comments in asym xform Arek Kusztal
2022-05-24 10:59 ` [EXT] " Akhil Goyal
2022-05-24 17:37 ` Kusztal, ArkadiuszX
2022-05-25 5:44 ` Akhil Goyal
2022-05-20 5:54 ` [PATCH 05/40] test/crypto: removed asym xform none Arek Kusztal
2022-05-20 5:54 ` [PATCH 06/40] cryptodev: separate key exchange operation enum Arek Kusztal
2022-05-24 11:45 ` [EXT] " Akhil Goyal
2022-05-20 5:54 ` [PATCH 07/40] crypto/openssl: " Arek Kusztal
2022-05-20 5:54 ` [PATCH 08/40] test/crypto: " Arek Kusztal
2022-05-20 7:18 ` [EXT] " Akhil Goyal
2022-05-20 5:54 ` [PATCH 09/40] cryptodev: remove unnecessary zero assignement Arek Kusztal
2022-05-20 7:13 ` [EXT] " Akhil Goyal
2022-05-20 5:54 ` [PATCH 10/40] cryptodev: remove comment about using ephemeral key in dsa Arek Kusztal
2022-05-20 5:54 ` [PATCH 11/40] cryptodev: remove asym crypto next xform Arek Kusztal
2022-05-20 7:22 ` [EXT] " Akhil Goyal
2022-05-24 11:12 ` Akhil Goyal
2022-05-24 14:47 ` Kusztal, ArkadiuszX
2022-05-25 6:06 ` Akhil Goyal
2022-05-25 6:36 ` Kusztal, ArkadiuszX
2022-05-25 7:05 ` Anoob Joseph
2022-05-27 6:30 ` Kusztal, ArkadiuszX
2022-05-27 6:40 ` Kusztal, ArkadiuszX
2022-05-27 6:55 ` Kusztal, ArkadiuszX
2022-05-27 7:27 ` Anoob Joseph
2022-05-27 7:47 ` Kusztal, ArkadiuszX
2022-05-20 5:54 ` [PATCH 12/40] crypto/openssl: " Arek Kusztal
2022-05-20 5:54 ` [PATCH 13/40] test/crypto: " Arek Kusztal
2022-05-20 7:24 ` [EXT] " Akhil Goyal
2022-05-20 7:38 ` Kusztal, ArkadiuszX [this message]
2022-05-20 5:54 ` [PATCH 14/40] app/test-crypto-perf: " Arek Kusztal
2022-05-20 5:54 ` [PATCH 15/40] app/test-eventdev: " Arek Kusztal
2022-05-20 7:25 ` [EXT] " Akhil Goyal
2022-05-20 5:54 ` [PATCH 16/40] cryptodev: move dh type from xform to dh op Arek Kusztal
2022-05-24 11:52 ` [EXT] " Akhil Goyal
2022-05-20 5:54 ` [PATCH 17/40] crypto/openssl: " Arek Kusztal
2022-05-20 5:54 ` [PATCH 18/40] test/crypto: " Arek Kusztal
2022-05-20 5:54 ` [PATCH 19/40] cryptodev: changed order of dh fields Arek Kusztal
2022-05-20 5:54 ` [PATCH 20/40] cryptodev: add elliptic curve diffie hellman Arek Kusztal
2022-05-24 12:08 ` [EXT] " Akhil Goyal
2022-05-24 14:52 ` Kusztal, ArkadiuszX
2022-05-24 14:55 ` Kusztal, ArkadiuszX
2022-05-25 6:02 ` Akhil Goyal
2022-05-25 6:33 ` Kusztal, ArkadiuszX
2022-05-20 5:54 ` [PATCH 21/40] cryptodev: add public key verify option Arek Kusztal
2022-05-24 12:12 ` [EXT] " Akhil Goyal
2022-05-24 14:59 ` Kusztal, ArkadiuszX
2022-05-25 6:00 ` Akhil Goyal
2022-05-25 6:30 ` Kusztal, ArkadiuszX
2022-05-20 5:54 ` [PATCH 22/40] cryptodev: move RSA padding into separate struct Arek Kusztal
2022-05-20 5:54 ` [PATCH 23/40] crypto/qat: " Arek Kusztal
2022-05-20 5:54 ` [PATCH 24/40] crypto/openssl: " Arek Kusztal
2022-05-20 5:54 ` [PATCH 25/40] crypto/octeontx: " Arek Kusztal
2022-05-20 5:54 ` [PATCH 26/40] crypto/cnxk: " Arek Kusztal
2022-05-20 5:54 ` [PATCH 27/40] common/cpt: " Arek Kusztal
2022-05-20 5:54 ` [PATCH 28/40] test/crypto: " Arek Kusztal
2022-05-20 5:54 ` [PATCH 29/40] cryptodev: add salt length and optional label Arek Kusztal
2022-05-24 12:30 ` [EXT] " Akhil Goyal
2022-05-24 15:14 ` Kusztal, ArkadiuszX
2022-05-25 5:57 ` Akhil Goyal
2022-05-20 5:54 ` [PATCH 30/40] cryptodev: reduce rsa struct to only necessary fields Arek Kusztal
2022-05-24 12:52 ` [EXT] " Akhil Goyal
2022-05-24 15:33 ` Kusztal, ArkadiuszX
2022-05-25 5:48 ` Akhil Goyal
2022-05-20 5:54 ` [PATCH 31/40] crypto/qat: " Arek Kusztal
2022-05-20 5:54 ` [PATCH 32/40] crypto/openssl: " Arek Kusztal
2022-05-20 5:54 ` [PATCH 33/40] crypto/octeontx: " Arek Kusztal
2022-05-20 5:54 ` [PATCH 34/40] crypto/cnxk: " Arek Kusztal
2022-05-20 5:54 ` [PATCH 35/40] common/cpt: " Arek Kusztal
2022-05-20 5:54 ` [PATCH 36/40] test/crypto: " Arek Kusztal
2022-05-20 5:54 ` [PATCH 37/40] cryptodev: add asym op flags Arek Kusztal
2022-05-20 12:07 ` [EXT] " Akhil Goyal
2022-05-20 5:54 ` [PATCH 38/40] cryptodev: clarify usage of private key in dh Arek Kusztal
2022-05-24 12:56 ` [EXT] " Akhil Goyal
2022-05-24 14:30 ` Kusztal, ArkadiuszX
2022-05-25 6:09 ` Akhil Goyal
2022-05-25 6:37 ` Kusztal, ArkadiuszX
2022-05-20 5:54 ` [PATCH 39/40] crypto/openssl: generate dh private key Arek Kusztal
2022-05-20 5:54 ` [PATCH 40/40] test/crypto: added test for dh priv key generation Arek Kusztal
2022-05-20 7:30 ` [EXT] [PATCH 00/40] cryptodev: rsa, dh, ecdh changes Akhil Goyal
2022-05-20 7:37 ` Kusztal, ArkadiuszX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB5013AAB4B7B56E5744233E1D9FD39@PH0PR11MB5013.namprd11.prod.outlook.com \
--to=arkadiuszx.kusztal@intel.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).