From: "Wang, YuanX" <yuanx.wang@intel.com>
To: "Xia, Chenbo" <chenbo.xia@intel.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Hu, Jiayu" <jiayu.hu@intel.com>,
"He, Xingguang" <xingguang.he@intel.com>,
"Jiang, Cheng1" <cheng1.jiang@intel.com>,
"Ma, WenwuX" <wenwux.ma@intel.com>
Subject: RE: [PATCH v3] net/vhost: support asynchronous data path
Date: Wed, 28 Sep 2022 08:13:00 +0000 [thread overview]
Message-ID: <PH7PR11MB6953039E4898C6C0E41F37AB85549@PH7PR11MB6953.namprd11.prod.outlook.com> (raw)
In-Reply-To: <PH7PR11MB6953E30C9520F4DF2275784185559@PH7PR11MB6953.namprd11.prod.outlook.com>
Hi Chenbo,
> -----Original Message-----
> From: Wang, YuanX
> Sent: Tuesday, September 27, 2022 3:34 PM
> To: Xia, Chenbo <Chenbo.Xia@intel.com>; maxime.coquelin@redhat.com;
> dev@dpdk.org
> Cc: Hu, Jiayu <Jiayu.Hu@intel.com>; He, Xingguang
> <xingguang.he@intel.com>; Jiang, Cheng1 <Cheng1.Jiang@intel.com>; Ma,
> WenwuX <WenwuX.Ma@intel.com>
> Subject: RE: [PATCH v3] net/vhost: support asynchronous data path
>
> Hi Chenbo,
>
> > -----Original Message-----
> > From: Xia, Chenbo <chenbo.xia@intel.com>
> > Sent: Monday, September 26, 2022 2:55 PM
> > To: Wang, YuanX <yuanx.wang@intel.com>;
> maxime.coquelin@redhat.com;
> > dev@dpdk.org
> > Cc: Hu, Jiayu <jiayu.hu@intel.com>; He, Xingguang
> > <xingguang.he@intel.com>; Jiang, Cheng1 <cheng1.jiang@intel.com>; Ma,
> > WenwuX <wenwux.ma@intel.com>
> > Subject: RE: [PATCH v3] net/vhost: support asynchronous data path
> >
> > > -----Original Message-----
> > > From: Wang, YuanX <yuanx.wang@intel.com>
> > > Sent: Wednesday, August 24, 2022 12:36 AM
> > > To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>;
> > > dev@dpdk.org
> > > Cc: Hu, Jiayu <jiayu.hu@intel.com>; He, Xingguang
> > > <xingguang.he@intel.com>; Jiang, Cheng1 <cheng1.jiang@intel.com>;
> > > Wang, YuanX <yuanx.wang@intel.com>; Ma, WenwuX
> > <wenwux.ma@intel.com>
> > > Subject: [PATCH v3] net/vhost: support asynchronous data path
> >
[snip]
> > > +static cmdline_parse_token_string_t cmd_tx_async_vhost =
> > > + TOKEN_STRING_INITIALIZER(struct cmd_tx_poll_result, async_vhost,
> > > "async_vhost");
> > > +static cmdline_parse_token_string_t cmd_tx_tx =
> > > + TOKEN_STRING_INITIALIZER(struct cmd_tx_poll_result, tx, "tx");
> > > +static cmdline_parse_token_string_t cmd_tx_poll =
> > > + TOKEN_STRING_INITIALIZER(struct cmd_tx_poll_result, poll, "poll");
> > > +static cmdline_parse_token_string_t cmd_tx_completed =
> > > + TOKEN_STRING_INITIALIZER(struct cmd_tx_poll_result, completed,
> > > "completed");
> > > +static cmdline_parse_token_string_t cmd_tx_what =
> > > + TOKEN_STRING_INITIALIZER(struct cmd_tx_poll_result, what,
> > "on#off");
> > > +
> > > +static void
> > > +cmd_tx_poll_parsed(void *parsed_result, __rte_unused struct cmdline
> > > +*cl,
> > > __rte_unused void *data)
> > > +{
> > > + struct cmd_tx_poll_result *res = parsed_result;
> > > +
> > > + if (!strcmp(res->what, "on"))
> > > + rte_eth_vhost_async_tx_poll_completed(true);
> > > + else if (!strcmp(res->what, "off"))
> > > + rte_eth_vhost_async_tx_poll_completed(false);
> >
> > We should print log when the user input is not on/off.
>
> Thanks for your suggestion, will add the log in v4.
Sorry, I made a mistake. Entering other values will cause testpmd to report a "Bad arguments" error.
So, I don't think additional log is needed, what do you think?
Thanks,
Yuan
>
> Thanks,
> Yuan
>
> >
> > Thanks,
> > Chenbo
> >
> > > +}
> > > +
> > > +static cmdline_parse_inst_t async_vhost_cmd_tx_poll = {
> > > + .f = cmd_tx_poll_parsed,
> > > + .data = NULL,
> > > + .help_str = "async-vhost tx poll completed on|off",
> > > + .tokens = {
> > > + (void *)&cmd_tx_async_vhost,
> > > + (void *)&cmd_tx_tx,
> > > + (void *)&cmd_tx_poll,
> > > + (void *)&cmd_tx_completed,
> > > + (void *)&cmd_tx_what,
> > > + NULL,
> > > + },
> > > +};
> > > +
> > > +static struct testpmd_driver_commands async_vhost_cmds = {
> > > + .commands = {
> > > + {
> > > + &async_vhost_cmd_tx_poll,
> > > + "async_vhost tx poll completed (on|off)\n"
> > > + " Poll and free DMA completed packets in Tx path.\n",
> > > + },
> > > + { NULL, NULL },
> > > + },
> > > +};
> > > +
> > > +TESTPMD_ADD_DRIVER_COMMANDS(async_vhost_cmds)
> > > --
> > > 2.25.1
next prev parent reply other threads:[~2022-09-28 8:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-14 15:06 [PATCH] " Jiayu Hu
2022-08-18 2:05 ` [PATCH v2] " Jiayu Hu
2022-08-23 16:35 ` [PATCH v3] " Yuan Wang
2022-09-26 6:55 ` Xia, Chenbo
2022-09-27 7:34 ` Wang, YuanX
2022-09-28 8:13 ` Wang, YuanX [this message]
2022-10-10 5:17 ` Hu, Jiayu
2022-10-18 11:59 ` Xia, Chenbo
2022-09-29 19:47 ` [PATCH v4] " Yuan Wang
2022-10-19 14:10 ` Xia, Chenbo
2022-10-20 14:00 ` Wang, YuanX
2022-10-24 15:14 ` [PATCH v5] " Yuan Wang
2022-10-24 9:02 ` Xia, Chenbo
2022-10-24 9:25 ` Wang, YuanX
2022-10-24 9:08 ` Maxime Coquelin
2022-10-25 2:14 ` Hu, Jiayu
2022-10-25 7:52 ` Maxime Coquelin
2022-10-25 9:15 ` Hu, Jiayu
2022-10-25 15:33 ` Maxime Coquelin
2022-10-25 15:44 ` Bruce Richardson
2022-10-25 16:04 ` Maxime Coquelin
2022-10-26 2:48 ` Hu, Jiayu
2022-10-26 5:00 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR11MB6953039E4898C6C0E41F37AB85549@PH7PR11MB6953.namprd11.prod.outlook.com \
--to=yuanx.wang@intel.com \
--cc=chenbo.xia@intel.com \
--cc=cheng1.jiang@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=wenwux.ma@intel.com \
--cc=xingguang.he@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).