From: Madhuker Mythri <madhuker.mythri@oracle.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "ferruh.yigit@amd.com" <ferruh.yigit@amd.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [External] : Re: [PATCH] net/tap: Modified TAP BPF program as per the new Kernel-version upgrade requirements.
Date: Fri, 5 Jan 2024 14:58:51 +0000 [thread overview]
Message-ID: <SJ0PR10MB479856670E131B0AC7E5A2F797662@SJ0PR10MB4798.namprd10.prod.outlook.com> (raw)
In-Reply-To: <20240104123200.740ddfd8@hermes.local>
Sure, will update accordingly.
Thanks,
Madhuker.
-----Original Message-----
From: Stephen Hemminger <stephen@networkplumber.org>
Sent: 05 January 2024 02:02
To: Madhuker Mythri <madhuker.mythri@oracle.com>
Cc: ferruh.yigit@amd.com; dev@dpdk.org
Subject: [External] : Re: [PATCH] net/tap: Modified TAP BPF program as per the new Kernel-version upgrade requirements.
On Thu, 4 Jan 2024 22:57:56 +0530
madhuker.mythri@oracle.com wrote:
> From: Madhuker Mythri <madhuker.mythri@oracle.com>
>
> When multiple queues configured, internally RSS will be enabled and thus TAP BPF RSS byte-code will be loaded on to the Kernel using BPF system calls.
>
> Here, the problem is loading the existing BPF byte-code to the Kernel-5.15 and above versions throws errors, i.e: Kernel BPF verifier not accepted this existing BPF byte-code and system calls return error code "-7" as follows:
> ------------------------
> rss_add_actions(): Failed to load BPF section l3_l4 (7): Argument list too long
> ------------------------
>
> RCA: These errors started coming after from the Kernel-5.15 version, in which lots of new BPF verification restrictions were added for safe execution of byte-code on to the Kernel, due to which existing BPF program verification does not pass.
> Here are the major BPF verifier restrictions observed:
> 1) Need to use new BPF maps structure.
> 2) Kernel SKB data pointer access not allowed.
> 3) Undefined loops were not allowed(which are bounded by a variable value).
> 4) unreachable instructions(like: undefined array access).
>
> After addressing all these Kernel BPF verifier restrictions able to load the BPF byte-code onto the Kernel successfully.
>
> Note: This new BPF changes supports from Kernel:4.10 version.
>
> Bugzilla Id: 1329
>
> Signed-off-by: Madhuker Mythri <madhuker.mythri@oracle.com>
> ---
> drivers/net/tap/bpf/tap_bpf_program.c | 243 +-
> drivers/net/tap/tap_bpf_api.c | 4 +-
> drivers/net/tap/tap_bpf_insns.h | 3781 ++++++++++++++-----------
> 3 files changed, 2151 insertions(+), 1877 deletions(-)
Patch has trailing whitespace, git complains:
$ git am /tmp/bpf.mbox
Applying: net/tap: Modified TAP BPF program as per the new Kernel-version upgrade requirements.
/home/shemminger/DPDK/main/.git/worktrees/libbpf/rebase-apply/patch:98: trailing whitespace.
// queue match
/home/shemminger/DPDK/main/.git/worktrees/libbpf/rebase-apply/patch:243: trailing whitespace.
/** Is IP fragmented **/
/home/shemminger/DPDK/main/.git/worktrees/libbpf/rebase-apply/patch:326: trailing whitespace.
/* bpf_printk(">>>>> rss_l3_l4 hash=0x%x queue:1=%u\n", hash, queue); */
warning: 3 lines add whitespace errors.
next prev parent reply other threads:[~2024-01-05 15:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-04 17:27 madhuker.mythri
2024-01-04 20:32 ` Stephen Hemminger
2024-01-05 14:58 ` Madhuker Mythri [this message]
2024-01-04 20:33 ` Stephen Hemminger
2024-01-04 20:35 ` Stephen Hemminger
2024-01-04 20:38 ` Stephen Hemminger
2024-01-05 14:58 ` [External] : " Madhuker Mythri
2024-01-05 17:40 ` Stephen Hemminger
2024-01-04 20:39 ` Stephen Hemminger
2024-01-04 20:41 ` Stephen Hemminger
2024-01-05 15:11 ` [External] : " Madhuker Mythri
2024-01-05 17:41 ` Stephen Hemminger
2024-01-04 20:42 ` Stephen Hemminger
2024-01-04 20:57 ` Stephen Hemminger
2024-01-05 14:44 ` [External] : " Madhuker Mythri
2024-01-05 17:39 ` Stephen Hemminger
2024-01-06 5:47 ` Madhuker Mythri
2024-01-05 19:30 ` Stephen Hemminger
2024-01-06 5:36 ` [External] : " Madhuker Mythri
2024-01-06 10:23 ` Madhuker Mythri
2024-01-06 16:54 ` Stephen Hemminger
2024-01-06 18:16 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR10MB479856670E131B0AC7E5A2F797662@SJ0PR10MB4798.namprd10.prod.outlook.com \
--to=madhuker.mythri@oracle.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).