From: Chaoyong He <chaoyong.he@corigine.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>,
dpdklab <dpdklab@iol.unh.edu>, Patrick Robb <probb@iol.unh.edu>
Cc: oss-drivers <oss-drivers@corigine.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH 00/11] Add basic flow support for corenic firmware
Date: Tue, 7 Nov 2023 09:23:29 +0000 [thread overview]
Message-ID: <SJ0PR13MB5545D2E5884316B79D93F86F9EA9A@SJ0PR13MB5545.namprd13.prod.outlook.com> (raw)
In-Reply-To: <92831614-6ddc-4bc0-a0c8-4fa6e41f5799@amd.com>
> On 11/7/2023 1:42 AM, Chaoyong He wrote:
> >> On 11/3/2023 6:25 AM, Chaoyong He wrote:
> >>> Add the very basic rte_flow support for corenic firmware.
> >>>
> >>> Chaoyong He (11):
> >>> net/nfp: move some source files
> >>> drivers: add the structures and functions for flow offload
> >>> net/nfp: add the control message channel
> >>> net/nfp: support flow API for CoreNIC firmware
> >>> net/nfp: support Ethernet flow item
> >>> net/nfp: support drop flow action
> >>> net/nfp: support IPv4 flow item
> >>> net/nfp: support IPv6 flow item
> >>> net/nfp: support TCP/UDP/SCTP flow items
> >>> drivers: support MARK flow action
> >>> net/nfp: support QUEUE flow action
> >>>
> >>
> >> Recheck-request: iol-compile-amd64-testing, iol-unit-amd64-testing
> >
> > Seems both compile problems was introduced by this commit:
> > https://github.com/Corigine/dpdk-next-net-
> private/commit/34ff088cc2415
> > 9c9fa6e61242efb76d0289b4e37
> >
> > ```
> > ethdev: set and query RSS hash algorithm Currently, rte_eth_rss_conf
> > supports configuring and querying RSS hash functions, rss key and it's
> > length, but not RSS hash algorithm.
> >
> > The structure ``rte_eth_dev_info`` is extended by adding a new field
> > "rss_algo_capa". Drivers are responsible for reporting this capa and
> > configurations of RSS hash algorithm can be verified based on the
> > capability. The default value of "rss_algo_capa" is
> > RTE_ETH_HASH_ALGO_CAPA_MASK(DEFAULT) if drivers do not report it.
> >
> > The structure ``rte_eth_rss_conf`` is extended by adding a new field
> > "algorithm". This represents the RSS algorithms to apply.
> > If the value of "algorithm" used for configuration is a gibberish
> > value, drivers should report the error.
> >
> > To check whether the drivers report valid "algorithm", it is set to
> > default value before querying in rte_eth_dev_rss_hash_conf_get().
> >
> > Signed-off-by: Jie Hai <haijie1@huawei.com>
> > Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>
> > Acked-by: Huisong Li <lihuisong@huawei.com>
> > Acked-by: Chengwen Feng <fengchengwen@huawei.com>
> > Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com> ```
> >
> > Which was not related with this patch series, I think?
> >
>
> Yes, build error is not related with this patch, and it is fixed in next-net, that is
> why I tried to re-trigger the test, but it didn't work somehow [1].
>
> Btw, this set is pending because of other change request, not because of the
> reported build failure.
Oh, yes, I understand, the reason is I need to also update the 'nfp.ini' document.
But we decide delay this patch set to the next version of DPDK as we found still need some
modification to the logic of flower firmware.
Thanks.
>
>
> [1]
> https://patchwork.dpdk.org/project/dpdk/patch/20231103062606.263201
> 2-12-chaoyong.he@corigine.com/
>
next prev parent reply other threads:[~2023-11-07 9:23 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 6:25 Chaoyong He
2023-11-03 6:25 ` [PATCH 01/11] net/nfp: move some source files Chaoyong He
2023-11-03 6:25 ` [PATCH 02/11] drivers: add the structures and functions for flow offload Chaoyong He
2023-11-03 6:25 ` [PATCH 03/11] net/nfp: add the control message channel Chaoyong He
2023-11-03 6:25 ` [PATCH 04/11] net/nfp: support flow API for CoreNIC firmware Chaoyong He
2023-11-03 6:26 ` [PATCH 05/11] net/nfp: support Ethernet flow item Chaoyong He
2023-11-03 6:26 ` [PATCH 06/11] net/nfp: support drop flow action Chaoyong He
2023-11-03 6:26 ` [PATCH 07/11] net/nfp: support IPv4 flow item Chaoyong He
2023-11-03 6:26 ` [PATCH 08/11] net/nfp: support IPv6 " Chaoyong He
2023-11-03 6:26 ` [PATCH 09/11] net/nfp: support TCP/UDP/SCTP flow items Chaoyong He
2023-11-03 6:26 ` [PATCH 10/11] drivers: support MARK flow action Chaoyong He
2023-11-03 6:26 ` [PATCH 11/11] net/nfp: support QUEUE " Chaoyong He
2023-11-03 16:12 ` [PATCH 00/11] Add basic flow support for corenic firmware Ferruh Yigit
2023-11-07 1:42 ` Chaoyong He
2023-11-07 9:18 ` Ferruh Yigit
2023-11-07 9:23 ` Chaoyong He [this message]
2023-11-07 16:50 ` Patrick Robb
2023-11-07 17:04 ` Patrick Robb
2023-11-07 20:19 ` Ferruh Yigit
2023-11-07 21:59 ` Patrick Robb
2023-11-03 17:01 ` Ferruh Yigit
2023-12-05 2:54 ` [PATCH v2 " Chaoyong He
2023-12-05 2:54 ` [PATCH v2 01/11] net/nfp: move some source files Chaoyong He
2023-12-05 2:54 ` [PATCH v2 02/11] net/nfp: add the structures and functions for flow offload Chaoyong He
2023-12-05 2:54 ` [PATCH v2 03/11] net/nfp: add the control message channel Chaoyong He
2023-12-08 19:15 ` Ferruh Yigit
2023-12-05 2:54 ` [PATCH v2 04/11] net/nfp: support flow API for CoreNIC firmware Chaoyong He
2023-12-05 2:54 ` [PATCH v2 05/11] net/nfp: support Ethernet flow item Chaoyong He
2023-12-05 2:54 ` [PATCH v2 06/11] net/nfp: support drop flow action Chaoyong He
2023-12-05 2:54 ` [PATCH v2 07/11] net/nfp: support IPv4 flow item Chaoyong He
2023-12-05 2:54 ` [PATCH v2 08/11] net/nfp: support IPv6 " Chaoyong He
2023-12-05 2:54 ` [PATCH v2 09/11] net/nfp: support TCP/UDP/SCTP flow items Chaoyong He
2023-12-05 2:54 ` [PATCH v2 10/11] net/nfp: support MARK flow action Chaoyong He
2023-12-05 2:54 ` [PATCH v2 11/11] net/nfp: support QUEUE " Chaoyong He
2023-12-08 16:39 ` [PATCH v2 00/11] Add basic flow support for corenic firmware Ferruh Yigit
2023-12-11 1:42 ` Chaoyong He
2023-12-11 14:06 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR13MB5545D2E5884316B79D93F86F9EA9A@SJ0PR13MB5545.namprd13.prod.outlook.com \
--to=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=dpdklab@iol.unh.edu \
--cc=ferruh.yigit@amd.com \
--cc=oss-drivers@corigine.com \
--cc=probb@iol.unh.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).