From: "Xueming(Steven) Li" <xuemingl@mellanox.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix applications failure on configure
Date: Wed, 2 May 2018 09:58:44 +0000 [thread overview]
Message-ID: <VI1PR05MB16782ECA2529512AEB2A6441AC800@VI1PR05MB1678.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <68310139-6baf-baab-bbe9-3da0883960bc@intel.com>
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Tuesday, May 1, 2018 10:32 PM
> To: Thomas Monjalon <thomas@monjalon.net>
> Cc: Xueming(Steven) Li <xuemingl@mellanox.com>; dev@dpdk.org
> Subject: Re: [PATCH] ethdev: fix applications failure on configure
>
> On 5/1/2018 3:12 PM, Thomas Monjalon wrote:
> > 01/05/2018 16:08, Ferruh Yigit:
> >> On 5/1/2018 3:01 PM, Thomas Monjalon wrote:
> >>> 01/05/2018 15:33, Ferruh Yigit:
> >>>> Many sample applications fail because of
> >>>> dev_info.flow_type_rss_offloads check in rte_eth_dev_configure()
> >>>
> >>> We need to define the API behaviour in doxygen.
> >>>
> >>>> The sample applications need to be fixed/updated before returning
> >>>> error on rte_eth_dev_configure()
> >>>>
> >>>> This patch keeps the error log but removes returning error.
> >>>
> >>> If the doc is updated in 18.05, we can have a deprecation notice to
> >>> insert the error return in 18.08.
> >>
> >> +1 to add a deprecation notice for this release and do the error return on 18.08.
> >>
> >> Is the doc update you mentioned doxygen update?
> >
> > Yes, doxygen update.
> >
> >> Who can do doc update and deprecation notice patches for this release?
> >
> > Either you Ferruh, or Xueming and me together.
> > What do you prefer?
>
> Or as Xueming suggested, we can take rss_hf config as best effort and not return error at all.
>
> I think this forces PMDs to have up-to-date flow_type_rss_offloads values, is there any other benefit?
> What was the initial motivation to add error return on this check?
The original idea is to add rss_hf check on mlx5 PMD, while it looks more generic
to move the check to ethdev api from discussion[1].
[1] http://www.dpdk.org/ml/archives/dev/2018-April/095136.html
>
> >
> >>>> Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
> >>>> Cc: xuemingl@mellanox.com
> >>>>
> >>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >
> >
> >
next prev parent reply other threads:[~2018-05-02 9:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 13:33 Ferruh Yigit
2018-05-01 13:50 ` Xueming(Steven) Li
2018-05-01 14:01 ` Thomas Monjalon
2018-05-01 14:08 ` Ferruh Yigit
2018-05-01 14:12 ` Thomas Monjalon
2018-05-01 14:32 ` Ferruh Yigit
2018-05-02 9:58 ` Xueming(Steven) Li [this message]
2018-05-02 10:06 ` Thomas Monjalon
2018-05-02 17:09 ` Shahaf Shuler
2018-05-02 17:24 ` Ferruh Yigit
2018-05-01 15:30 ` Thomas Monjalon
2018-05-01 15:59 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR05MB16782ECA2529512AEB2A6441AC800@VI1PR05MB1678.eurprd05.prod.outlook.com \
--to=xuemingl@mellanox.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).