From: Bruce Richardson <bruce.richardson@intel.com>
To: Nic Chautru <nicolas.chautru@intel.com>
Cc: <dev@dpdk.org>, <thomas@monjalon.net>, <gakhil@marvell.com>,
<hemant.agrawal@nxp.com>, <maxime.coquelin@redhat.com>,
<trix@redhat.com>, <mdr@ashroe.eu>, <david.marchand@redhat.com>,
<stephen@networkplumber.org>, <hernan.vargas@intel.com>
Subject: Re: [PATCH v2 02/11] baseband/acc200: introduce PMD for ACC200
Date: Mon, 12 Sep 2022 16:41:46 +0100 [thread overview]
Message-ID: <Yx9TOiKP5YBz1flU@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <1662944938-32649-3-git-send-email-nicolas.chautru@intel.com>
On Sun, Sep 11, 2022 at 06:08:49PM -0700, Nic Chautru wrote:
> From: Nicolas Chautru <nicolas.chautru@intel.com>
>
> This patch introduce stubs for device driver for the ACC200
> integrated VRAN accelerator on SPR-EEC
>
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
> MAINTAINERS | 3 +
> doc/guides/bbdevs/acc200.rst | 244 +++++++++++++++++++++++++++++++
> doc/guides/bbdevs/index.rst | 1 +
> drivers/baseband/acc200/acc200_pmd.h | 32 ++++
> drivers/baseband/acc200/meson.build | 6 +
> drivers/baseband/acc200/rte_acc200_pmd.c | 142 ++++++++++++++++++
> drivers/baseband/acc200/version.map | 3 +
> drivers/baseband/meson.build | 1 +
> 8 files changed, 432 insertions(+)
> create mode 100644 doc/guides/bbdevs/acc200.rst
> create mode 100644 drivers/baseband/acc200/acc200_pmd.h
> create mode 100644 drivers/baseband/acc200/meson.build
> create mode 100644 drivers/baseband/acc200/rte_acc200_pmd.c
> create mode 100644 drivers/baseband/acc200/version.map
>
<snip>
> diff --git a/drivers/baseband/acc200/meson.build b/drivers/baseband/acc200/meson.build
> new file mode 100644
> index 0000000..7ec8679
> --- /dev/null
> +++ b/drivers/baseband/acc200/meson.build
> @@ -0,0 +1,6 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2022 Intel Corporation
> +
> +deps += ['bbdev', 'bus_vdev', 'ring', 'pci', 'bus_pci']
> +
Does this really depend on both bus_vdev and bus_pci?
Ideally, I think that drivers/baseband/meson.build should probably have the
line "std_deps = ['bbdev']" to pull in that as a dependency for all
baseband drivers.
Based off some quick testing, I got this driver to build with just
"deps += ['bbdev', 'bus_pci']". Though, again, I think these probably
should be standard deps for all bbdevs.
> +sources = files('rte_acc200_pmd.c')
Given that the driver is using shared headers with the acc100 codebase, you
might want to consider putting in
"includes += include_directories('../acc100')"
in the meson.build file. It saves you having to manually specify the full
path to all these shared headers, and gives you only one place to update
things if those headers ever move elsewhere.
/Bruce
next prev parent reply other threads:[~2022-09-12 15:42 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 0:01 [PATCH v1 00/10] baseband/acc200 Nicolas Chautru
2022-07-08 0:01 ` [PATCH v1 01/10] baseband/acc200: introduce PMD for ACC200 Nicolas Chautru
2022-09-12 1:08 ` [PATCH v2 00/11] baseband/acc200 Nic Chautru
2022-09-12 1:08 ` [PATCH v2 01/11] baseband/acc100: refactory to segregate common code Nic Chautru
2022-09-12 15:19 ` Bruce Richardson
2022-09-12 1:08 ` [PATCH v2 02/11] baseband/acc200: introduce PMD for ACC200 Nic Chautru
2022-09-12 15:41 ` Bruce Richardson [this message]
2022-09-12 1:08 ` [PATCH v2 03/11] baseband/acc200: add HW register definitions Nic Chautru
2022-09-12 1:08 ` [PATCH v2 04/11] baseband/acc200: add info get function Nic Chautru
2022-09-12 1:08 ` [PATCH v2 05/11] baseband/acc200: add queue configuration Nic Chautru
2022-09-12 1:08 ` [PATCH v2 06/11] baseband/acc200: add LDPC processing functions Nic Chautru
2022-09-12 1:08 ` [PATCH v2 07/11] baseband/acc200: add LTE " Nic Chautru
2022-09-12 1:08 ` [PATCH v2 08/11] baseband/acc200: add support for FFT operations Nic Chautru
2022-09-12 1:08 ` [PATCH v2 09/11] baseband/acc200: support interrupt Nic Chautru
2022-09-12 1:08 ` [PATCH v2 10/11] baseband/acc200: add device status and vf2pf comms Nic Chautru
2022-09-12 1:08 ` [PATCH v2 11/11] baseband/acc200: add PF configure companion function Nic Chautru
2022-07-08 0:01 ` [PATCH v1 02/10] baseband/acc200: add HW register definitions Nicolas Chautru
2022-07-08 0:01 ` [PATCH v1 03/10] baseband/acc200: add info get function Nicolas Chautru
2022-07-08 0:01 ` [PATCH v1 04/10] baseband/acc200: add queue configuration Nicolas Chautru
2022-07-08 0:01 ` [PATCH v1 05/10] baseband/acc200: add LDPC processing functions Nicolas Chautru
2022-07-08 0:01 ` [PATCH v1 06/10] baseband/acc200: add LTE " Nicolas Chautru
2022-07-08 0:01 ` [PATCH v1 07/10] baseband/acc200: add support for FFT operations Nicolas Chautru
2022-07-08 0:01 ` [PATCH v1 08/10] baseband/acc200: support interrupt Nicolas Chautru
2022-07-08 0:01 ` [PATCH v1 09/10] baseband/acc200: add device status and vf2pf comms Nicolas Chautru
2022-07-08 0:01 ` [PATCH v1 10/10] baseband/acc200: add PF configure companion function Nicolas Chautru
2022-07-12 13:48 ` [PATCH v1 00/10] baseband/acc200 Maxime Coquelin
2022-07-14 18:49 ` Vargas, Hernan
2022-07-17 13:08 ` Tom Rix
2022-07-22 18:29 ` Vargas, Hernan
2022-07-22 20:19 ` Tom Rix
2022-08-15 17:52 ` Chautru, Nicolas
2022-08-30 7:44 ` Maxime Coquelin
2022-08-30 19:45 ` Chautru, Nicolas
2022-08-31 16:43 ` Maxime Coquelin
2022-08-31 19:20 ` Thomas Monjalon
2022-08-31 19:26 ` Tom Rix
2022-08-31 22:37 ` Chautru, Nicolas
2022-09-01 0:28 ` Tom Rix
2022-09-01 1:26 ` Chautru, Nicolas
2022-09-01 13:49 ` Tom Rix
2022-09-01 20:34 ` Chautru, Nicolas
2022-09-06 12:51 ` Tom Rix
2022-09-14 10:35 ` Thomas Monjalon
2022-09-14 11:50 ` Maxime Coquelin
2022-09-14 13:19 ` Bruce Richardson
2022-09-14 13:27 ` Maxime Coquelin
2022-09-14 13:44 ` [EXT] " Akhil Goyal
2022-09-14 14:23 ` Thomas Monjalon
2022-09-14 19:57 ` Chautru, Nicolas
2022-09-14 20:08 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yx9TOiKP5YBz1flU@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=hemant.agrawal@nxp.com \
--cc=hernan.vargas@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=mdr@ashroe.eu \
--cc=nicolas.chautru@intel.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).