From: Bruce Richardson <bruce.richardson@intel.com>
To: "Abdullah Ömer Yamaç" <omer.yamac@ceng.metu.edu.tr>
Cc: <dev@dpdk.org>, <ferruh.yigit@amd.com>
Subject: Re: [PATCH] drivers: suggestion on removing empty version.map files
Date: Mon, 3 Oct 2022 10:19:25 +0100 [thread overview]
Message-ID: <YzqpHZTOj+xLwenN@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20221003065203.555038-1-omer.yamac@ceng.metu.edu.tr>
On Mon, Oct 03, 2022 at 09:52:03AM +0300, Abdullah Ömer Yamaç wrote:
> In this patch, we remove all version.map files which include
> only the below part:
> `DPDK_23 {
> local: *;
> };`
>
> Then we modify the meson.build to be able to compile without version.map
>
> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
> Suggested-by: Ferruh Yigit <ferruh.yigit@amd.com>
> ---
I think you need to flag this as depending on us bumping the meson version
requirement up to 0.53 as has been proposed. This doesn't work with 0.4x
versions.
One other suggestion is to split this into 2 patches. Have the first patch
just with the meson changes to support this, and the second patch then
doing the actual removal. That would make this a lot easier to review since
the code needing the review will all be in the first patch.
Otherwise, good idea!
Regards,
/Bruce
next prev parent reply other threads:[~2022-10-03 9:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 6:52 Abdullah Ömer Yamaç
2022-10-03 9:19 ` Bruce Richardson [this message]
2022-10-03 13:59 ` Omer Yamac
2022-10-03 14:01 ` Bruce Richardson
2022-10-04 6:30 ` Omer Yamac
2022-10-04 8:07 ` Bruce Richardson
2022-10-06 7:19 ` [PATCH 1/2] drivers: suggestion on meson without version file Abdullah Ömer Yamaç
2022-10-06 7:19 ` [PATCH 2/2] drivers: remove the unnecessary version.map Abdullah Ömer Yamaç
2022-10-07 10:30 ` [PATCH 1/2] drivers: suggestion on meson without version file Bruce Richardson
2022-10-10 7:41 ` Omer Yamac
2022-10-10 8:34 ` Bruce Richardson
2022-10-11 11:08 ` [PATCH v2 1/2] build: make version file optional for drivers Abdullah Ömer Yamaç
2022-10-11 11:08 ` [PATCH v2 2/2] drivers: remove the unnecessary version.map Abdullah Ömer Yamaç
2022-10-11 13:10 ` David Marchand
2022-10-11 19:21 ` Omer Yamac
2022-10-12 10:29 ` [PATCH v3 1/2] build: make version file optional for drivers Abdullah Ömer Yamaç
2022-10-12 10:29 ` [PATCH v3 2/2] " Abdullah Ömer Yamaç
2022-10-12 10:42 ` [PATCH v4 1/2] " Abdullah Ömer Yamaç
2022-10-12 10:42 ` [PATCH v4 2/2] drivers: remove the unnecessary Abdullah Ömer Yamaç
2022-10-12 11:32 ` [PATCH v4 1/2] build: make version file optional for drivers Ferruh Yigit
2022-11-14 14:19 ` David Marchand
2022-10-11 12:00 ` [PATCH v2 " Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzqpHZTOj+xLwenN@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=omer.yamac@ceng.metu.edu.tr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).