From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Akhil Goyal <gakhil@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [EXT] [PATCH] app/test: drop dependency on crypto scheduler driver
Date: Thu, 28 Sep 2023 10:55:47 +0100 [thread overview]
Message-ID: <ZRVNo1zBALzs/y86@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8xMV8-Q4pywzy0=2pDmPyNcq2pF-BbAnE-0fVht9o2OFQ@mail.gmail.com>
On Thu, Sep 28, 2023 at 11:45:37AM +0200, David Marchand wrote:
> On Thu, Sep 28, 2023 at 11:37 AM Akhil Goyal <gakhil@marvell.com> wrote:
> >
> > > The cryptodev autotests make use of the crypto scheduler driver when it
> > > is available, but build fine without. We can therefore remove the hard
> > > dependency on that driver when building the crypto test files.
>
> loongarch CI does not seem to agree, can you have a look?
>
Yes, although I find the error reported a little strange as it should not
be including the header if the component is not available.
However, first I'm looking into some other issues I caught post-post
of the patch. The dependency tracking is also not correct after this
change, so I need to do a little more digging to fix this. I probably need
a precursor patch to fix the dependency assignment for the binary, as
having optional dependencies means we can no longer use the dependency list
for determining what objects we need to link against (and what header paths
to search). Instead for the unit tests, we should just link against
everything we have built.
Please ignore this patch for now. V2 set coming soon...
/Bruce
next prev parent reply other threads:[~2023-09-28 9:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 9:26 Bruce Richardson
2023-09-28 9:36 ` [EXT] " Akhil Goyal
2023-09-28 9:45 ` David Marchand
2023-09-28 9:55 ` Bruce Richardson [this message]
2023-09-28 11:04 ` [PATCH 1/2] app/test: add support for optional dependencies Bruce Richardson
2023-09-28 11:04 ` [PATCH 2/2] app/test: make crypto scheduler an optional dependency Bruce Richardson
2023-09-28 12:50 ` [PATCH 1/2] app/test: add support for optional dependencies David Marchand
2023-09-28 13:06 ` [EXT] " Akhil Goyal
2023-09-28 14:42 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRVNo1zBALzs/y86@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).