From: "Mattias Rönnblom" <hofors@lysator.liu.se>
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Cc: jerinj@marvell.com
Subject: Re: [PATCH v3 2/9] eventdev: clarify all-types flag documentation
Date: Wed, 13 Dec 2023 14:20:19 +0100 [thread overview]
Message-ID: <ae16cd21-45c2-4dbb-8c42-5aaf453ef2d5@lysator.liu.se> (raw)
In-Reply-To: <20231212113223.31147-3-bruce.richardson@intel.com>
On 2023-12-12 12:32, Bruce Richardson wrote:
> Rather than requiring that any device advertising the
> RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES flag support all of atomic, ordered
> and parallel scheduling, we can redefine the field so that it basically
> means that you don't need to specify the queue scheduling type at config
> time. Instead all types of supported events can be sent to all queues.
>
> Suggested-by: Mattias Rönnblom <hofors@lysator.liu.se>
Please use <mattias.ronnblom@ericsson.com>.
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
> lib/eventdev/rte_eventdev.h | 17 ++++++++++++++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h
> index d48957362c..35865f017f 100644
> --- a/lib/eventdev/rte_eventdev.h
> +++ b/lib/eventdev/rte_eventdev.h
> @@ -250,11 +250,22 @@ struct rte_event;
> * @see rte_event_dequeue_burst()
> */
> #define RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES (1ULL << 3)
> -/**< Event device is capable of enqueuing events of any type to any queue.
> +/**< Event device is capable of accepting enqueued events, of any type
> + * advertised as supported by the device, to all destination queues.
> + *
> + * When this capability is set, the "schedule_type" field of the
> + * rte_event_queue_conf structure is ignored when a queue is being configured.
> + * Instead the the "sched_type" field of each event enqueued is used to
"The the" -> "the".
> + * select the scheduling to be performed on that event.
> + *
> * If this capability is not set, the queue only supports events of the
> - * *RTE_SCHED_TYPE_* type that it was created with.
> + * *RTE_SCHED_TYPE_* type specified in the rte_event_queue_conf structure
> + * at time of configuration.
> *
> - * @see RTE_SCHED_TYPE_* values
> + * @see RTE_SCHED_TYPE_ATOMIC
> + * @see RTE_SCHED_TYPE_ORDERED
> + * @see RTE_SCHED_TYPE_PARALLEL
> + * @see rte_event_queue_conf.schedule_type
> */
> #define RTE_EVENT_DEV_CAP_BURST_MODE (1ULL << 4)
> /**< Event device is capable of operating in burst mode for enqueue(forward,
next prev parent reply other threads:[~2023-12-13 13:20 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 17:25 [PATCH 24.03 0/8] document scheduling types for eventdev drivers Bruce Richardson
2023-11-20 17:25 ` [PATCH 24.03 1/8] eventdev: add capability flags for supported sched types Bruce Richardson
2023-11-20 17:48 ` Jerin Jacob
2023-11-20 17:52 ` Bruce Richardson
2023-11-21 9:30 ` Mattias Rönnblom
2023-11-21 9:46 ` Bruce Richardson
2023-11-21 11:12 ` Bruce Richardson
2023-11-21 17:08 ` Pathak, Pravin
2023-11-20 17:26 ` [PATCH 24.03 2/8] event/cnxk: add schedule-type capability flags Bruce Richardson
2023-11-20 17:26 ` [PATCH 24.03 3/8] event/dlb2: " Bruce Richardson
2023-11-20 22:45 ` Sevincer, Abdullah
2023-11-20 17:26 ` [PATCH 24.03 4/8] event/dpaa*: " Bruce Richardson
2023-11-21 10:51 ` Hemant Agrawal
2023-11-20 17:26 ` [PATCH 24.03 5/8] event/dsw: " Bruce Richardson
2023-11-21 9:30 ` Mattias Rönnblom
2023-11-21 9:32 ` Mattias Rönnblom
2023-11-21 9:44 ` Bruce Richardson
2023-11-21 9:47 ` Bruce Richardson
2023-11-20 17:26 ` [PATCH 24.03 6/8] event/octeontx: " Bruce Richardson
2023-11-20 17:26 ` [PATCH 24.03 7/8] event/opdl: " Bruce Richardson
2023-11-20 17:26 ` [PATCH 24.03 8/8] event/sw: " Bruce Richardson
2023-11-21 11:54 ` [PATCH 24.03 v2 0/9] document scheduling types for eventdev drivers Bruce Richardson
2023-11-21 11:54 ` [PATCH 24.03 v2 1/9] eventdev: add capability flags for supported sched types Bruce Richardson
2023-11-23 3:59 ` Jerin Jacob
2023-11-21 11:54 ` [PATCH 24.03 v2 2/9] eventdev: increase flexibility of all-types flag Bruce Richardson
2023-11-23 4:07 ` Jerin Jacob
2023-12-12 11:28 ` Bruce Richardson
2023-12-12 12:47 ` Jerin Jacob
2023-11-21 11:54 ` [PATCH 24.03 v2 3/9] event/cnxk: add schedule-type capability flags Bruce Richardson
2023-11-21 11:54 ` [PATCH 24.03 v2 4/9] event/dlb2: " Bruce Richardson
2023-11-21 11:54 ` [PATCH 24.03 v2 5/9] event/dpaa*: " Bruce Richardson
2023-11-21 11:54 ` [PATCH 24.03 v2 6/9] event/dsw: " Bruce Richardson
2023-11-21 11:54 ` [PATCH 24.03 v2 7/9] event/octeontx: " Bruce Richardson
2023-11-21 11:54 ` [PATCH 24.03 v2 8/9] event/opdl: " Bruce Richardson
2023-11-23 4:10 ` Jerin Jacob
2023-11-23 9:19 ` Bruce Richardson
2023-11-23 9:38 ` Jerin Jacob
2023-11-21 11:54 ` [PATCH 24.03 v2 9/9] event/sw: " Bruce Richardson
2023-12-12 11:32 ` [PATCH v3 0/9] document scheduling types for eventdev drivers Bruce Richardson
2023-12-12 11:32 ` [PATCH v3 1/9] eventdev: add capability flags for supported sched types Bruce Richardson
2023-12-12 11:32 ` [PATCH v3 2/9] eventdev: clarify all-types flag documentation Bruce Richardson
2023-12-13 12:50 ` Jerin Jacob
2023-12-13 13:20 ` Mattias Rönnblom [this message]
2023-12-12 11:32 ` [PATCH v3 3/9] event/cnxk: add schedule-type capability flags Bruce Richardson
2023-12-12 11:32 ` [PATCH v3 4/9] event/dlb2: " Bruce Richardson
2023-12-12 11:32 ` [PATCH v3 5/9] event/dpaa*: " Bruce Richardson
2023-12-12 11:32 ` [PATCH v3 6/9] event/dsw: " Bruce Richardson
2023-12-12 11:32 ` [PATCH v3 7/9] event/octeontx: " Bruce Richardson
2023-12-12 11:32 ` [PATCH v3 8/9] event/opdl: " Bruce Richardson
2023-12-12 11:32 ` [PATCH v3 9/9] event/sw: " Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae16cd21-45c2-4dbb-8c42-5aaf453ef2d5@lysator.liu.se \
--to=hofors@lysator.liu.se \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).