From: Akhil Goyal <akhil.goyal@nxp.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Doherty, Declan" <declan.doherty@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"Nicolau, Radu" <radu.nicolau@intel.com>,
"aviadye@mellanox.com" <aviadye@mellanox.com>,
"borisp@mellanox.com" <borisp@mellanox.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>
Cc: "shahafs@mellanox.com" <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v2] doc: announce ABI change for cryptodev and ethdev
Date: Tue, 8 Aug 2017 14:12:08 +0530 [thread overview]
Message-ID: <caad9613-b30a-cb8f-92d1-f48b885f7111@nxp.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CBE9F9E@IRSMSX108.ger.corp.intel.com>
Hi Pablo,
On 8/8/2017 1:38 PM, De Lara Guarch, Pablo wrote:
> Hi Akhil,
>
>> -----Original Message-----
>> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
>> Sent: Tuesday, August 8, 2017 8:10 AM
>> To: dev@dpdk.org; Doherty, Declan <declan.doherty@intel.com>;
>> thomas@monjalon.net; Nicolau, Radu <radu.nicolau@intel.com>;
>> aviadye@mellanox.com; borisp@mellanox.com;
>> hemant.agrawal@nxp.com; De Lara Guarch, Pablo
>> <pablo.de.lara.guarch@intel.com>
>> Cc: shahafs@mellanox.com; Akhil Goyal <akhil.goyal@nxp.com>
>> Subject: [PATCH v2] doc: announce ABI change for cryptodev and ethdev
>>
>> Support for security operations is planned to be added in ethdev and
>> cryptodev for the 17.11 release.
>>
>> For this following changes are required.
>> - rte_cryptodev and rte_eth_dev structures need to be added new
>> parameter rte_security_ops which extend support for security ops to the
>> corresponding driver.
>> - rte_cryptodev_info and rte_eth_dev_info need to be added with
>> rte_security_capabilities to identify the capabilities of the corresponding
>> driver.
>> - rte_security_session needs to be added in the union inside structure
>> rte_crypto_sym_op to decide between various types of sessions
>>
>> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
>> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> Acked-by: Boris Pismenny <borisp@mellanox.com>
>> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
>> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>> ---
>> changes in v2:
>> Added one more ABI change wrt to security session, This patch is not split
>> into 3 patches as these all will be implemented simultaneously with
>> rte_security support.
>>
>> doc/guides/rel_notes/deprecation.rst | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst
>> b/doc/guides/rel_notes/deprecation.rst
>> index 72d1f35..e34a809 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -78,3 +78,18 @@ Deprecation Notices
>> be removed in 17.11:
>>
>> - ``rte_cryptodev_create_vdev``
>> +
>> +* cryptodev: new parameters - ``rte_security_capabilities`` and
>> + ``rte_security_ops`` will be added to ``rte_cryptodev_info`` and
>> + ``rte_cryptodev`` respectively to support security protocol offloaded
>> + operations.
>> +
>> +* cryptodev: new parameter ``rte_security_session`` will be added in
>> +the union
>> + of the structure ``rte_crypto_sym_op``, so that the user can choose
>> +either to
>> + use ``rte_cryptodev_sym_session`` or ``rte_crypto_sym_xform`` or
>> + ``rte_security_session``.
>
> I don't think it is required to have a deprecation notice for this, as it is adding
> another element in a union, and it is not changing its size.
> However, this would require an addition in rte_crypto_op_sess_type, which,
> as long as it is added at the end, should not require a deprecation notice.
>
> About splitting this into two patches, I would do it, as I believe deprecation notices
> should target a specific library.
>
>
>
Thanks for the comments. I have marked the v2 as not applicable and
marked v1 as in review in the patchwork.
-Akhil
prev parent reply other threads:[~2017-08-08 8:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 15:32 [dpdk-dev] [PATCH] " Akhil Goyal
2017-08-04 5:26 ` Hemant Agrawal
2017-08-07 17:41 ` Thomas Monjalon
2017-08-07 18:07 ` Boris Pismenny
2017-08-08 5:03 ` Shahaf Shuler
2017-08-08 10:00 ` Thomas Monjalon
2017-08-04 9:28 ` De Lara Guarch, Pablo
2017-08-04 15:25 ` De Lara Guarch, Pablo
2017-08-08 6:54 ` Akhil Goyal
2017-08-08 7:09 ` [dpdk-dev] [PATCH v2] " Akhil Goyal
2017-08-08 8:08 ` De Lara Guarch, Pablo
2017-08-08 8:42 ` Akhil Goyal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=caad9613-b30a-cb8f-92d1-f48b885f7111@nxp.com \
--to=akhil.goyal@nxp.com \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=radu.nicolau@intel.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).