From: "Charles (Chas) Williams" <ciwillia@brocade.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: <dev@dpdk.org>, <mtetsuyah@gmail.com>
Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/vhost: create datagram sockets immediately
Date: Tue, 3 Jan 2017 08:52:48 -0500 [thread overview]
Message-ID: <d671f286-29ab-939c-9960-38041707387f@brocade.com> (raw)
In-Reply-To: <20170103082215.GC21228@yliu-dev.sh.intel.com>
On 01/03/2017 03:22 AM, Yuanhan Liu wrote:
> On Sun, Jan 01, 2017 at 02:01:56PM -0500, Charles (Chas) Williams wrote:
>> If you create a vhost server device, it doesn't create the actual datagram
>> socket until you call .dev_start(). If you call .dev_stop() is also
>> deletes those sockets. For QEMU clients, this is a problem since QEMU
>> doesn't know how to re-attach to datagram sockets that have gone away.
>>
>> To work around this, register and unregister the datagram sockets during
>
> I will not call it's a "workaround", instead, it's a "fix" to me.
OK.
>> device creation and removal.
>>
>> Fixes: ee584e9710b9 ("vhost: add driver on top of the library")
>>
>> Signed-off-by: Chas Williams <ciwillia@brocade.com>
>> ---
>> drivers/net/vhost/rte_eth_vhost.c | 43 ++++++++++++++++-----------------------
>> 1 file changed, 17 insertions(+), 26 deletions(-)
>>
>> diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
>> index 60b0f51..6b11e40 100644
>> --- a/drivers/net/vhost/rte_eth_vhost.c
>> +++ b/drivers/net/vhost/rte_eth_vhost.c
>> @@ -114,8 +114,6 @@ struct pmd_internal {
>> char *iface_name;
>> uint16_t max_queues;
>> uint64_t flags;
>
> I think the "flags" could also be dropped in this patch: no user any
> more.
Sorry, I hadn't noticed that -- Yes, it can go away.
prev parent reply other threads:[~2017-01-03 13:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-01 19:01 Charles (Chas) Williams
2017-01-01 19:01 ` [dpdk-dev] [PATCH v3 2/2] net/vhost: emulate device start/stop behavior Charles (Chas) Williams
2017-01-03 8:29 ` Yuanhan Liu
2017-01-03 8:22 ` [dpdk-dev] [PATCH v3 1/2] net/vhost: create datagram sockets immediately Yuanhan Liu
2017-01-03 13:52 ` Charles (Chas) Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d671f286-29ab-939c-9960-38041707387f@brocade.com \
--to=ciwillia@brocade.com \
--cc=dev@dpdk.org \
--cc=mtetsuyah@gmail.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).