From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Shahaf Shuler <shahafs@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 01/39] examples/l2fwd: convert to new ethdev offloads API
Date: Mon, 15 Jan 2018 11:34:03 +0000 [thread overview]
Message-ID: <d82f1616-706a-187c-2c3a-94f2f33fe3d2@intel.com> (raw)
In-Reply-To: <VI1PR05MB31490493470DE7D950C5420DC3EB0@VI1PR05MB3149.eurprd05.prod.outlook.com>
On 1/15/2018 11:02 AM, Shahaf Shuler wrote:
> Monday, January 15, 2018 12:21 PM, Ferruh Yigit:
>>> I think all of the 3 should be in a single patch.
>>> The reason is that the convert patch should maintain the same offloads
>> configuration needed for the application.
>>
>> Perhaps I am missing some details about "mbuf fast free" offload, can you
>> please give more details about it, what does having or not having it mean?
>> Currently no PMD seems implemented it.
>
> Sure,
>
> FAST_FREE offload is the logical AND between the old txqflags of:
> ETH_TXQ_FLAGS_NOREFCOUNT
> ETH_TXQ_FLAGS_NOMULTMEM
>
> The offload is just a performance optimization. As specified in the documentation [1] it enables the PMDs to further optimize the data path given the guarantees from the application.
> Not having it means possible performance degradation for some PMD which rely on it.
>
> There is no PMD which implement it yet since not all PMDs moved to the new offloads API. However this flag is tested and translated into txqflags as part of rte_eth_convert_txq_offloads function.
> Relevant PMDs for this offload will be: sfc, thunderx and i40e.
Thank you for clarification, I am OK to have it.
But since currently no PMD provide "DEV_TX_OFFLOAD_MBUF_FAST_FREE" capability,
and default txq_flags is overwritten, some PMDs lost this optimization until
they implement new capability, right?
>
>
> [1]
> /**< Device supports optimization for fast release of mbufs.
> * When set application must guarantee that per-queue all mbufs comes from
> * the same mempool and has refcnt = 1.
> */
>
>>
>>> Before the convert patch the examples were using the default
>> configuration set by the PMD. In there the txq flags were set to ignore ref
>> count and to declare all mbufs are from the same pool.
>>> The fast free Tx offload was added in order to keep this old offloads
>> configuration.
>>>
>>>>
>>>> Wouldn't be better to enable new offloadings in a separate patch,
>>>> other than convert one? And I don't know if we want to enable that
>>>> specific offload for all samples.
>>>
>>> As you can see, not all the examples has the FAST_FREE offloads, only the
>> entitled ones (i.e. single mempool and no ref count).
>>> For example, ipv4_multicast doesn't set this offload flag.
>>>
>
next prev parent reply other threads:[~2018-01-15 11:34 UTC|newest]
Thread overview: 134+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 12:14 [dpdk-dev] [PATCH 00/39] convert examples " Shahaf Shuler
2017-11-23 12:14 ` [dpdk-dev] [PATCH 01/39] examples/l2fwd: convert " Shahaf Shuler
2017-11-24 15:00 ` Andrew Rybchenko
2017-11-26 7:41 ` Shahaf Shuler
2017-11-27 6:34 ` Andrew Rybchenko
2017-11-27 7:03 ` Shahaf Shuler
2017-11-27 7:33 ` Jerin Jacob
2017-11-27 19:41 ` Shahaf Shuler
2017-11-27 7:40 ` Andrew Rybchenko
2017-11-23 12:14 ` [dpdk-dev] [PATCH 02/39] examples/l2fwd-crypto: " Shahaf Shuler
2017-11-23 12:14 ` [dpdk-dev] [PATCH 03/39] examples/l2fwd-jobstats: " Shahaf Shuler
2017-11-23 12:14 ` [dpdk-dev] [PATCH 04/39] examples/l2fwd-keepalive: " Shahaf Shuler
2017-11-23 12:14 ` [dpdk-dev] [PATCH 05/39] examples/l3fwd: move to " Shahaf Shuler
2017-11-23 12:14 ` [dpdk-dev] [PATCH 06/39] examples/l3fwd-acl: convert to new " Shahaf Shuler
2017-12-11 14:48 ` Ananyev, Konstantin
2017-11-23 12:14 ` [dpdk-dev] [PATCH 07/39] examples/l3fwd-power: " Shahaf Shuler
2017-12-11 14:00 ` Hunt, David
2017-11-23 12:14 ` [dpdk-dev] [PATCH 08/39] examples/l3fwd-vf: " Shahaf Shuler
2017-11-23 12:14 ` [dpdk-dev] [PATCH 09/39] examples/bond: " Shahaf Shuler
2017-12-11 11:08 ` Radu Nicolau
2017-12-04 12:12 ` [dpdk-dev] [PATCH 00/39] convert examples " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 01/39] examples/l2fwd: convert " Shahaf Shuler
2017-12-19 12:16 ` De Lara Guarch, Pablo
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 02/39] examples/l2fwd-crypto: " Shahaf Shuler
2017-12-19 12:18 ` De Lara Guarch, Pablo
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 03/39] examples/l2fwd-jobstats: " Shahaf Shuler
2017-12-19 12:33 ` De Lara Guarch, Pablo
2017-12-21 13:47 ` Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 04/39] examples/l2fwd-keepalive: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 05/39] examples/l3fwd: move to " Shahaf Shuler
2017-12-12 17:12 ` Ananyev, Konstantin
2017-12-13 7:21 ` Shahaf Shuler
2017-12-13 7:55 ` Jerin Jacob
2017-12-13 12:10 ` Ananyev, Konstantin
2017-12-13 17:32 ` Jerin Jacob
2017-12-21 14:26 ` Shahaf Shuler
2017-12-18 16:00 ` Maciej Czekaj
2017-12-21 14:08 ` Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 06/39] examples/l3fwd-acl: convert to new " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 07/39] examples/l3fwd-power: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 08/39] examples/l3fwd-vf: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 09/39] examples/bond: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 10/39] examples/exception_path: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 11/39] examples/kni: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 12/39] examples/ip_fragmentation: convert to new " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 13/39] examples/ip_pipeline: convert to new ethdev " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 14/39] examples/ip_reassembly: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 15/39] examples/ipsec-secgw: " Shahaf Shuler
2017-12-19 12:38 ` De Lara Guarch, Pablo
2017-12-21 13:45 ` Shahaf Shuler
2018-01-08 16:27 ` De Lara Guarch, Pablo
2018-01-09 7:07 ` Akhil Goyal
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 16/39] examples/ipv4_multicast: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 17/39] examples/link_status_interrupt: convert to new " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 18/39] examples/load_balancer: convert to new ethdev " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 19/39] examples/multi_process: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 20/39] examples/netmap_compat: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 21/39] examples/performance-thread: convert to new " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 22/39] examples/qos_meter: convert to new ethdev " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 23/39] examples/qos_sched: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 24/39] examples/quota_watermark: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 25/39] examples/tep_termination: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 26/39] examples/vhost: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 27/39] examples/vmdq: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 28/39] examples/vmdq_dcb: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 29/39] examples/vm_power_manager: convert to new " Shahaf Shuler
2017-12-12 12:35 ` [dpdk-dev] [PATCH v2 30/39] examples/distributor: convert to new ethdev " Shahaf Shuler
2017-12-12 12:35 ` [dpdk-dev] [PATCH v2 31/39] examples/ethtool: " Shahaf Shuler
2017-12-12 12:35 ` [dpdk-dev] [PATCH v2 32/39] examples/eventdev_pipeline: convert to new " Shahaf Shuler
2017-12-15 15:20 ` Van Haaren, Harry
2017-12-12 12:35 ` [dpdk-dev] [PATCH v2 33/39] examples/flow_classify: convert to new ethdev " Shahaf Shuler
2017-12-12 12:35 ` [dpdk-dev] [PATCH v2 34/39] examples/flow_filtering: " Shahaf Shuler
2017-12-12 12:35 ` [dpdk-dev] [PATCH v2 35/39] examples/packet_ordering: " Shahaf Shuler
2017-12-12 12:35 ` [dpdk-dev] [PATCH v2 36/39] examples/ptpclient: " Shahaf Shuler
2017-12-12 12:35 ` [dpdk-dev] [PATCH v2 37/39] examples/rxtx_callbacks: " Shahaf Shuler
2017-12-12 12:35 ` [dpdk-dev] [PATCH v2 38/39] examples/server_node_efd: " Shahaf Shuler
2017-12-12 12:35 ` [dpdk-dev] [PATCH v2 39/39] examples/skeleton: " Shahaf Shuler
2017-12-26 9:22 ` [dpdk-dev] [PATCH v3 00/39] convert examples " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 01/39] examples/l2fwd: convert " Shahaf Shuler
2018-01-10 12:12 ` De Lara Guarch, Pablo
2018-01-12 13:30 ` Ferruh Yigit
2018-01-14 10:37 ` Shahaf Shuler
2018-01-15 10:20 ` Ferruh Yigit
2018-01-15 11:02 ` Shahaf Shuler
2018-01-15 11:34 ` Ferruh Yigit [this message]
2018-01-15 11:41 ` Shahaf Shuler
2018-01-15 11:56 ` Ferruh Yigit
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 02/39] examples/l2fwd-crypto: " Shahaf Shuler
2018-01-10 12:12 ` De Lara Guarch, Pablo
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 03/39] examples/l2fwd-jobstats: " Shahaf Shuler
2018-01-10 12:13 ` De Lara Guarch, Pablo
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 04/39] examples/l2fwd-keepalive: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 05/39] examples/l3fwd: convert to " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 06/39] examples/l3fwd-acl: convert to new " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 07/39] examples/l3fwd-power: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 08/39] examples/l3fwd-vf: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 09/39] examples/bond: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 10/39] examples/exception_path: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 11/39] examples/kni: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 12/39] examples/ip_fragmentation: convert to new " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 13/39] examples/ip_pipeline: convert to new ethdev " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 14/39] examples/ip_reassembly: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 15/39] examples/ipsec-secgw: " Shahaf Shuler
2018-01-16 11:10 ` Nicolau, Radu
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 16/39] examples/ipv4_multicast: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 17/39] examples/link_status_interrupt: convert to new " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 18/39] examples/load_balancer: convert to new ethdev " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 19/39] examples/multi_process: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 20/39] examples/netmap_compat: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 21/39] examples/performance-thread: convert to new " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 22/39] examples/qos_meter: convert to new ethdev " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 23/39] examples/qos_sched: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 24/39] examples/quota_watermark: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 25/39] examples/tep_termination: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 26/39] examples/vhost: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 27/39] examples/vmdq: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 28/39] examples/vmdq_dcb: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 29/39] examples/vm_power_manager: convert to new " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 30/39] examples/distributor: convert to new ethdev " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 31/39] examples/ethtool: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 32/39] examples/eventdev_pipeline: convert to new " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 33/39] examples/flow_classify: convert to new ethdev " Shahaf Shuler
2018-01-03 15:09 ` Iremonger, Bernard
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 34/39] examples/flow_filtering: " Shahaf Shuler
2017-12-26 13:57 ` Ori Kam
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 35/39] examples/packet_ordering: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 36/39] examples/ptpclient: " Shahaf Shuler
2018-01-10 12:14 ` De Lara Guarch, Pablo
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 37/39] examples/rxtx_callbacks: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 38/39] examples/server_node_efd: " Shahaf Shuler
2018-01-10 12:15 ` De Lara Guarch, Pablo
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 39/39] examples/skeleton: " Shahaf Shuler
2018-01-16 16:25 ` [dpdk-dev] [PATCH v3 00/39] convert examples " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d82f1616-706a-187c-2c3a-94f2f33fe3d2@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).