[dpdk-dev] [PATCH] net/i40e: revert fix FDIR check programming ret error

[dpdk-dev] [PATCH] net/i40e: revert fix FDIR check programming ret error

[Wei Zhao]

This reverts commit 7546dc4a1331340ecb665af9af0a005bb8b657c8.

In i40e FDIR PMD code for checking programming status,
when the action of add FDIR filter is ok, i40e NIC will
not write back to programming status descriptor, so if
PMD code check DD is not done after period of time dealy,
it means the add or remove filter action is ok. It only write
back descriptor when fail. So, there is no issue for the orignal
code.

Fixes: 7546dc4a1331 ("net/i40e: fix FDIR check programming status error")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
 drivers/net/i40e/i40e_fdir.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c
index 2b299c7..d41601a 100644
--- a/drivers/net/i40e/i40e_fdir.c
+++ b/drivers/net/i40e/i40e_fdir.c
@@ -1360,8 +1360,6 @@ i40e_check_fdir_programming_status(struct i40e_rx_queue *rxq)
 			I40E_PCI_REG_WRITE(rxq->qrx_tail, rxq->nb_rx_desc - 1);
 		else
 			I40E_PCI_REG_WRITE(rxq->qrx_tail, rxq->rx_tail - 1);
-	} else {
-		ret = -1;
 	}
 
 	return ret;
-- 
2.7.5

[dpdk-dev] [PATCH v2] net/i40e: revert fix FDIR check programming ret error

[Wei Zhao]

This reverts commit 7546dc4a1331340ecb665af9af0a005bb8b657c8.

In i40e FDIR PMD code for checking programming status,
when the action of add FDIR filter is ok, i40e NIC will
not write back to programming status descriptor, so if
PMD code check DD is not done after period of time dealy,
it means the add or remove filter action is ok. It only write
back descriptor when fail. So, there is no issue for the original
code.

Fixes: 7546dc4a1331 ("net/i40e: fix FDIR check programming status error")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>

---

v2:
-fix commit log warning in v1.
---
 drivers/net/i40e/i40e_fdir.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c
index 2b299c7..d41601a 100644
--- a/drivers/net/i40e/i40e_fdir.c
+++ b/drivers/net/i40e/i40e_fdir.c
@@ -1360,8 +1360,6 @@ i40e_check_fdir_programming_status(struct i40e_rx_queue *rxq)
 			I40E_PCI_REG_WRITE(rxq->qrx_tail, rxq->nb_rx_desc - 1);
 		else
 			I40E_PCI_REG_WRITE(rxq->qrx_tail, rxq->rx_tail - 1);
-	} else {
-		ret = -1;
 	}
 
 	return ret;
-- 
2.7.5

Re: [dpdk-dev] [PATCH v2] net/i40e: revert fix FDIR check programming ret error

[Zhang, Qi Z]

> -----Original Message-----
> From: Zhao1, Wei
> Sent: Wednesday, August 1, 2018 10:55 AM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH v2] net/i40e: revert fix FDIR check programming ret error
> 
> This reverts commit 7546dc4a1331340ecb665af9af0a005bb8b657c8.
> 
> In i40e FDIR PMD code for checking programming status, when the action of
> add FDIR filter is ok, i40e NIC will not write back to programming status
> descriptor, so if PMD code check DD is not done after period of time dealy, it
> means the add or remove filter action is ok. It only write back descriptor
> when fail. So, there is no issue for the original code.
> 
> Fixes: 7546dc4a1331 ("net/i40e: fix FDIR check programming status error")

Removed fix line.

> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi