From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
Stephen Hemminger <stephen@networkplumber.org>,
"Xing, Beilei" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: remove queue_stats_mapping_set
Date: Tue, 18 Jun 2019 14:09:03 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611533A7D0A@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <67975a53-a95c-912a-02d0-f6507d1deb62@redhat.com>
> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> Sent: Wednesday, May 29, 2019 5:12 PM
> To: Stephen Hemminger <stephen@networkplumber.org>; Xing, Beilei
> <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: remove queue_stats_mapping_set
>
>
>
> On 5/28/19 9:43 PM, Stephen Hemminger wrote:
> > This driver was inserting its own stub for queue_stats_mapping which
> > did nothing but cause this device to return a different errno than
> > every other device driver. All devices that don't implement queue
> > stats mapping should return the same error.
> >
> > Maybe the plan originally was to implement something, if that ever
> > happens, just put in the right code.
> >
> > Fixes: 4861cde46116 ("i40e: new poll mode driver")
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> > drivers/net/i40e/i40e_ethdev.c | 16 ----------------
> > 1 file changed, 16 deletions(-)
> >
>
>
> Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
prev parent reply other threads:[~2019-06-18 14:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 19:43 Stephen Hemminger
2019-05-29 9:11 ` Maxime Coquelin
2019-06-18 14:09 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E70611533A7D0A@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).