From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>, "Guo, Jia" <jia.guo@intel.com>
Cc: "bmcfall@redhat.com" <bmcfall@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] net/e1000: fix segfault on tx done clean up
Date: Tue, 21 Jul 2020 05:40:22 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611548630CA@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <MWHPR11MB139178BAD8C2A3D496E64C1CB77F0@MWHPR11MB1391.namprd11.prod.outlook.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Zhao1, Wei
> Sent: Thursday, July 16, 2020 5:16 PM
> To: Guo, Jia <jia.guo@intel.com>
> Cc: bmcfall@redhat.com; dev@dpdk.org
> Subject: Re: [dpdk-dev] net/e1000: fix segfault on tx done clean up
>
>
> Reviewed-by: Wei Zhao <wei.zhao1@intel.com>
>
> > -----Original Message-----
> > From: Guo, Jia <jia.guo@intel.com>
> > Sent: Thursday, July 16, 2020 4:54 PM
> > To: Zhao1, Wei <wei.zhao1@intel.com>
> > Cc: bmcfall@redhat.com; dev@dpdk.org; Guo, Jia <jia.guo@intel.com>
> > Subject: [dpdk-dev] net/e1000: fix segfault on tx done clean up
> >
> > As tx mbuf is not set for some advanced descriptors, if there is no
> > mbuf checking before rte_pktmbuf_free_seg() function be called on the
> > process of tx done clean up, that will cause a segfault. So add a NULL pointer
> check to fix it.
> >
> > Bugzilla ID: 501
> > Fixes: 8d907d2b79f7 (net/igb: free consumed Tx buffers on demand)
> >
> > Signed-off-by: Jeff Guo <jia.guo@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
next prev parent reply other threads:[~2020-07-21 5:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 8:53 Jeff Guo
2020-07-16 9:15 ` Zhao1, Wei
2020-07-21 5:40 ` Zhang, Qi Z [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-07-16 8:50 Jeff Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E70611548630CA@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=bmcfall@redhat.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).