Re: [dpdk-dev] [EXT] [PATCH] cryptodev: extend api of asymmetric crypto by sessionless

["Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>]

> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Friday, June 14, 2019 12:21 PM
> To: 'Shally Verma' <shallyv@marvell.com>; dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>;
> shally.verma@caviumnetworks.com
> Subject: RE: [EXT] [PATCH] cryptodev: extend api of asymmetric crypto by
> sessionless
> 
> Hi Shally,
> 
> Thanks for your feedback.
> 
> > -----Original Message-----
> > From: Shally Verma [mailto:shallyv@marvell.com]
> > Sent: Wednesday, June 5, 2019 2:17 PM
> > To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> > Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>;
> > shally.verma@caviumnetworks.com
> > Subject: RE: [EXT] [PATCH] cryptodev: extend api of asymmetric crypto
> > by sessionless
> >
> >
> >
> > > -----Original Message-----
> > > From: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > > Sent: Tuesday, June 4, 2019 1:14 AM
> > > To: dev@dpdk.org
> > > Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com;
> > > shally.verma@caviumnetworks.com; Arek Kusztal
> > > <arkadiuszx.kusztal@intel.com>
> > > Subject: [EXT] [PATCH] cryptodev: extend api of asymmetric crypto by
> > > sessionless
> > >
> > > External Email
> > >
> > > --------------------------------------------------------------------
> > > -- Asymmetric cryptography algorithms may more likely use
> > > sessionless API so there is need to extend API.
> > >
> > > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > > ---
> > >  lib/librte_cryptodev/rte_crypto_asym.h | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/lib/librte_cryptodev/rte_crypto_asym.h
> > > b/lib/librte_cryptodev/rte_crypto_asym.h
> > > index 8672f21..5d69692 100644
> > > --- a/lib/librte_cryptodev/rte_crypto_asym.h
> > > +++ b/lib/librte_cryptodev/rte_crypto_asym.h
> > > @@ -503,6 +503,8 @@ struct rte_crypto_dsa_op_param {  struct
> > > rte_crypto_asym_op {
> > >  	struct rte_cryptodev_asym_session *session;
> > >  	/**< Handle for the initialised session context */
> > > +	struct rte_crypto_asym_xform *xform;
> > > +	/**< Session-less API crypto operation parameters */
> >
> > [Shally] Ack to this change. But is this all that is needed to support
> > sessionless? Do you have working poc with sessionless?
> >
> 
> [AK]
> xform holds to get working. Crypto_op holds sess_type From our side for
> now we not intend to store any user information in session at all.
> For sure not private keys, any other information is small enough comparing
> to asymmetric crypto computation time that it has no gain to allocate session
> for it.
> 
[AK] Sorry, I had to fix bad writing.
rte_crypto_asym_xform holds enough information, and rte_crypto_op holds sess_type.
> 
> > Thanks
> > Shally
> >
> > >
> > >  	__extension__
> > >  	union {
> > > --
> > > 2.7.4