* [dpdk-dev] [PATCH] lib/librte_ethdev: expand queue threshold size of RED parameters
@ 2018-08-16 1:14 Rosen Xu
2018-08-16 8:51 ` Dumitrescu, Cristian
2018-10-08 15:59 ` Dumitrescu, Cristian
0 siblings, 2 replies; 4+ messages in thread
From: Rosen Xu @ 2018-08-16 1:14 UTC (permalink / raw)
To: dev
Cc: cristian.dumitrescu, wenzhuo.lu, jasvinder.singh, jerin.jacob,
rosen.xu, ferruh.yigit
There's very commonly that more than 4G DDR memory in NIC for HQoS,
so right now the queue threshold size of RED needs to expand to
uint64_t. This patch fixes it.
Signed-off-by: Rosen Xu <rosen.xu@intel.com>
---
lib/librte_ethdev/rte_tm.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_ethdev/rte_tm.h b/lib/librte_ethdev/rte_tm.h
index 955f02f..646ef38 100644
--- a/lib/librte_ethdev/rte_tm.h
+++ b/lib/librte_ethdev/rte_tm.h
@@ -831,10 +831,10 @@ enum rte_tm_cman_mode {
*/
struct rte_tm_red_params {
/** Minimum queue threshold */
- uint32_t min_th;
+ uint64_t min_th;
/** Maximum queue threshold */
- uint32_t max_th;
+ uint64_t max_th;
/** Inverse of packet marking probability maximum value (maxp), i.e.
* maxp_inv = 1 / maxp
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] lib/librte_ethdev: expand queue threshold size of RED parameters
2018-08-16 1:14 [dpdk-dev] [PATCH] lib/librte_ethdev: expand queue threshold size of RED parameters Rosen Xu
@ 2018-08-16 8:51 ` Dumitrescu, Cristian
2018-10-08 15:59 ` Dumitrescu, Cristian
1 sibling, 0 replies; 4+ messages in thread
From: Dumitrescu, Cristian @ 2018-08-16 8:51 UTC (permalink / raw)
To: Xu, Rosen, dev; +Cc: Lu, Wenzhuo, Singh, Jasvinder, jerin.jacob, Yigit, Ferruh
> -----Original Message-----
> From: Xu, Rosen
> Sent: Thursday, August 16, 2018 2:14 AM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>; Singh, Jasvinder <jasvinder.singh@intel.com>;
> jerin.jacob@caviumnetworks.com; Xu, Rosen <rosen.xu@intel.com>; Yigit,
> Ferruh <ferruh.yigit@intel.com>
> Subject: [PATCH] lib/librte_ethdev: expand queue threshold size of RED
> parameters
>
> There's very commonly that more than 4G DDR memory in NIC for HQoS,
> so right now the queue threshold size of RED needs to expand to
> uint64_t. This patch fixes it.
>
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> ---
> lib/librte_ethdev/rte_tm.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_ethdev/rte_tm.h b/lib/librte_ethdev/rte_tm.h
> index 955f02f..646ef38 100644
> --- a/lib/librte_ethdev/rte_tm.h
> +++ b/lib/librte_ethdev/rte_tm.h
> @@ -831,10 +831,10 @@ enum rte_tm_cman_mode {
> */
> struct rte_tm_red_params {
> /** Minimum queue threshold */
> - uint32_t min_th;
> + uint64_t min_th;
>
> /** Maximum queue threshold */
> - uint32_t max_th;
> + uint64_t max_th;
>
> /** Inverse of packet marking probability maximum value (maxp),
> i.e.
> * maxp_inv = 1 / maxp
> --
> 1.8.3.1
Did you also check that this change does not break any drivers that are currently using the ethdev TM API?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] lib/librte_ethdev: expand queue threshold size of RED parameters
2018-08-16 1:14 [dpdk-dev] [PATCH] lib/librte_ethdev: expand queue threshold size of RED parameters Rosen Xu
2018-08-16 8:51 ` Dumitrescu, Cristian
@ 2018-10-08 15:59 ` Dumitrescu, Cristian
2018-10-09 0:02 ` Xu, Rosen
1 sibling, 1 reply; 4+ messages in thread
From: Dumitrescu, Cristian @ 2018-10-08 15:59 UTC (permalink / raw)
To: Xu, Rosen, dev; +Cc: Lu, Wenzhuo, Singh, Jasvinder, jerin.jacob, Yigit, Ferruh
> -----Original Message-----
> From: Xu, Rosen
> Sent: Thursday, August 16, 2018 2:14 AM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>; Singh, Jasvinder <jasvinder.singh@intel.com>;
> jerin.jacob@caviumnetworks.com; Xu, Rosen <rosen.xu@intel.com>; Yigit,
> Ferruh <ferruh.yigit@intel.com>
> Subject: [PATCH] lib/librte_ethdev: expand queue threshold size of RED
> parameters
>
> There's very commonly that more than 4G DDR memory in NIC for HQoS,
> so right now the queue threshold size of RED needs to expand to
> uint64_t. This patch fixes it.
>
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> ---
> lib/librte_ethdev/rte_tm.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_ethdev/rte_tm.h b/lib/librte_ethdev/rte_tm.h
> index 955f02f..646ef38 100644
> --- a/lib/librte_ethdev/rte_tm.h
> +++ b/lib/librte_ethdev/rte_tm.h
> @@ -831,10 +831,10 @@ enum rte_tm_cman_mode {
> */
> struct rte_tm_red_params {
> /** Minimum queue threshold */
> - uint32_t min_th;
> + uint64_t min_th;
>
> /** Maximum queue threshold */
> - uint32_t max_th;
> + uint64_t max_th;
>
> /** Inverse of packet marking probability maximum value (maxp),
> i.e.
> * maxp_inv = 1 / maxp
> --
> 1.8.3.1
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied to next-qos tree, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] lib/librte_ethdev: expand queue threshold size of RED parameters
2018-10-08 15:59 ` Dumitrescu, Cristian
@ 2018-10-09 0:02 ` Xu, Rosen
0 siblings, 0 replies; 4+ messages in thread
From: Xu, Rosen @ 2018-10-09 0:02 UTC (permalink / raw)
To: Dumitrescu, Cristian, dev
Cc: Lu, Wenzhuo, Singh, Jasvinder, jerin.jacob, Yigit, Ferruh
> -----Original Message-----
> From: Dumitrescu, Cristian
> Sent: Tuesday, October 09, 2018 0:00
> To: Xu, Rosen <rosen.xu@intel.com>; dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>; jerin.jacob@caviumnetworks.com; Yigit,
> Ferruh <ferruh.yigit@intel.com>
> Subject: RE: [PATCH] lib/librte_ethdev: expand queue threshold size of RED
> parameters
>
>
>
> > -----Original Message-----
> > From: Xu, Rosen
> > Sent: Thursday, August 16, 2018 2:14 AM
> > To: dev@dpdk.org
> > Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Lu, Wenzhuo
> > <wenzhuo.lu@intel.com>; Singh, Jasvinder <jasvinder.singh@intel.com>;
> > jerin.jacob@caviumnetworks.com; Xu, Rosen <rosen.xu@intel.com>; Yigit,
> > Ferruh <ferruh.yigit@intel.com>
> > Subject: [PATCH] lib/librte_ethdev: expand queue threshold size of RED
> > parameters
> >
> > There's very commonly that more than 4G DDR memory in NIC for HQoS,
> so
> > right now the queue threshold size of RED needs to expand to uint64_t.
> > This patch fixes it.
> >
> > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> > ---
> > lib/librte_ethdev/rte_tm.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/librte_ethdev/rte_tm.h b/lib/librte_ethdev/rte_tm.h
> > index 955f02f..646ef38 100644
> > --- a/lib/librte_ethdev/rte_tm.h
> > +++ b/lib/librte_ethdev/rte_tm.h
> > @@ -831,10 +831,10 @@ enum rte_tm_cman_mode {
> > */
> > struct rte_tm_red_params {
> > /** Minimum queue threshold */
> > - uint32_t min_th;
> > + uint64_t min_th;
> >
> > /** Maximum queue threshold */
> > - uint32_t max_th;
> > + uint64_t max_th;
> >
> > /** Inverse of packet marking probability maximum value (maxp), i.e.
> > * maxp_inv = 1 / maxp
> > --
> > 1.8.3.1
>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>
> Applied to next-qos tree, thanks!
Okay, thanks a lot Cristian.
What means nex-qos tree? 18.11?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-09 0:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-16 1:14 [dpdk-dev] [PATCH] lib/librte_ethdev: expand queue threshold size of RED parameters Rosen Xu
2018-08-16 8:51 ` Dumitrescu, Cristian
2018-10-08 15:59 ` Dumitrescu, Cristian
2018-10-09 0:02 ` Xu, Rosen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).