From: "Zhangkun (K)" <zhang.zhangkun@huawei.com>
To: "Zhang, Helin" <helin.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: [dpdk-dev] 答复: [PATCH] there are some memory leak about Dir operator
Date: Tue, 19 Aug 2014 06:10:38 +0000 [thread overview]
Message-ID: <0FCB215400789046A95ECE23C3E46C515F956183@szxema505-mbx.china.huawei.com> (raw)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A77F3DE@SHSMSX104.ccr.corp.intel.com>
Hi, Helin
This is no problem with the OS dealing with resource recovery during process exiting. However,I consider the following principles.
1.The function internally allocated memory is returned before releasing memory resources to prevent the caller did not release the cause memory leaks;
2.The function should be obviously allocated and released memory. It is best not to recover from the os, otherwise relatively poor readability;
3.In some scenarios the dpdk as part of the component is running in the background. The dpdk application happen error when try not to lead to the whole process of exit, only affects the part of the function fails;
----- Original Message -----
From: Zhang, Helin [mailto:helin.zhang@intel.com]
Sent: Tuesday, August 19, 2014 11:53 AM
To: Zhangkun (K); dev@dpdk.org
Cc: zhangkun
Subject: RE: [dpdk-dev] [PATCH] there are some memory leak about Dir operator
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of
> zhang.zhangkun@huawei.com
> Sent: Tuesday, August 19, 2014 11:40 AM
> To: dev@dpdk.org
> Cc: zhangkun
> Subject: [dpdk-dev] [PATCH] there are some memory leak about Dir
> operator
>
> From: zhangkun <zhangk.zhangkun@huawei.com>
>
>
> Signed-off-by: zhangkun <zhangk.zhangkun@huawei.com>
> ---
> lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
> b/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
> index b72a205..d784b7c 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
> @@ -311,12 +311,14 @@ eal_hugepage_info_init(void)
> /* if blocking lock failed */
> if (flock(hpi->lock_descriptor, LOCK_EX) == -1) {
> RTE_LOG(CRIT, EAL, "Failed to lock hugepage directory!\n");
> + closedir(dir);
> return -1;
> }
> /* clear out the hugepages dir from unused pages */
> - if (clear_hugedir(hpi->hugedir) == -1)
> + if (clear_hugedir(hpi->hugedir) == -1) {
> + closedir(dir);
> return -1;
> -
> + }
> /* for now, put all pages into socket 0,
> * later they will be sorted */
> hpi->num_pages[0] =
> get_num_hugepages(dirent->d_name);
> --
> 1.7.3.1.msysgit.0
>
Hi Zhangkun
Could you help to explain more detailed about the memory leak? Wouldn't the OS take care of those closing during process exiting?
Regards,
Helin
next prev parent reply other threads:[~2014-08-19 6:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 3:39 [dpdk-dev] " zhang.zhangkun
2014-08-19 3:53 ` Zhang, Helin
2014-08-19 6:10 ` Zhangkun (K) [this message]
2014-08-19 3:51 zhang.zhangkun
2014-08-29 10:43 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0FCB215400789046A95ECE23C3E46C515F956183@szxema505-mbx.china.huawei.com \
--to=zhang.zhangkun@huawei.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).