From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Jiawen Wu <jiawenwu@trustnetic.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v7 00/19] net: ngbe PMD
Date: Wed, 7 Jul 2021 17:13:11 +0300 [thread overview]
Message-ID: <109ea936-11f0-8f67-9fb4-55194ab3a0f7@oktetlabs.ru> (raw)
In-Reply-To: <20210706095545.10776-1-jiawenwu@trustnetic.com>
On 7/6/21 12:55 PM, Jiawen Wu wrote:
> This patch set provides a skeleton of ngbe PMD,
> which adapted to Wangxun WX1860 series NICs.
Hopefully final review.
$ ./devtools/check-meson.py
Error: Incorrect indent at drivers/net/meson.build:43
Error: Incorrect indent at drivers/net/ngbe/meson.build:14
Error: Incorrect indent at drivers/net/ngbe/meson.build:15
Error: Incorrect indent at drivers/net/ngbe/base/meson.build:5
Error: Incorrect indent at drivers/net/ngbe/base/meson.build:6
Error: Incorrect indent at drivers/net/ngbe/base/meson.build:7
Error: Incorrect indent at drivers/net/ngbe/base/meson.build:8
Error: Incorrect indent at drivers/net/ngbe/base/meson.build:9
Error: Incorrect indent at drivers/net/ngbe/base/meson.build:10
Error: Incorrect indent at drivers/net/ngbe/base/meson.build:11
Please, run it after each patch which changes meson.build
and fix errors.
I'm not sure about __rte_cold markup in the patches.
Do you really need it? I'll keep it up to you, but I'd
recommend to remove it if you don't really see a measurable
performance drop.
prev parent reply other threads:[~2021-07-07 14:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 9:55 Jiawen Wu
2021-07-06 9:55 ` [dpdk-dev] [PATCH v7 01/19] net/ngbe: add build and doc infrastructure Jiawen Wu
2021-07-06 9:55 ` [dpdk-dev] [PATCH v7 02/19] net/ngbe: support probe and remove Jiawen Wu
2021-07-07 13:48 ` Andrew Rybchenko
2021-07-06 9:55 ` [dpdk-dev] [PATCH v7 03/19] net/ngbe: add log type and error type Jiawen Wu
2021-07-06 9:55 ` [dpdk-dev] [PATCH v7 04/19] net/ngbe: define registers Jiawen Wu
2021-07-06 9:55 ` [dpdk-dev] [PATCH v7 05/19] net/ngbe: set MAC type and LAN ID with device initialization Jiawen Wu
2021-07-06 9:55 ` [dpdk-dev] [PATCH v7 06/19] net/ngbe: init and validate EEPROM Jiawen Wu
2021-07-06 9:55 ` [dpdk-dev] [PATCH v7 07/19] net/ngbe: add HW initialization Jiawen Wu
2021-07-06 9:55 ` [dpdk-dev] [PATCH v7 08/19] net/ngbe: identify PHY and reset PHY Jiawen Wu
2021-07-06 9:55 ` [dpdk-dev] [PATCH v7 09/19] net/ngbe: store MAC address Jiawen Wu
2021-07-06 9:55 ` [dpdk-dev] [PATCH v7 10/19] net/ngbe: support link update Jiawen Wu
2021-07-07 13:50 ` Andrew Rybchenko
2021-07-06 9:55 ` [dpdk-dev] [PATCH v7 11/19] net/ngbe: setup the check PHY link Jiawen Wu
2021-07-06 9:55 ` [dpdk-dev] [PATCH v7 12/19] net/ngbe: add Rx queue setup and release Jiawen Wu
2021-07-07 13:56 ` Andrew Rybchenko
2021-07-06 9:55 ` [dpdk-dev] [PATCH v7 13/19] net/ngbe: add Tx " Jiawen Wu
2021-07-07 14:00 ` Andrew Rybchenko
2021-07-06 9:55 ` [dpdk-dev] [PATCH v7 14/19] net/ngbe: add device start and stop operations Jiawen Wu
2021-07-07 14:04 ` Andrew Rybchenko
2021-07-08 6:09 ` Jiawen Wu
2021-07-08 7:36 ` Andrew Rybchenko
2021-07-08 7:50 ` Jiawen Wu
2021-07-08 8:07 ` Andrew Rybchenko
2021-07-06 9:55 ` [dpdk-dev] [PATCH v7 15/19] net/ngbe: add Tx queue start and stop Jiawen Wu
2021-07-06 9:55 ` [dpdk-dev] [PATCH v7 16/19] net/ngbe: add Rx " Jiawen Wu
2021-07-06 9:55 ` [dpdk-dev] [PATCH v7 17/19] net/ngbe: add simple Rx flow Jiawen Wu
2021-07-06 9:55 ` [dpdk-dev] [PATCH v7 18/19] net/ngbe: add simple Tx flow Jiawen Wu
2021-07-06 9:55 ` [dpdk-dev] [PATCH v7 19/19] net/ngbe: support to close and reset device Jiawen Wu
2021-07-07 14:12 ` Andrew Rybchenko
2021-07-08 8:56 ` Jiawen Wu
2021-07-07 14:13 ` Andrew Rybchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=109ea936-11f0-8f67-9fb4-55194ab3a0f7@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=jiawenwu@trustnetic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).