Re: [dpdk-dev] [PATCH v7 13/19] net/ngbe: add Tx queue setup and release

[Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>]

On 7/6/21 12:55 PM, Jiawen Wu wrote:
> Setup device Tx queue and release Tx queue.
> 
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>

Same here, format string should be on the next its own line:

### net/ngbe: add Tx queue setup and release

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#299: FILE: drivers/net/ngbe/ngbe_rxtx.c:202:
+       PMD_INIT_LOG(DEBUG, "sw_ring=%p hw_ring=%p dma_addr=0x%" PRIx64,

total: 0 errors, 0 warnings, 1 checks, 398 lines checked

[snip]

> +
> +/**
> + * Structure associated with each Tx queue.
> + */
> +struct ngbe_tx_queue {
> +	/** Tx ring virtual address. */
> +	volatile struct ngbe_tx_desc *tx_ring;
> +	uint64_t            tx_ring_phys_addr; /**< Tx ring DMA address. */
> +	struct ngbe_tx_entry *sw_ring; /**< address of SW ring for scalar PMD.*/
> +	volatile uint32_t   *tdt_reg_addr; /**< Address of TDT register. */
> +	volatile uint32_t   *tdc_reg_addr; /**< Address of TDC register. */
> +	uint16_t            nb_tx_desc;    /**< number of Tx descriptors. */
> +	uint16_t            tx_tail;       /**< current value of TDT reg. */
> +	/**< Start freeing Tx buffers if there are less free descriptors than
> +	 *   this value.
> +	 */

Comment should start from /**
Also multi-line comment should be:
/**
 * Comment here
 */

> +	uint16_t            tx_free_thresh;
> +	/** Index to last Tx descriptor to have been cleaned. */
> +	uint16_t            last_desc_cleaned;
> +	/** Total number of Tx descriptors ready to be allocated. */
> +	uint16_t            nb_tx_free;
> +	uint16_t            tx_next_dd;    /**< next desc to scan for DD bit */
> +	uint16_t            queue_id;      /**< Tx queue index. */
> +	uint16_t            reg_idx;       /**< Tx queue register index. */
> +	uint16_t            port_id;       /**< Device port identifier. */
> +	uint8_t             pthresh;       /**< Prefetch threshold register. */
> +	uint8_t             hthresh;       /**< Host threshold register. */
> +	uint8_t             wthresh;       /**< Write-back threshold reg. */
> +	uint32_t            ctx_curr;      /**< Hardware context states. */
> +	/** Hardware context0 history. */
> +	struct ngbe_ctx_info ctx_cache[NGBE_CTX_NUM];
> +	const struct ngbe_txq_ops *ops;       /**< txq ops */
> +	uint8_t             tx_deferred_start; /**< not in global dev start. */
> +};

Some of comments above have full stop, some do not have.
Be consistent. I'd simply remove full stop everywhere to make
lines a bit shorter.

[snip]