DPDK patches and discussions
 help / color / mirror / Atom feed
From: Zhigang Lu <zlu@ezchip.com>
To: <dev@dpdk.org>
Cc: Cyril Chemparathy <cchemparathy@ezchip.com>
Subject: [dpdk-dev] [PATCH v5 03/11] eal: allow empty compile time flags RTE_COMPILE_TIME_CPUFLAGS
Date: Thu, 9 Jul 2015 16:25:12 +0800	[thread overview]
Message-ID: <1436430321-3864-4-git-send-email-zlu@ezchip.com> (raw)
In-Reply-To: <1436430321-3864-1-git-send-email-zlu@ezchip.com>

When RTE_COMPILE_TIME_CPUFLAGS is empty, the rte_cpu_check_supported()
code breaks with a "comparison is always false due to limited range of
data type".  This is because the compile_time_flags[] array is empty.
Assigning the array dimension to a local variable apparently solves this.

Signed-off-by: Cyril Chemparathy <cchemparathy@ezchip.com>
Signed-off-by: Zhigang Lu <zlu@ezchip.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/librte_eal/common/eal_common_cpuflags.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/librte_eal/common/eal_common_cpuflags.c b/lib/librte_eal/common/eal_common_cpuflags.c
index 6fd360c..8ba7b30 100644
--- a/lib/librte_eal/common/eal_common_cpuflags.c
+++ b/lib/librte_eal/common/eal_common_cpuflags.c
@@ -30,6 +30,7 @@
  *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
+#include <rte_common.h>
 #include <rte_cpuflags.h>
 
 /*
@@ -62,10 +63,10 @@ rte_cpu_check_supported(void)
 	static const enum rte_cpu_flag_t compile_time_flags[] = {
 			RTE_COMPILE_TIME_CPUFLAGS
 	};
-	unsigned i;
+	unsigned count = RTE_DIM(compile_time_flags), i;
 	int ret;
 
-	for (i = 0; i < sizeof(compile_time_flags)/sizeof(compile_time_flags[0]); i++) {
+	for (i = 0; i < count; i++) {
 		ret = rte_cpu_get_flag_enabled(compile_time_flags[i]);
 
 		if (ret < 0) {
-- 
2.1.2

  parent reply	other threads:[~2015-07-09  8:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-09  8:25 [dpdk-dev] [PATCH v5 00/11] Introducing the TILE-Gx platform Zhigang Lu
2015-07-09  8:25 ` [dpdk-dev] [PATCH v5 01/11] test: limit x86 cpuflags checks to x86 builds Zhigang Lu
2015-07-09  8:25 ` [dpdk-dev] [PATCH v5 02/11] hash: check SSE flags only on " Zhigang Lu
2015-07-09  8:25 ` Zhigang Lu [this message]
2015-07-09  8:25 ` [dpdk-dev] [PATCH v5 04/11] config: remove RTE_LIBNAME definition Zhigang Lu
2015-07-09  8:25 ` [dpdk-dev] [PATCH v5 05/11] memzone: refactor rte_memzone_reserve() variants Zhigang Lu
2015-07-09  8:25 ` [dpdk-dev] [PATCH v5 06/11] memzone: allow multiple pagesizes to be requested Zhigang Lu
2015-07-09  8:25 ` [dpdk-dev] [PATCH v5 07/11] mempool: allow config override on element alignment Zhigang Lu
2015-07-09  8:25 ` [dpdk-dev] [PATCH v5 08/11] tile: add page sizes for TILE-Gx/Mx platforms Zhigang Lu
2015-07-09  8:25 ` [dpdk-dev] [PATCH v5 09/11] tile: initial TILE-Gx support Zhigang Lu
2015-07-09  8:25 ` [dpdk-dev] [PATCH v5 10/11] tile: Add TILE-Gx mPIPE poll mode driver Zhigang Lu
2015-07-09  8:25 ` [dpdk-dev] [PATCH v5 11/11] maintainers: claim responsibility for TILE-Gx platform Zhigang Lu
2015-07-13 14:17 ` [dpdk-dev] [PATCH v5 00/11] Introducing the " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436430321-3864-4-git-send-email-zlu@ezchip.com \
    --to=zlu@ezchip.com \
    --cc=cchemparathy@ezchip.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).