* [dpdk-dev] [PATCH 0/3] update maintainers areas
@ 2015-02-04 22:23 Thomas Monjalon
2015-02-04 22:23 ` [dpdk-dev] [PATCH 1/3] maintainers: dispatch more doc Thomas Monjalon
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Thomas Monjalon @ 2015-02-04 22:23 UTC (permalink / raw)
To: dev
More files should be referenced in MAINTAINERS files:
- some (forgotten) docs can be co-maintained in doc and lib areas
- new ABI files
The script can now check for unknown files.
Thomas Monjalon (3):
maintainers: dispatch more doc
maintainers: add ABI versioning
scripts: check wrong patterns in maintainers file
MAINTAINERS | 9 +++++++++
scripts/check-maintainers.sh | 20 +++++++++++++++++++-
2 files changed, 28 insertions(+), 1 deletion(-)
--
2.2.2
^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-dev] [PATCH 1/3] maintainers: dispatch more doc
2015-02-04 22:23 [dpdk-dev] [PATCH 0/3] update maintainers areas Thomas Monjalon
@ 2015-02-04 22:23 ` Thomas Monjalon
2015-02-06 8:55 ` Olivier MATZ
2015-02-04 22:23 ` [dpdk-dev] [PATCH 2/3] maintainers: add ABI versioning Thomas Monjalon
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Thomas Monjalon @ 2015-02-04 22:23 UTC (permalink / raw)
To: dev
Documentation of build system, EAL and ring lib should be covered by
the maintainers of the respective areas.
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
MAINTAINERS | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 12c7c16..f2b697e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -49,6 +49,10 @@ F: scripts/depdirs-rule.sh
F: scripts/gen-build-mk.sh
F: scripts/gen-config-h.sh
F: scripts/relpath.sh
+F: doc/build-sdk-quick.txt
+F: doc/guides/prog_guide/build_app.rst
+F: doc/guides/prog_guide/dev_kit_*
+F: doc/guides/prog_guide/ext_app_lib_make_help.rst
Environment Abstraction Layer
@@ -59,6 +63,7 @@ M: Thomas Monjalon <thomas.monjalon@6wind.com>
F: lib/librte_eal/common/*
F: lib/librte_eal/common/include/*
F: lib/librte_eal/common/include/generic/
+F: doc/guides/prog_guide/env_abstraction_layer.rst
F: app/test/test_alarm.c
F: app/test/test_atomic.c
F: app/test/test_byteorder.c
@@ -150,6 +155,7 @@ F: app/test/test_func_reentrancy.c
Ring queue
M: Olivier Matz <olivier.matz@6wind.com>
F: lib/librte_ring/
+F: doc/guides/prog_guide/ring_lib.rst
F: app/test/test_ring*
F: app/test/test_func_reentrancy.c
--
2.2.2
^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-dev] [PATCH 2/3] maintainers: add ABI versioning
2015-02-04 22:23 [dpdk-dev] [PATCH 0/3] update maintainers areas Thomas Monjalon
2015-02-04 22:23 ` [dpdk-dev] [PATCH 1/3] maintainers: dispatch more doc Thomas Monjalon
@ 2015-02-04 22:23 ` Thomas Monjalon
2015-02-05 1:39 ` Neil Horman
2015-02-04 22:23 ` [dpdk-dev] [PATCH 3/3] scripts: check wrong patterns in maintainers file Thomas Monjalon
2015-02-09 14:21 ` [dpdk-dev] [PATCH 0/3] update maintainers areas Thomas Monjalon
3 siblings, 1 reply; 8+ messages in thread
From: Thomas Monjalon @ 2015-02-04 22:23 UTC (permalink / raw)
To: dev
Reference the new framework and policy for ABI versioning,
in the MAINTAINERS file.
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
MAINTAINERS | 3 +++
1 file changed, 3 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index f2b697e..7c0047b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -54,6 +54,9 @@ F: doc/guides/prog_guide/build_app.rst
F: doc/guides/prog_guide/dev_kit_*
F: doc/guides/prog_guide/ext_app_lib_make_help.rst
+ABI versioning
+F: lib/librte_compat/
+F: doc/guides/rel_notes/abi.rst
Environment Abstraction Layer
-----------------------------
--
2.2.2
^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-dev] [PATCH 3/3] scripts: check wrong patterns in maintainers file
2015-02-04 22:23 [dpdk-dev] [PATCH 0/3] update maintainers areas Thomas Monjalon
2015-02-04 22:23 ` [dpdk-dev] [PATCH 1/3] maintainers: dispatch more doc Thomas Monjalon
2015-02-04 22:23 ` [dpdk-dev] [PATCH 2/3] maintainers: add ABI versioning Thomas Monjalon
@ 2015-02-04 22:23 ` Thomas Monjalon
2015-02-09 14:21 ` [dpdk-dev] [PATCH 0/3] update maintainers areas Thomas Monjalon
3 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2015-02-04 22:23 UTC (permalink / raw)
To: dev
Each F or X pattern is checked and printed if there is no match
with a file in the repository.
The wildcard must be temporarily replaced to prevent from shell expansion.
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
scripts/check-maintainers.sh | 20 +++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/scripts/check-maintainers.sh b/scripts/check-maintainers.sh
index 2687cad..e62217e 100755
--- a/scripts/check-maintainers.sh
+++ b/scripts/check-maintainers.sh
@@ -88,6 +88,20 @@ parse_fx () # <index file>
done
}
+# Check patterns in F: and X:
+check_fx () # <index file>
+{
+ IFS='
+'
+ for line in $(sed -n 's,^[FX]: ,,p' $1 | tr '*' '#') ; do
+ line=$(printf "$line" | tr '#' '*')
+ match=$(files "$line")
+ if [ -z "$match" ] ; then
+ echo "$line"
+ fi
+ done
+}
+
# Add a line to a set of lines if it begins with right pattern
add_line_to_if () # <new line> <lines> <head pattern>
{
@@ -112,6 +126,10 @@ echo '# files not listed'
echo '##########'
aminusb "$all" "$listed"
-# TODO: check patterns that match nothing
+echo '##########'
+echo '# wrong patterns'
+echo '##########'
+check_fx MAINTAINERS
+
# TODO: check overlaps
# TODO: check orphan areas
--
2.2.2
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH 2/3] maintainers: add ABI versioning
2015-02-04 22:23 ` [dpdk-dev] [PATCH 2/3] maintainers: add ABI versioning Thomas Monjalon
@ 2015-02-05 1:39 ` Neil Horman
2015-02-09 14:20 ` Thomas Monjalon
0 siblings, 1 reply; 8+ messages in thread
From: Neil Horman @ 2015-02-05 1:39 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev
On Wed, Feb 04, 2015 at 11:23:23PM +0100, Thomas Monjalon wrote:
> Reference the new framework and policy for ABI versioning,
> in the MAINTAINERS file.
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
> MAINTAINERS | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f2b697e..7c0047b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -54,6 +54,9 @@ F: doc/guides/prog_guide/build_app.rst
> F: doc/guides/prog_guide/dev_kit_*
> F: doc/guides/prog_guide/ext_app_lib_make_help.rst
>
> +ABI versioning
> +F: lib/librte_compat/
> +F: doc/guides/rel_notes/abi.rst
>
Feel free to add my name to this area of you feel its warranted.
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH 1/3] maintainers: dispatch more doc
2015-02-04 22:23 ` [dpdk-dev] [PATCH 1/3] maintainers: dispatch more doc Thomas Monjalon
@ 2015-02-06 8:55 ` Olivier MATZ
0 siblings, 0 replies; 8+ messages in thread
From: Olivier MATZ @ 2015-02-06 8:55 UTC (permalink / raw)
To: dev
Hi Thomas,
On 02/04/2015 11:23 PM, Thomas Monjalon wrote:
> Documentation of build system, EAL and ring lib should be covered by
> the maintainers of the respective areas.
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
> MAINTAINERS | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 12c7c16..f2b697e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -49,6 +49,10 @@ F: scripts/depdirs-rule.sh
> F: scripts/gen-build-mk.sh
> F: scripts/gen-config-h.sh
> F: scripts/relpath.sh
> +F: doc/build-sdk-quick.txt
> +F: doc/guides/prog_guide/build_app.rst
> +F: doc/guides/prog_guide/dev_kit_*
> +F: doc/guides/prog_guide/ext_app_lib_make_help.rst
>
>
> Environment Abstraction Layer
> @@ -59,6 +63,7 @@ M: Thomas Monjalon <thomas.monjalon@6wind.com>
> F: lib/librte_eal/common/*
> F: lib/librte_eal/common/include/*
> F: lib/librte_eal/common/include/generic/
> +F: doc/guides/prog_guide/env_abstraction_layer.rst
> F: app/test/test_alarm.c
> F: app/test/test_atomic.c
> F: app/test/test_byteorder.c
> @@ -150,6 +155,7 @@ F: app/test/test_func_reentrancy.c
> Ring queue
> M: Olivier Matz <olivier.matz@6wind.com>
> F: lib/librte_ring/
> +F: doc/guides/prog_guide/ring_lib.rst
> F: app/test/test_ring*
> F: app/test/test_func_reentrancy.c
Acked-by: Olivier Matz <olivier.matz@6wind.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH 2/3] maintainers: add ABI versioning
2015-02-05 1:39 ` Neil Horman
@ 2015-02-09 14:20 ` Thomas Monjalon
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2015-02-09 14:20 UTC (permalink / raw)
To: Neil Horman; +Cc: dev
2015-02-04 20:39, Neil Horman:
> On Wed, Feb 04, 2015 at 11:23:23PM +0100, Thomas Monjalon wrote:
> > Reference the new framework and policy for ABI versioning,
> > in the MAINTAINERS file.
> >
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > ---
> > MAINTAINERS | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index f2b697e..7c0047b 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -54,6 +54,9 @@ F: doc/guides/prog_guide/build_app.rst
> > F: doc/guides/prog_guide/dev_kit_*
> > F: doc/guides/prog_guide/ext_app_lib_make_help.rst
> >
> > +ABI versioning
> > +F: lib/librte_compat/
> > +F: doc/guides/rel_notes/abi.rst
> >
> Feel free to add my name to this area of you feel its warranted.
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
OK Neil, your name is added as ABI versioning maintainer.
Thanks
--
Thomas
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH 0/3] update maintainers areas
2015-02-04 22:23 [dpdk-dev] [PATCH 0/3] update maintainers areas Thomas Monjalon
` (2 preceding siblings ...)
2015-02-04 22:23 ` [dpdk-dev] [PATCH 3/3] scripts: check wrong patterns in maintainers file Thomas Monjalon
@ 2015-02-09 14:21 ` Thomas Monjalon
3 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2015-02-09 14:21 UTC (permalink / raw)
To: dev
> More files should be referenced in MAINTAINERS files:
> - some (forgotten) docs can be co-maintained in doc and lib areas
> - new ABI files
> The script can now check for unknown files.
>
> Thomas Monjalon (3):
> maintainers: dispatch more doc
> maintainers: add ABI versioning
> scripts: check wrong patterns in maintainers file
Applied
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-02-09 14:21 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-04 22:23 [dpdk-dev] [PATCH 0/3] update maintainers areas Thomas Monjalon
2015-02-04 22:23 ` [dpdk-dev] [PATCH 1/3] maintainers: dispatch more doc Thomas Monjalon
2015-02-06 8:55 ` Olivier MATZ
2015-02-04 22:23 ` [dpdk-dev] [PATCH 2/3] maintainers: add ABI versioning Thomas Monjalon
2015-02-05 1:39 ` Neil Horman
2015-02-09 14:20 ` Thomas Monjalon
2015-02-04 22:23 ` [dpdk-dev] [PATCH 3/3] scripts: check wrong patterns in maintainers file Thomas Monjalon
2015-02-09 14:21 ` [dpdk-dev] [PATCH 0/3] update maintainers areas Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).