DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tetsuya Mukawa <mukawa@igel.co.jp>
To: dev@dpdk.org
Cc: pmatilai@redhat.com, yuanhan.liu@linux.intel.com,
	huawei.xie@intel.com, Tetsuya Mukawa <mukawa@igel.co.jp>
Subject: [dpdk-dev] [PATCH v2] vhost: Fix linkage of vhost PMD
Date: Tue, 26 Apr 2016 14:39:29 +0900	[thread overview]
Message-ID: <1461649169-13967-1-git-send-email-mukawa@igel.co.jp> (raw)
In-Reply-To: <571DDDD8.6000000@igel.co.jp>

Currently, vhost PMD doesn't have linkage for librte_vhost, even though
it depends on librte_vhost APIs. This causes a linkage error if below
conditions are fulfilled.

 - DPDK libraries are compiled as shared libraries.
 - DPDK application doesn't link librte_vhost.
 - Above application tries to link vhost PMD using '-d' DPDK option.

The patch adds linkage for librte_vhost to vhost PMD not to cause an
above error.

Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>
Acked-by: Panu Matilainen <pmatilai@redhat.com>
---
 drivers/net/vhost/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/vhost/Makefile b/drivers/net/vhost/Makefile
index f49a69b..30b91a0 100644
--- a/drivers/net/vhost/Makefile
+++ b/drivers/net/vhost/Makefile
@@ -38,6 +38,7 @@ LIB = librte_pmd_vhost.a
 
 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
+LDLIBS += -lrte_vhost
 
 EXPORT_MAP := rte_pmd_vhost_version.map
 
-- 
2.5.0

  parent reply	other threads:[~2016-04-26  5:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-25  9:05 [dpdk-dev] [RFC] Link ibrte_vhost to librte_pmd_vhost Tetsuya Mukawa
2016-04-25  9:28 ` Panu Matilainen
2016-04-25  9:44   ` Tetsuya Mukawa
2016-04-26  3:47   ` Yuanhan Liu
2016-04-26  5:37     ` Tetsuya Mukawa
2016-04-26  5:48       ` Yuanhan Liu
2016-04-26  6:00         ` Tetsuya Mukawa
2016-04-26  5:39 ` Tetsuya Mukawa [this message]
2016-04-26  9:35   ` [dpdk-dev] [PATCH v2] vhost: Fix linkage of vhost PMD Panu Matilainen
2016-04-27  1:38     ` Tetsuya Mukawa
2016-04-27 22:21   ` Yuanhan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461649169-13967-1-git-send-email-mukawa@igel.co.jp \
    --to=mukawa@igel.co.jp \
    --cc=dev@dpdk.org \
    --cc=huawei.xie@intel.com \
    --cc=pmatilai@redhat.com \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).