* [dpdk-dev] [PATCH v3] mempool: remove a redundant socket id assignment
@ 2016-12-05 3:36 Wei Zhao
0 siblings, 0 replies; 4+ messages in thread
From: Wei Zhao @ 2016-12-05 3:36 UTC (permalink / raw)
To: dev; +Cc: olivier.matz, zhao wei
From: zhao wei <wei.zhao1@intel.com>
There is a redundant repetition mempool socket_id assignment in the
file rte_mempool.c in function rte_mempool_create_empty. The
statement "mp->socket_id = socket_id;"appear twice in line 821
and 824. One of them is redundant, so delete it.
Fixes: 85226f9c526b ("mempool: introduce a function to create an empty pool")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
lib/librte_mempool/rte_mempool.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
index aa513b9..1c2aed8 100644
--- a/lib/librte_mempool/rte_mempool.c
+++ b/lib/librte_mempool/rte_mempool.c
@@ -818,7 +818,6 @@ rte_mempool_create_empty(const char *name, unsigned n, unsigned elt_size,
goto exit_unlock;
}
mp->mz = mz;
- mp->socket_id = socket_id;
mp->size = n;
mp->flags = flags;
mp->socket_id = socket_id;
--
2.5.5
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v3] mempool: remove a redundant socket id assignment
2016-12-05 3:39 Wei Zhao
@ 2016-12-06 14:13 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2016-12-06 14:13 UTC (permalink / raw)
To: Wei Zhao; +Cc: dev, olivier.matz
2016-12-05 11:39, Wei Zhao:
> There is a redundant repetition mempool socket_id assignment in the
> file rte_mempool.c in function rte_mempool_create_empty. The
> statement "mp->socket_id = socket_id;"appear twice in line 821
> and 824. One of them is redundant, so delete it.
>
> Fixes: 85226f9c526b ("mempool: introduce a function to create an empty pool")
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Acked-by: John McNamara <john.mcnamara@intel.com>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH v3] mempool: remove a redundant socket id assignment
@ 2016-12-05 3:39 Wei Zhao
2016-12-06 14:13 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Wei Zhao @ 2016-12-05 3:39 UTC (permalink / raw)
To: dev; +Cc: olivier.matz, Wei Zhao
There is a redundant repetition mempool socket_id assignment in the
file rte_mempool.c in function rte_mempool_create_empty. The
statement "mp->socket_id = socket_id;"appear twice in line 821
and 824. One of them is redundant, so delete it.
Fixes: 85226f9c526b ("mempool: introduce a function to create an empty pool")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
---
v3:
--checkpatch warning fixed
v2:
--checkpatch error fixed
---
lib/librte_mempool/rte_mempool.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
index aa513b9..1c2aed8 100644
--- a/lib/librte_mempool/rte_mempool.c
+++ b/lib/librte_mempool/rte_mempool.c
@@ -818,7 +818,6 @@ rte_mempool_create_empty(const char *name, unsigned n, unsigned elt_size,
goto exit_unlock;
}
mp->mz = mz;
- mp->socket_id = socket_id;
mp->size = n;
mp->flags = flags;
mp->socket_id = socket_id;
--
2.5.5
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH v3] mempool: remove a redundant socket id assignment
@ 2016-12-05 3:08 Wei Zhao
0 siblings, 0 replies; 4+ messages in thread
From: Wei Zhao @ 2016-12-05 3:08 UTC (permalink / raw)
To: dev; +Cc: olivier.matz, zhao wei
From: zhao wei <wei.zhao1@intel.com>
There is a redundant repetition mempool socket_id assignment in the
file rte_mempool.c in function rte_mempool_create_empty. The
statement "mp->socket_id = socket_id;"appear twice in line 821
and 824. One of them is redundant, so delete it.
Fixes: 85226f9c526b ("mempool: introduce a function to create an empty pool")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
lib/librte_mempool/rte_mempool.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
index aa513b9..1c2aed8 100644
--- a/lib/librte_mempool/rte_mempool.c
+++ b/lib/librte_mempool/rte_mempool.c
@@ -818,7 +818,6 @@ rte_mempool_create_empty(const char *name, unsigned n, unsigned elt_size,
goto exit_unlock;
}
mp->mz = mz;
- mp->socket_id = socket_id;
mp->size = n;
mp->flags = flags;
mp->socket_id = socket_id;
--
2.5.5
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-06 14:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-05 3:36 [dpdk-dev] [PATCH v3] mempool: remove a redundant socket id assignment Wei Zhao
-- strict thread matches above, loose matches on Subject: below --
2016-12-05 3:39 Wei Zhao
2016-12-06 14:13 ` Thomas Monjalon
2016-12-05 3:08 Wei Zhao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).