DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jan Blunck <jblunck@infradead.org>
To: dev@dpdk.org
Cc: Eric Kinzie <ekinzie@brocade.com>, Eric Kinzie <ehkinzie@gmail.com>
Subject: [dpdk-dev] [PATCH 1/2] bond: avoid allocating mempool on socket LCORE_ID_ANY
Date: Wed, 26 Apr 2017 23:30:07 +0200	[thread overview]
Message-ID: <1493242208-19526-1-git-send-email-jblunck@infradead.org> (raw)

If the numa node is unknown, use the value from rte_socket_id() to avoid
an allocation failure.

Signed-off-by: Eric Kinzie <ekinzie@brocade.com>
CC: Eric Kinzie <ehkinzie@gmail.com>
---
 drivers/net/bonding/rte_eth_bond_8023ad.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
index 7b863d6..b8df536 100644
--- a/drivers/net/bonding/rte_eth_bond_8023ad.c
+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
@@ -887,6 +887,8 @@ bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev, uint8_t slave_id)
 	RTE_ASSERT(port->rx_ring == NULL);
 	RTE_ASSERT(port->tx_ring == NULL);
 	socket_id = rte_eth_devices[slave_id].data->numa_node;
+	if (socket_id == (uint8_t)LCORE_ID_ANY)
+		socket_id = 0;
 
 	element_size = sizeof(struct slow_protocol_frame) +
 				RTE_PKTMBUF_HEADROOM;
-- 
2.7.4

             reply	other threads:[~2017-04-26 21:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-26 21:30 Jan Blunck [this message]
2017-04-26 21:30 ` [dpdk-dev] [PATCH 2/2] bond: use rte_eth_dev_socket_id() Jan Blunck
2017-06-28  9:49   ` Declan Doherty
2017-06-28  9:47 ` [dpdk-dev] [PATCH 1/2] bond: avoid allocating mempool on socket LCORE_ID_ANY Declan Doherty
2017-06-28 12:00   ` Jan Blunck
2017-06-30 14:34     ` [dpdk-dev] [PATCH v2 " Declan Doherty
2017-06-30 14:34       ` [dpdk-dev] [PATCH v2 2/2] bond: use rte_eth_dev_socket_id() Declan Doherty
2017-07-03 12:17       ` [dpdk-dev] [PATCH v2 1/2] bond: avoid allocating mempool on socket LCORE_ID_ANY Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493242208-19526-1-git-send-email-jblunck@infradead.org \
    --to=jblunck@infradead.org \
    --cc=dev@dpdk.org \
    --cc=ehkinzie@gmail.com \
    --cc=ekinzie@brocade.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).