DPDK patches and discussions
 help / color / mirror / Atom feed
From: Zhiyong Yang <zhiyong.yang@intel.com>
To: dev@dpdk.org
Cc: yuanhan.liu@linux.intel.com, maxime.coquelin@redhat.com,
	ciara.loftus@intel.com, Zhiyong Yang <zhiyong.yang@intel.com>
Subject: [dpdk-dev] [PATCH] vhost: fix MQ fails to startup
Date: Thu, 27 Apr 2017 14:34:53 +0800	[thread overview]
Message-ID: <1493274893-40764-1-git-send-email-zhiyong.yang@intel.com> (raw)

vhost since dpdk17.02 + qemu2.7 and above will cause failures of
new connection when negotiating to set MQ. (one queue pair works
well).Because there exist some bugs in qemu code when introducing
VHOST_USER_PROTOCOL_F_REPLY_ACK to qemu. when dealing with the vhost
message VHOST_USER_SET_MEM_TABLE for the second time, qemu indeed
doesn't send the messge (The message needs to be sent only once)but
still will be waiting for dpdk's reply ack, then, qemu is always
freezing. DPDK code works in the right way. But the feature 
VHOST_USER_PROTOCOL_F_REPLY_ACK has to be disabled by default at the
dpdk side in order to avoid the feature support of DPDK + qemu at
the same time. if doing like that, MQ can works well. Once Qemu bugs
have been fixed and upstreamed, we can enable it.

Fixes: 73c8f9f69c6c("vhost: introduce reply ack feature")

Reported-by: Loftus, Ciara <ciara.loftus@intel.com>
Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
 lib/librte_vhost/vhost_user.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.h
index 2ba22db..a3d2900 100644
--- a/lib/librte_vhost/vhost_user.h
+++ b/lib/librte_vhost/vhost_user.h
@@ -52,7 +52,7 @@
 #define VHOST_USER_PROTOCOL_FEATURES	((1ULL << VHOST_USER_PROTOCOL_F_MQ) | \
 					 (1ULL << VHOST_USER_PROTOCOL_F_LOG_SHMFD) |\
 					 (1ULL << VHOST_USER_PROTOCOL_F_RARP) | \
-					 (1ULL << VHOST_USER_PROTOCOL_F_REPLY_ACK) | \
+					 (0ULL << VHOST_USER_PROTOCOL_F_REPLY_ACK) | \
 					 (1ULL << VHOST_USER_PROTOCOL_F_NET_MTU))
 
 typedef enum VhostUserRequest {
-- 
2.7.4

             reply	other threads:[~2017-04-27  6:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-27  6:34 Zhiyong Yang [this message]
2017-04-27  7:41 ` Loftus, Ciara
2017-04-27  7:56 ` Maxime Coquelin
2017-04-27  8:05   ` Maxime Coquelin
2017-04-27  8:24     ` Yang, Zhiyong
2017-04-27  8:32       ` Maxime Coquelin
2017-04-27  8:20   ` Yuanhan Liu
2017-04-27  8:52     ` Maxime Coquelin
2017-04-28  2:25       ` Yuanhan Liu
2017-04-28  7:23         ` Maxime Coquelin
2017-04-28  7:35           ` Yuanhan Liu
2017-04-28  7:39             ` Yuanhan Liu
2017-04-28  7:57             ` Maxime Coquelin
2017-04-28  8:00               ` Yuanhan Liu
2017-04-27  8:12 ` Yuanhan Liu
2017-04-27  8:32   ` Yang, Zhiyong
2017-04-27  9:41 ` [dpdk-dev] [PATCH v2] vhost: workaround " Zhiyong Yang
2017-04-27 10:00   ` Maxime Coquelin
2017-04-28  4:29     ` Yuanhan Liu
2017-05-10  2:07       ` Yang, Zhiyong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493274893-40764-1-git-send-email-zhiyong.yang@intel.com \
    --to=zhiyong.yang@intel.com \
    --cc=ciara.loftus@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).