From: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
To: rsanford@akamai.com
Cc: dev@dpdk.org, john.mcnamara@intel.com,
Erik Carrillo <erik.g.carrillo@intel.com>
Subject: [dpdk-dev] [PATCH v4 2/3] timer: handle timers installed from non-EAL threads
Date: Tue, 19 Sep 2017 12:02:27 -0500 [thread overview]
Message-ID: <1505840548-77004-3-git-send-email-erik.g.carrillo@intel.com> (raw)
In-Reply-To: <1505840548-77004-1-git-send-email-erik.g.carrillo@intel.com>
From: Erik Carrillo <erik.g.carrillo@intel.com>
This commit adds support for timers being created from
non-EAL threads; it maps timers from all such threads to
lcore id RTE_MAX_LCORE, and puts them all in a corresponding
skiplist.
Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
---
v3:
* Rebased patch on reworked parent commit
v2:
* Address checkpatch warnings
lib/librte_timer/rte_timer.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c
index 1f4141e..c489c5f 100644
--- a/lib/librte_timer/rte_timer.c
+++ b/lib/librte_timer/rte_timer.c
@@ -66,8 +66,8 @@ struct skiplist {
} __rte_cache_aligned;
struct priv_timer {
- /** one pending list per enabled lcore */
- struct skiplist pending_lists[RTE_MAX_LCORE];
+ /** one pending list per lcore, plus one for non-EAL threads */
+ struct skiplist pending_lists[RTE_MAX_LCORE + 1];
bool multi_pendlists;
/** per-core variable that true if a timer was updated on this
@@ -88,7 +88,7 @@ struct priv_timer {
static struct priv_timer priv_timer[RTE_MAX_LCORE];
/** cache of IDs of enabled lcores */
-static unsigned int enabled_lcores[RTE_MAX_LCORE];
+static unsigned int enabled_lcores[RTE_MAX_LCORE + 1];
static int n_enabled_lcores;
/* when debug is enabled, store some statistics */
@@ -114,12 +114,18 @@ rte_timer_subsystem_init(void)
RTE_LCORE_FOREACH(lcore_id)
enabled_lcores[n_enabled_lcores++] = lcore_id;
+ /* To handle timers coming from non-EAL threads */
+ enabled_lcores[n_enabled_lcores++] = RTE_MAX_LCORE;
+
/* since priv_timer is static, it's zeroed by default, so only init some
* fields.
*/
for (i = 0; i < n_enabled_lcores; i++) {
lcore_id = enabled_lcores[i];
+ /* Don't use this value to index the priv_timer array */
+ if (lcore_id == RTE_MAX_LCORE)
+ continue;
priv_tim = &priv_timer[lcore_id];
priv_tim->prev_lcore = lcore_id;
@@ -343,7 +349,9 @@ timer_add(struct rte_timer *tim, unsigned int tim_lcore, int local_is_locked,
struct priv_timer *priv_tim = &priv_timer[tim_lcore];
if (priv_tim->multi_pendlists)
- *pending_lists_idx = lcore_id;
+ /* Check if timer being installed from non-EAL thread */
+ *pending_lists_idx = (lcore_id == LCORE_ID_ANY) ?
+ RTE_MAX_LCORE : lcore_id;
else
*pending_lists_idx = SINGLE_LIST_IDX;
--
2.6.4
next prev parent reply other threads:[~2017-09-19 17:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 14:47 [dpdk-dev] [PATCH 0/3] *** timer library enhancements *** Gabriel Carrillo
2017-08-23 14:47 ` [dpdk-dev] [PATCH 1/3] timer: add per-installer pending lists for each lcore Gabriel Carrillo
2017-08-25 20:27 ` [dpdk-dev] [PATCH v2 " Gabriel Carrillo
2017-08-29 10:57 ` Ananyev, Konstantin
2017-08-29 16:13 ` Carrillo, Erik G
2017-08-29 15:11 ` [dpdk-dev] [PATCH " Stephen Hemminger
2017-08-23 14:47 ` [dpdk-dev] [PATCH 2/3] timer: handle timers installed from non-EAL threads Gabriel Carrillo
2017-08-25 20:27 ` [dpdk-dev] [PATCH v2 " Gabriel Carrillo
2017-08-23 14:47 ` [dpdk-dev] [PATCH 3/3] doc: update timer lib docs Gabriel Carrillo
2017-08-25 20:27 ` [dpdk-dev] [PATCH v2 " Gabriel Carrillo
2017-08-23 15:02 ` [dpdk-dev] [PATCH 0/3] *** timer library enhancements *** Wiles, Keith
2017-08-23 16:19 ` Carrillo, Erik G
2017-08-23 16:50 ` Wiles, Keith
2017-08-23 19:28 ` Carrillo, Erik G
2017-08-23 21:04 ` Wiles, Keith
2017-08-24 14:08 ` Carrillo, Erik G
2017-08-25 20:26 ` [dpdk-dev] [PATCH v2 " Gabriel Carrillo
2017-09-13 22:05 ` [dpdk-dev] [PATCH v3 0/3] timer library enhancement Erik Gabriel Carrillo
2017-09-13 22:05 ` [dpdk-dev] [PATCH v3 1/3] timer: add multiple pending lists option for each lcore Erik Gabriel Carrillo
2017-09-13 22:05 ` [dpdk-dev] [PATCH v3 2/3] timer: handle timers installed from non-EAL threads Erik Gabriel Carrillo
2017-09-13 22:05 ` [dpdk-dev] [PATCH v3 3/3] doc: update timer lib docs Erik Gabriel Carrillo
2017-09-18 16:19 ` Mcnamara, John
2017-09-19 17:04 ` Carrillo, Erik G
2017-09-19 17:02 ` [dpdk-dev] [PATCH v4 0/3] timer library enhancement Erik Gabriel Carrillo
2017-09-19 17:02 ` [dpdk-dev] [PATCH v4 1/3] timer: add multiple pending lists option for each lcore Erik Gabriel Carrillo
2017-09-19 17:02 ` Erik Gabriel Carrillo [this message]
2017-09-19 17:02 ` [dpdk-dev] [PATCH v4 3/3] doc: update timer lib docs Erik Gabriel Carrillo
2017-10-11 20:42 ` [dpdk-dev] [PATCH v4 0/3] timer library enhancement Thomas Monjalon
2018-04-04 22:42 ` Thomas Monjalon
2018-04-05 21:53 ` Carrillo, Erik G
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505840548-77004-3-git-send-email-erik.g.carrillo@intel.com \
--to=erik.g.carrillo@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=rsanford@akamai.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).