From: Nick Connolly <nick.connolly@mayadata.io> To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> Cc: Bruce Richardson <bruce.richardson@intel.com>, Ranjit Menon <ranjit.menon@intel.com>, dev@dpdk.org, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, stable@dpdk.org Subject: Re: [dpdk-dev] [PATCH] build: fix symlink of drivers for Windows Date: Tue, 6 Apr 2021 11:24:24 +0100 Message-ID: <150aaea8-8da3-4d40-56d3-ee5baf9aa1e6@mayadata.io> (raw) In-Reply-To: <20210404030003.54bf9565@sovereign> > PDB (debuginfo) files can be quite large, do we want to install them? The script copies will only copy the .pdb files if they have already been installed into lib/dpdk/pmds-*/. If they haven't, we'll just skip the step. Whether they should be installed is a different question :-) Installing them seems to be a deliberate choice by meson (https://github.com/mesonbuild/meson/issues/1442). In my opinion, it's probably best to have them there. I looked at options apart from copying (including hard links) but in the end decided to keep it as simple as possible so it will 'just work' for cross builds from Linux, WSL-1, WSL-2, Msys, Cygnus etc. > +meson.add_install_script(py3, '../buildtools/symlink-drivers-solibs.py', > + get_option('libdir'), pmd_subdir_opt, get_option('bindir')) > > # set the machine type and cflags for it > if meson.is_cross_build() > As you may have seen, build fails because find_program() result cannot be > used in meson.add_install_script() until 0.55. Since your script has > Unix-specific part anyway and Windows recommends Meson 0.56, maybe Unices > should continue using shell variant and Python script can be Windows-only. Yes, I 'd been thinking about the best way to handle this. Your suggestion of having both scripts may well be the best option in the short term. Thanks, Nick
next prev parent reply other threads:[~2021-04-06 10:24 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-01 12:27 Nick Connolly 2021-04-04 0:00 ` Dmitry Kozlyuk 2021-04-06 10:24 ` Nick Connolly [this message] 2021-04-10 8:01 ` [dpdk-dev] [PATCH v2] " Nick Connolly 2021-04-24 0:53 ` Narcisa Ana Maria Vasile 2021-04-26 10:07 ` [dpdk-dev] [PATCH v3] " Nick Connolly 2021-05-27 17:37 ` Nick Connolly 2021-05-28 8:19 ` Bruce Richardson 2021-05-28 10:50 ` Nick Connolly 2021-05-28 8:19 ` Bruce Richardson 2021-07-09 15:05 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=150aaea8-8da3-4d40-56d3-ee5baf9aa1e6@mayadata.io \ --to=nick.connolly@mayadata.io \ --cc=bruce.richardson@intel.com \ --cc=dev@dpdk.org \ --cc=dmitry.kozliuk@gmail.com \ --cc=dmitrym@microsoft.com \ --cc=navasile@linux.microsoft.com \ --cc=pallavi.kadam@intel.com \ --cc=ranjit.menon@intel.com \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git