[dpdk-dev] [PATCH 0/3] AVF optimization

[dpdk-dev] [PATCH 0/3] AVF optimization

[Wenzhuo Lu]

The optimization for AVF code.
As the AVF patches is in the next-net repo but not merged
to the master branch, proposed these patches that can be
merged to the previouse ones.
Sorry for the inconvenience.

Wenzhuo Lu (3):
  net/avf/base: add spinlock functions
  net/avf: remove spinlock functions
  net/avf: remove useless code

 drivers/net/avf/avf.h            |  3 ---
 drivers/net/avf/avf_ethdev.c     | 24 ------------------------
 drivers/net/avf/base/avf_osdep.h | 23 +++++++++++++++++++++++
 3 files changed, 23 insertions(+), 27 deletions(-)

-- 
1.9.3

[dpdk-dev] [PATCH 1/3] net/avf/base: add spinlock functions

[Wenzhuo Lu]

Move the spinlock functions to the base code,
and make them inline.
This patch is for next-net and want to be squashed
to the commit in fixes tag.

Fixes: 8267939627e7 ("net/avf/base: add base code for avf PMD")
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
 drivers/net/avf/base/avf_osdep.h | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/drivers/net/avf/base/avf_osdep.h b/drivers/net/avf/base/avf_osdep.h
index 2f46bb2..9ef4596 100644
--- a/drivers/net/avf/base/avf_osdep.h
+++ b/drivers/net/avf/base/avf_osdep.h
@@ -156,6 +156,29 @@ struct avf_spinlock {
 #define avf_allocate_virt_mem(h, m, s) avf_allocate_virt_mem_d(h, m, s)
 #define avf_free_virt_mem(h, m) avf_free_virt_mem_d(h, m)
 
+static inline void
+avf_init_spinlock_d(struct avf_spinlock *sp)
+{
+	rte_spinlock_init(&sp->spinlock);
+}
+
+static inline void
+avf_acquire_spinlock_d(struct avf_spinlock *sp)
+{
+	rte_spinlock_lock(&sp->spinlock);
+}
+
+static inline void
+avf_release_spinlock_d(struct avf_spinlock *sp)
+{
+	rte_spinlock_unlock(&sp->spinlock);
+}
+
+static inline void
+avf_destroy_spinlock_d(__rte_unused struct avf_spinlock *sp)
+{
+}
+
 #define avf_init_spinlock(_sp) avf_init_spinlock_d(_sp)
 #define avf_acquire_spinlock(_sp) avf_acquire_spinlock_d(_sp)
 #define avf_release_spinlock(_sp) avf_release_spinlock_d(_sp)
-- 
1.9.3

[dpdk-dev] [PATCH 2/3] net/avf: remove spinlock functions

[Wenzhuo Lu]

Move the spinlock functions to the base code,
and make them inline.
This patch is for next-net and want to be squashed
to the commit in fixes tag.

Fixes: fcb27233824a ("net/avf: initialization of avf PMD")
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
 drivers/net/avf/avf_ethdev.c | 24 ------------------------
 1 file changed, 24 deletions(-)

diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index 0ed6e1c..f596e6b 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -409,27 +409,3 @@ enum avf_status_code
 
 	return AVF_SUCCESS;
 }
-
-/* spinlock func for base code */
-void
-avf_init_spinlock_d(struct avf_spinlock *sp)
-{
-	rte_spinlock_init(&sp->spinlock);
-}
-
-void
-avf_acquire_spinlock_d(struct avf_spinlock *sp)
-{
-	rte_spinlock_lock(&sp->spinlock);
-}
-
-void
-avf_release_spinlock_d(struct avf_spinlock *sp)
-{
-	rte_spinlock_unlock(&sp->spinlock);
-}
-
-void
-avf_destroy_spinlock_d(__rte_unused struct avf_spinlock *sp)
-{
-}
-- 
1.9.3

[dpdk-dev] [PATCH 3/3] net/avf: remove useless code

[Wenzhuo Lu]

Remove the useless code.
This patch is for next-net and want to be squashed
to the commit in fixes tag.

Fixes: fcb27233824a ("net/avf: initialization of avf PMD")
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
 drivers/net/avf/avf.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/avf/avf.h b/drivers/net/avf/avf.h
index 4694cc5..1e3825d 100644
--- a/drivers/net/avf/avf.h
+++ b/drivers/net/avf/avf.h
@@ -15,8 +15,6 @@
 #define AVF_QUEUE_BASE_ADDR_UNIT 128
 
 #define AVF_MAX_NUM_QUEUES       16
-/* Vlan table size */
-#define AVF_VLAN_TB_SIZE               (4096 / (CHAR_BIT * sizeof(uint32_t)))
 
 #define AVF_NUM_MACADDR_MAX      64
 
@@ -76,7 +74,6 @@ struct avf_info {
 	uint16_t num_queue_pairs;
 	uint16_t max_pkt_len; /* Maximum packet length */
 	uint16_t mac_num;     /* Number of MAC addresses */
-	uint32_t vlan[AVF_VLAN_TB_SIZE]; /* VLAN bit map */
 	bool promisc_unicast_enabled;
 	bool promisc_multicast_enabled;
 
-- 
1.9.3

Re: [dpdk-dev] [PATCH 0/3] AVF optimization

[Ferruh Yigit]

On 1/11/2018 6:52 AM, Wenzhuo Lu wrote:
> The optimization for AVF code.
> As the AVF patches is in the next-net repo but not merged
> to the master branch, proposed these patches that can be
> merged to the previouse ones.
> Sorry for the inconvenience.
> 
> Wenzhuo Lu (3):
>   net/avf/base: add spinlock functions
>   net/avf: remove spinlock functions
>   net/avf: remove useless code

Series squashed into relevant commit in next-net, thanks.

Please double check latest patches.