DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] ethdev: fix MTU setup error
@ 2018-01-31  2:08 Mallesh Koujalagi
  2018-01-31 18:34 ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Mallesh Koujalagi @ 2018-01-31  2:08 UTC (permalink / raw)
  To: dev; +Cc: mtetsuyah, malleshx.koujalagi

NULL device is failed to attach ovs, reported operation not supported
and configuration failed.

To attach ovs:
$VSCTL add-port ovs-br dpdk1 -- set Interface dpdk1 type=dpdk \
        options:dpdk-devargs=eth_null0,size=64,copy=1

Signed-off-by: Mallesh Koujalagi <malleshx.koujalagi@intel.com>
---
 drivers/net/null/rte_eth_null.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
index 7cd5c71..5fc2e1a 100644
--- a/drivers/net/null/rte_eth_null.c
+++ b/drivers/net/null/rte_eth_null.c
@@ -278,7 +278,11 @@ eth_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,
 	return 0;
 }
 
-
+static int
+eth_mtu_set(struct rte_eth_dev *dev __rte_unused, uint16_t mtu __rte_unused)
+{
+	return 0;
+}
 static void
 eth_dev_info(struct rte_eth_dev *dev,
 		struct rte_eth_dev_info *dev_info)
@@ -465,6 +469,7 @@ static const struct eth_dev_ops ops = {
 	.tx_queue_setup = eth_tx_queue_setup,
 	.rx_queue_release = eth_queue_release,
 	.tx_queue_release = eth_queue_release,
+	.mtu_set = eth_mtu_set,
 	.link_update = eth_link_update,
 	.stats_get = eth_stats_get,
 	.stats_reset = eth_stats_reset,
-- 
2.7.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] ethdev: fix MTU setup error
  2018-01-31  2:08 [dpdk-dev] [PATCH] ethdev: fix MTU setup error Mallesh Koujalagi
@ 2018-01-31 18:34 ` Ferruh Yigit
  2018-01-31 18:38   ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2018-01-31 18:34 UTC (permalink / raw)
  To: Mallesh Koujalagi, dev; +Cc: mtetsuyah

On 1/31/2018 2:08 AM, Mallesh Koujalagi wrote:

net/null: support MTU update

> NULL device is failed to attach ovs, reported operation not supported
> and configuration failed.
> 
> To attach ovs:
> $VSCTL add-port ovs-br dpdk1 -- set Interface dpdk1 type=dpdk \
>         options:dpdk-devargs=eth_null0,size=64,copy=1
> 
> Signed-off-by: Mallesh Koujalagi <malleshx.koujalagi@intel.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] ethdev: fix MTU setup error
  2018-01-31 18:34 ` Ferruh Yigit
@ 2018-01-31 18:38   ` Ferruh Yigit
  0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-01-31 18:38 UTC (permalink / raw)
  To: Mallesh Koujalagi, dev; +Cc: mtetsuyah

On 1/31/2018 6:34 PM, Ferruh Yigit wrote:
> On 1/31/2018 2:08 AM, Mallesh Koujalagi wrote:
> 
> net/null: support MTU update
> 
>> NULL device is failed to attach ovs, reported operation not supported
>> and configuration failed.
>>
>> To attach ovs:
>> $VSCTL add-port ovs-br dpdk1 -- set Interface dpdk1 type=dpdk \
>>         options:dpdk-devargs=eth_null0,size=64,copy=1
>>
>> Signed-off-by: Mallesh Koujalagi <malleshx.koujalagi@intel.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-01-31 18:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-31  2:08 [dpdk-dev] [PATCH] ethdev: fix MTU setup error Mallesh Koujalagi
2018-01-31 18:34 ` Ferruh Yigit
2018-01-31 18:38   ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).